25153 2009-04-12 23:30:11 -0700 Can't place the caret into text field that scrolls the window on focus 2009-04-13 14:14:05 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 justin.garcia justin.garcia adele bolsinga mitz oldest_to_newest 117284 0 justin.garcia 2009-04-12 23:30:11 -0700 Load the attached test case Click into the text field Text field is focused but selection isn't placed into the field <rdar://problem/6748324> 117285 1 29427 justin.garcia 2009-04-12 23:32:38 -0700 Created attachment 29427 test case 117290 2 justin.garcia 2009-04-13 00:08:30 -0700 The bug appears to be in handleMousePressEvent. There, we refetch the target node if it's a shadow node inside of a form field, see EventHandler.cpp:1156. In the test case, when we do that refetch we hit test with a bad document point. The document point is bad because it's generated from the window coordinate of the mouse click pre-scroll/zoom. the fix is to cache the document point before we dispatch the mouse event (since the window can scroll/zoom there). 117320 3 29432 justin.garcia 2009-04-13 11:53:23 -0700 Created attachment 29432 patch 117345 4 justin.garcia 2009-04-13 14:14:05 -0700 http://trac.webkit.org/changeset/42456 29427 2009-04-12 23:32:38 -0700 2009-04-12 23:32:38 -0700 test case rnf.html text/html 1162 justin.garcia d2Via2l0PGJyPgp3ZWJraXQ8YnI+CndlYmtpdDxicj4Kd2Via2l0PGJyPgo8aW5wdXQgb25Gb2N1 cz0id2luZG93LnNjcm9sbEJ5KDAsIDQwKSIgdmFsdWU9ImNsaWNrIGluIG1lIiA+CndlYmtpdDxi cj4Kd2Via2l0PGJyPgp3ZWJraXQ8YnI+CndlYmtpdDxicj4Kd2Via2l0PGJyPgp3ZWJraXQ8YnI+ CndlYmtpdDxicj4Kd2Via2l0PGJyPgp3ZWJraXQ8YnI+CndlYmtpdDxicj4Kd2Via2l0PGJyPgp3 ZWJraXQ8YnI+CndlYmtpdDxicj4Kd2Via2l0PGJyPgp3ZWJraXQ8YnI+CndlYmtpdDxicj4Kd2Vi a2l0PGJyPgp3ZWJraXQ8YnI+CndlYmtpdDxicj4Kd2Via2l0PGJyPgp3ZWJraXQ8YnI+CndlYmtp dDxicj4Kd2Via2l0PGJyPgp3ZWJraXQ8YnI+CndlYmtpdDxicj4Kd2Via2l0PGJyPgp3ZWJraXQ8 YnI+CndlYmtpdDxicj4Kd2Via2l0PGJyPgp3ZWJraXQ8YnI+CndlYmtpdDxicj4Kd2Via2l0PGJy Pgp3ZWJraXQ8YnI+CndlYmtpdDxicj4Kd2Via2l0PGJyPgp3ZWJraXQ8YnI+CndlYmtpdDxicj4K d2Via2l0PGJyPgp3ZWJraXQ8YnI+CndlYmtpdDxicj4Kd2Via2l0PGJyPgp3ZWJraXQ8YnI+Cndl YmtpdDxicj4Kd2Via2l0PGJyPgp3ZWJraXQ8YnI+CndlYmtpdDxicj4Kd2Via2l0PGJyPgp3ZWJr aXQ8YnI+CndlYmtpdDxicj4Kd2Via2l0PGJyPgp3ZWJraXQ8YnI+CndlYmtpdDxicj4Kd2Via2l0 PGJyPgp3ZWJraXQ8YnI+CndlYmtpdDxicj4Kd2Via2l0PGJyPgp3ZWJraXQ8YnI+CndlYmtpdDxi cj4Kd2Via2l0PGJyPgp3ZWJraXQ8YnI+CndlYmtpdDxicj4Kd2Via2l0PGJyPgp3ZWJraXQ8YnI+ CndlYmtpdDxicj4Kd2Via2l0PGJyPgp3ZWJraXQ8YnI+CndlYmtpdDxicj4Kd2Via2l0PGJyPgp3 ZWJraXQ8YnI+CndlYmtpdDxicj4Kd2Via2l0PGJyPgp3ZWJraXQ8YnI+CndlYmtpdDxicj4Kd2Vi a2l0PGJyPgp3ZWJraXQ8YnI+CndlYmtpdDxicj4Kd2Via2l0PGJyPgp3ZWJraXQ8YnI+CndlYmtp dDxicj4Kd2Via2l0PGJyPgp3ZWJraXQ8YnI+CndlYmtpdDxicj4Kd2Via2l0PGJyPgp3ZWJraXQ8 YnI+CndlYmtpdDxicj4Kd2Via2l0PGJyPgp3ZWJraXQ8YnI+CndlYmtpdDxicj4Kd2Via2l0PGJy Pgp3ZWJraXQ8YnI+CndlYmtpdDxicj4Kd2Via2l0PGJyPgp3ZWJraXQ8YnI+CndlYmtpdDxicj4K d2Via2l0PGJyPgp3ZWJraXQ8YnI+Cg== 29432 2009-04-13 11:53:23 -0700 2009-04-13 12:40:54 -0700 patch documentpoint.txt text/plain 5381 justin.garcia SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MjQzMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDktMDQtMTMgIEp1c3RpbiBHYXJjaWEgIDxqdXN0aW4uZ2FyY2lh QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjUxNTMKKyAgICAg ICAgQ2FuJ3QgcGxhY2UgdGhlIGNhcmV0IGludG8gdGV4dCBmaWVsZCB0aGF0IHNjcm9sbHMgdGhl IHdpbmRvdyBvbiBmb2N1cworICAgICAgICAKKyAgICAgICAgV2UgcmVmZXRjaCB0aGUgdGFyZ2V0 IG5vZGUgaW4gdGhlIHNoYWRvdyBub2RlIGNhc2UsIGFuZCB3aGVuIHdlIGRvIHNvIHRoZSB3aW5k b3cgY29vcmRpbmF0ZSBmb3IgdGhlIG1vdXNlIGV2ZW50IG1heQorICAgICAgICBiZSBpbnZhbGlk IGJlY2F1c2Ugb2Ygc2Nyb2xsaW5nIHRoYXQgdGhlIGZvY3VzIGhhbmRsZXIgZGlkLiAgQ2FjaGUg dGhlIGRvY3VtZW50IHBvaW50ICh0aGF0IHdlIGRlcml2ZWQgZnJvbSB0aGUgd2luZG93CisgICAg ICAgIGNvb3JkaW5hdGUpIGFuZCB1c2UgdGhhdCBhbnkgdGltZSB3ZSByZWZldGNoLgorCisgICAg ICAgICogcGFnZS9FdmVudEhhbmRsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6ZG9jdW1lbnRQ b2ludEZvcldpbmRvd1BvaW50KToKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6aGFu ZGxlTW91c2VQcmVzc0V2ZW50KToKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6cHJl cGFyZU1vdXNlRXZlbnQpOgorCiAyMDA5LTA0LTEyICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFyayBSb3dlLgpJbmRleDogV2ViQ29yZS9wYWdl L0V2ZW50SGFuZGxlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxl ci5jcHAJKHJldmlzaW9uIDQyNDMwKQorKysgV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTEwMzksNiArMTAzOSwxNCBAQAogICAgIH0KICAgICByZXR1cm4g cG9pbnRlckN1cnNvcigpOwogfQorICAgIAorSW50UG9pbnQgZG9jdW1lbnRQb2ludEZvcldpbmRv d1BvaW50KEZyYW1lKiBmcmFtZSwgY29uc3QgSW50UG9pbnQmIHdpbmRvd1BvaW50KQoreworICAg IEZyYW1lVmlldyogdmlldyA9IGZyYW1lLT52aWV3KCk7CisgICAgLy8gRklYTUU6IElzIGl0IHJl YWxseSBPSyB0byB1c2UgdGhlIHdyb25nIGNvb3JkaW5hdGVzIGhlcmUgd2hlbiB2aWV3IGlzIDA/ CisgICAgLy8gSGlzdG9yaWNhbGx5IHRoZSBjb2RlIHdvdWxkIGp1c3QgY3Jhc2g7IHRoaXMgaXMg Y2xlYXJseSBubyB3b3JzZSB0aGFuIHRoYXQuCisgICAgcmV0dXJuIHZpZXcgPyB2aWV3LT53aW5k b3dUb0NvbnRlbnRzKHdpbmRvd1BvaW50KSA6IHdpbmRvd1BvaW50OworfQogCiBib29sIEV2ZW50 SGFuZGxlcjo6aGFuZGxlTW91c2VQcmVzc0V2ZW50KGNvbnN0IFBsYXRmb3JtTW91c2VFdmVudCYg bW91c2VFdmVudCkKIHsKQEAgLTEwNjAsNyArMTA2OCw4IEBACiAgICAgbV9tb3VzZURvd25XYXNJ blN1YmZyYW1lID0gZmFsc2U7CiAKICAgICBIaXRUZXN0UmVxdWVzdCByZXF1ZXN0KEhpdFRlc3RS ZXF1ZXN0OjpBY3RpdmUpOwotICAgIE1vdXNlRXZlbnRXaXRoSGl0VGVzdFJlc3VsdHMgbWV2ID0g cHJlcGFyZU1vdXNlRXZlbnQocmVxdWVzdCwgbW91c2VFdmVudCk7CisgICAgSW50UG9pbnQgZG9j dW1lbnRQb2ludCA9IGRvY3VtZW50UG9pbnRGb3JXaW5kb3dQb2ludChtX2ZyYW1lLCBtb3VzZUV2 ZW50LnBvcygpKTsKKyAgICBNb3VzZUV2ZW50V2l0aEhpdFRlc3RSZXN1bHRzIG1ldiA9IG1fZnJh bWUtPmRvY3VtZW50KCktPnByZXBhcmVNb3VzZUV2ZW50KHJlcXVlc3QsIGRvY3VtZW50UG9pbnQs IG1vdXNlRXZlbnQpOwogCiAgICAgaWYgKCFtZXYudGFyZ2V0Tm9kZSgpKSB7CiAgICAgICAgIGlu dmFsaWRhdGVDbGljaygpOwpAQCAtMTEzOSw3ICsxMTQ4LDcgQEAKICAgICBpZiAobWV2LnNjcm9s bGJhcigpKSB7CiAgICAgICAgIGNvbnN0IGJvb2wgd2FzTGFzdFNjcm9sbEJhciA9IG1ldi5zY3Jv bGxiYXIoKSA9PSBtX2xhc3RTY3JvbGxiYXJVbmRlck1vdXNlLmdldCgpOwogICAgICAgICBIaXRU ZXN0UmVxdWVzdCByZXF1ZXN0KEhpdFRlc3RSZXF1ZXN0OjpSZWFkT25seSB8IEhpdFRlc3RSZXF1 ZXN0OjpBY3RpdmUpOwotICAgICAgICBtZXYgPSBwcmVwYXJlTW91c2VFdmVudChyZXF1ZXN0LCBt b3VzZUV2ZW50KTsKKyAgICAgICAgbWV2ID0gbV9mcmFtZS0+ZG9jdW1lbnQoKS0+cHJlcGFyZU1v dXNlRXZlbnQocmVxdWVzdCwgZG9jdW1lbnRQb2ludCwgbW91c2VFdmVudCk7CiAgICAgICAgIGlm ICh3YXNMYXN0U2Nyb2xsQmFyICYmIG1ldi5zY3JvbGxiYXIoKSAhPSBtX2xhc3RTY3JvbGxiYXJV bmRlck1vdXNlLmdldCgpKQogICAgICAgICAgICAgbV9sYXN0U2Nyb2xsYmFyVW5kZXJNb3VzZSA9 IDA7CiAgICAgfQpAQCAtMTE1NSw3ICsxMTY0LDcgQEAKICAgICAgICAgLy8gZXZlbnQgdGFyZ2V0 IG5vZGUgY2FuJ3Qgc3RpbGwgYmUgdGhlIHNoYWRvdyBub2RlLgogICAgICAgICBpZiAobWV2LnRh cmdldE5vZGUoKS0+aXNTaGFkb3dOb2RlKCkgJiYgbWV2LnRhcmdldE5vZGUoKS0+c2hhZG93UGFy ZW50Tm9kZSgpLT5oYXNUYWdOYW1lKGlucHV0VGFnKSkgewogICAgICAgICAgICAgSGl0VGVzdFJl cXVlc3QgcmVxdWVzdChIaXRUZXN0UmVxdWVzdDo6UmVhZE9ubHkgfCBIaXRUZXN0UmVxdWVzdDo6 QWN0aXZlKTsKLSAgICAgICAgICAgIG1ldiA9IHByZXBhcmVNb3VzZUV2ZW50KHJlcXVlc3QsIG1v dXNlRXZlbnQpOworICAgICAgICAgICAgbWV2ID0gbV9mcmFtZS0+ZG9jdW1lbnQoKS0+cHJlcGFy ZU1vdXNlRXZlbnQocmVxdWVzdCwgZG9jdW1lbnRQb2ludCwgbW91c2VFdmVudCk7CiAgICAgICAg IH0KIAogICAgICAgICBGcmFtZVZpZXcqIHZpZXcgPSBtX2ZyYW1lLT52aWV3KCk7CkBAIC0xNDk5 LDEyICsxNTA4LDggQEAKIHsKICAgICBBU1NFUlQobV9mcmFtZSk7CiAgICAgQVNTRVJUKG1fZnJh bWUtPmRvY3VtZW50KCkpOwotCi0gICAgRnJhbWVWaWV3KiB2aWV3ID0gbV9mcmFtZS0+dmlldygp OwotICAgIC8vIEZJWE1FOiBJcyBpdCByZWFsbHkgT0sgdG8gdXNlIHRoZSB3cm9uZyBjb29yZGlu YXRlcyBoZXJlIHdoZW4gdmlldyBpcyAwPwotICAgIC8vIEhpc3RvcmljYWxseSB0aGUgY29kZSB3 b3VsZCBqdXN0IGNyYXNoOyB0aGlzIGlzIGNsZWFybHkgbm8gd29yc2UgdGhhbiB0aGF0LgotICAg IEludFBvaW50IGRvY3VtZW50UG9pbnQgPSB2aWV3ID8gdmlldy0+d2luZG93VG9Db250ZW50cyht ZXYucG9zKCkpIDogbWV2LnBvcygpOwotICAgIHJldHVybiBtX2ZyYW1lLT5kb2N1bWVudCgpLT5w cmVwYXJlTW91c2VFdmVudChyZXF1ZXN0LCBkb2N1bWVudFBvaW50LCBtZXYpOworICAgIAorICAg IHJldHVybiBtX2ZyYW1lLT5kb2N1bWVudCgpLT5wcmVwYXJlTW91c2VFdmVudChyZXF1ZXN0LCBk b2N1bWVudFBvaW50Rm9yV2luZG93UG9pbnQobV9mcmFtZSwgbWV2LnBvcygpKSwgbWV2KTsKIH0K IAogI2lmIEVOQUJMRShTVkcpCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zLzI1MTUzLWV4 cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zLzI1MTUzLWV4 cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvMjUxNTMt ZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxIEBACitTdWNjZXNzCkluZGV4OiBM YXlvdXRUZXN0cy9mYXN0L2Zvcm1zLzI1MTUzLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvZmFzdC9mb3Jtcy8yNTE1My5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFz dC9mb3Jtcy8yNTE1My5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDE5IEBACitUaGlzIHRl c3RzIHRvIG1ha2Ugc3VyZSB0aGF0IGNsaWNraW5nIGluc2lkZSBhIHRleHQgZmllbGQgcGxhY2Vz IHRoZSBjYXJldCBpbiBpdCwgZXZlbiBpZiB0aGUgZmllbGRzIGZvY3VzIGhhbmRsZXIgc2Nyb2xs cyB0aGUgZG9jdW1lbnQuICBDbGljayBpbnNpZGUgdGhlIHRleHQgZmllbGQgYW5kIHZlcmlmeSB0 aGF0IHRoZSBjYXJldCBpcyBwbGFjZWQgd2hlcmUgeW91IGNsaWNrLjxicj4KKzxpbnB1dCBpZD0i dGV4dGZpZWxkIiBvbkZvY3VzPSJ3aW5kb3cuc2Nyb2xsQnkoMCwgNDApIiB2YWx1ZT0iY2xpY2sg aW4gbWUiPjxicj4KKzxkaXYgc3R5bGU9ImhlaWdodDogMTUwMHB4OyI+Cis8c2NyaXB0PgoraWYg KCF3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgcmV0dXJuOword2luZG93LmxheW91 dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKK3RleHRmaWVsZCA9IGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCJ0ZXh0ZmllbGQiKTsKKy8vIENsaWNrIG5lYXIgdGhlIGVuZCBvZiB0aGUgZmll bGQgc28gdGhhdCB0aGUgY2FyZXQgYWZ0ZXIgYWxsIG9mIHRoZSB0ZXh0IGluc2lkZSBpdC4KK3gg PSB0ZXh0ZmllbGQub2Zmc2V0UGFyZW50Lm9mZnNldExlZnQgKyB0ZXh0ZmllbGQub2Zmc2V0TGVm dCArIHRleHRmaWVsZC5vZmZzZXRXaWR0aCAtIDU7Cit5ID0gdGV4dGZpZWxkLm9mZnNldFBhcmVu dC5vZmZzZXRUb3AgKyB0ZXh0ZmllbGQub2Zmc2V0VG9wICsgdGV4dGZpZWxkLm9mZnNldEhlaWdo dCAvIDI7CitldmVudFNlbmRlci5tb3VzZU1vdmVUbyh4LCB5KTsKK2V2ZW50U2VuZGVyLm1vdXNl RG93bigpOworZXZlbnRTZW5kZXIubW91c2VVcCgpOworaWYgKHRleHRmaWVsZC5zZWxlY3Rpb25T dGFydCA9PSB0ZXh0ZmllbGQudmFsdWUubGVuZ3RoICYmIHRleHRmaWVsZC5zZWxlY3Rpb25FbmQg PT0gdGV4dGZpZWxkLnZhbHVlLmxlbmd0aCkKKyAgICBkb2N1bWVudC5ib2R5LmlubmVyVGV4dCA9 ICJTdWNjZXNzIgorZWxzZQorICAgIGRvY3VtZW50LmJvZHkuaW5uZXJUZXh0ID0gIkZhaWx1cmUu ICBFeHBlY3RlZCBzZWxlY3Rpb24gdG8gYmUgYWZ0ZXIgYWxsIG9mIHRoZSB0ZXh0IGluIHRoZSB0 ZXh0IGZpZWxkLiIKKzwvc2NyaXB0Pgo=