25143 2009-04-11 13:31:32 -0700 [Qt] Build error in module WebKit/qt/tests/qwebelement/tst_qwebelement.cpp 2009-04-22 05:06:34 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Linux RESOLVED DUPLICATE 25242 P2 Normal --- 0 cmsigler webkit-unassigned oldest_to_newest 117233 0 cmsigler 2009-04-11 13:31:32 -0700 Hi, As of r42423, the Qt Linux build fails with a compile error: ----------------------------------- g++ -c -pipe -march=pentium3 -O2 -pipe -Wall -W -D_REENTRANT -DQT_SHARED -DBUILDING_QT__=1 -DUSE_SYSTEM_MALLOC -DNDEBUG -DQT_NO_DEBUG -DQT_TESTLIB_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -I/usr/share/qt4/mkspecs/linux-g++ -I/opt/siglercm/webkit/WebKit/WebKit/qt/tests/qwebelement -I/usr/include/qt4/QtCore -I/usr/include/qt4/QtCore -I/usr/include/qt4/QtNetwork -I/usr/include/qt4/QtNetwork -I/usr/include/qt4/QtGui -I/usr/include/qt4/QtGui -I/usr/include/qt4/QtTest -I/usr/include/qt4/QtTest -I/usr/include/qt4 -I/opt/siglercm/webkit/WebKit/WebKit/qt/Api -I/opt/siglercm/webkit/WebKit/WebKit/qt/tests/qwebelement -I/opt/siglercm/webkit/WebKit/WebKit/qt/tests/qwebelement -I. -o tst_qwebelement.o /opt/siglercm/webkit/WebKit/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp ./WebKit/qt/tests/qwebelement/tst_qwebelement.cpp: In member function 'void tst_QWebElement::iteration()': ./WebKit/qt/tests/qwebelement/tst_qwebelement.cpp:304: error: 'class QList<QWebElement>' has no member named 'length' ./WebKit/qt/tests/qwebelement/tst_qwebelement.cpp:305: error: 'class QList<QWebElement>' has no member named 'length' ./WebKit/qt/tests/qwebelement/tst_qwebelement.cpp:305: error: 'class QList<QWebElement>' has no member named 'length' ./WebKit/qt/tests/qwebelement/tst_qwebelement.cpp:313: error: 'class QList<QWebElement>' has no member named 'length' ./WebKit/qt/tests/qwebelement/tst_qwebelement.cpp:314: error: 'class QList<QWebElement>' has no member named 'length' ./WebKit/qt/tests/qwebelement/tst_qwebelement.cpp:314: error: 'class QList<QWebElement>' has no member named 'length' make[2]: *** [tst_qwebelement.o] Error 1 make[2]: Leaving directory `./WebKitBuild/Release/WebKit/qt/tests/qwebelement' make[1]: *** [sub-qwebelement-make_default] Error 2 make[1]: Leaving directory `./WebKitBuild/Release/WebKit/qt/tests' make: *** [sub-WebKit-qt-tests-make_default-ordered] Error 2 ----------------------------------- This module and the method -- void tst_QWebElement::iteration() -- in which it throws an error are not well documented, so I'm not sure what the developer is trying to do, or why length is not defined in the class being used. Sorry I can't be of more assistance. TIA. Clemmitt 117234 1 cmsigler 2009-04-11 13:44:01 -0700 (In reply to comment #0) Hi again, Bad form to reply to oneself and all, but anyway. I see that as of a few weeks ago the Buildbot setup at build.webkit.org changed. Now only OS X and Windows builds are running there. Are there any plans to add back build slaves for the Linux GTK+ and Linux Qt builds (and perhaps even the Linux wxWindows build, if that's appropriate)? Or maybe these build slaves have moved to another buildbot hosted elsewhere? Heaven knows I searched for another one via Google without success. This seems an appropriate place to ask, since build errors like this one aren't caught if no buildbot is running for this platform, eh? Thanks again very much :^) Clemmitt 117662 2 cmsigler 2009-04-15 13:37:53 -0700 (In reply to comment #0) > As of r42423, the Qt Linux build fails with a compile error: Well, since my own Qt Linux build at r42550 was still failing in tst_qwebelement.cpp, I took a stab in the dark that the developer meant to use the method "size" for class QList instead of "length" which is undefined. This, at least, got my build to complete without failing on an error. A patch is attached next. (There may be another bug, this time in the Acid3 test. If so, I'll file a separate bug report on it. For now, my Qt Linux build crashes reliably near the end of running Acid3. I'll wait a few days to see if things settle down and this problem goes away.) HTH. Clemmitt 117663 3 29515 cmsigler 2009-04-15 13:40:48 -0700 Created attachment 29515 Patch to fix Qt Linux build error in module tst_qwebelement.cpp This patch fixes a build error under Qt Linux in module tst_qwebelement.cpp. I think this is what the developer who wrote this module was aiming for.... 117896 4 ariya.hidayat 2009-04-17 05:19:42 -0700 Similar fix has been independently landed in http://trac.webkit.org/changeset/42608 *** This bug has been marked as a duplicate of 25242 *** 29515 2009-04-15 13:40:48 -0700 2009-04-22 05:06:34 -0700 Patch to fix Qt Linux build error in module tst_qwebelement.cpp tst_qwebelement.cpp.patch text/plain 1013 cmsigler LS0tIFdlYktpdC9xdC90ZXN0cy9xd2ViZWxlbWVudC90c3RfcXdlYmVsZW1lbnQuY3BwLm9yaWcJ MjAwOS0wNC0xNSAxNDozMDo0MS4wMDAwMDAwMDAgLTA0MDAKKysrIFdlYktpdC9xdC90ZXN0cy9x d2ViZWxlbWVudC90c3RfcXdlYmVsZW1lbnQuY3BwCTIwMDktMDQtMTUgMTY6Mjg6MzYuMDAwMDAw MDAwIC0wNDAwCkBAIC0zMDEsOCArMzAxLDggQEAKICAgICBmb3JlYWNoKFFXZWJFbGVtZW50IHAs IHBhcmFzKSB7CiAgICAgICAgIGZvcmVhY2hMaXN0LmFwcGVuZChwKTsKICAgICB9Ci0gICAgUVZF UklGWShmb3JlYWNoTGlzdC5sZW5ndGgoKSA9PSAyKTsKLSAgICBRQ09NUEFSRShmb3JlYWNoTGlz dC5sZW5ndGgoKSwgcmVmZXJlbmNlTGlzdC5sZW5ndGgoKSk7CisgICAgUVZFUklGWShmb3JlYWNo TGlzdC5zaXplKCkgPT0gMik7CisgICAgUUNPTVBBUkUoZm9yZWFjaExpc3Quc2l6ZSgpLCByZWZl cmVuY2VMaXN0LnNpemUoKSk7CiAgICAgUUNPTVBBUkUoZm9yZWFjaExpc3QuYXQoMCksIHJlZmVy ZW5jZUxpc3QuYXQoMCkpOwogICAgIFFDT01QQVJFKGZvcmVhY2hMaXN0LmF0KDEpLCByZWZlcmVu Y2VMaXN0LmF0KDEpKTsKIApAQCAtMzEwLDggKzMxMCw4IEBACiAgICAgZm9yIChpbnQgaSA9IDA7 IGkgPCBwYXJhcy5jb3VudCgpOyArK2kpIHsKICAgICAgICAgZm9yTG9vcExpc3QuYXBwZW5kKHBh cmFzLmF0KGkpKTsKICAgICB9Ci0gICAgUVZFUklGWShmb3JlYWNoTGlzdC5sZW5ndGgoKSA9PSAy KTsKLSAgICBRQ09NUEFSRShmb3JlYWNoTGlzdC5sZW5ndGgoKSwgcmVmZXJlbmNlTGlzdC5sZW5n dGgoKSk7CisgICAgUVZFUklGWShmb3JlYWNoTGlzdC5zaXplKCkgPT0gMik7CisgICAgUUNPTVBB UkUoZm9yZWFjaExpc3Quc2l6ZSgpLCByZWZlcmVuY2VMaXN0LnNpemUoKSk7CiAgICAgUUNPTVBB UkUoZm9yZWFjaExpc3QuYXQoMCksIHJlZmVyZW5jZUxpc3QuYXQoMCkpOwogICAgIFFDT01QQVJF KGZvcmVhY2hMaXN0LmF0KDEpLCByZWZlcmVuY2VMaXN0LmF0KDEpKTsKIAo=