25133 2009-04-10 13:58:32 -0700 Fix binding oops and clean up InspectorController parts 2009-04-10 15:27:41 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dglazkov dglazkov timothy oldest_to_newest 117176 0 dglazkov 2009-04-10 13:58:32 -0700 Just some things that I noticed while writing V8 bindings. 117177 1 29397 dglazkov 2009-04-10 14:08:00 -0700 Created attachment 29397 Misc cleanup in Inspector-land, v1. WebCore/ChangeLog | 19 +++++++++++++++++++ .../bindings/js/JSInspectorControllerCustom.cpp | 2 +- WebCore/bindings/js/ScriptObject.cpp | 17 ++++++----------- WebCore/bindings/js/ScriptObject.h | 3 ++- WebCore/inspector/ConsoleMessage.cpp | 1 - WebCore/inspector/ConsoleMessage.h | 1 - WebCore/inspector/InspectorResource.cpp | 2 +- 7 files changed, 29 insertions(+), 16 deletions(-) 117190 2 dglazkov 2009-04-10 15:27:41 -0700 Landed as http://trac.webkit.org/changeset/42408. 29397 2009-04-10 14:08:00 -0700 2009-04-10 15:18:08 -0700 Misc cleanup in Inspector-land, v1. Misc-cleanup-in-Inspector-land-v1..patch text/plain 5207 dglazkov ZjdmMWVkMmNiZDExODJhMmEzN2FkMDgzYTZiZjI1ODVjMGU4YzlhZQpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA5ZjkwODYyLi45NTFkZDI4 IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDIyIEBACisyMDA5LTA0LTEwICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1MTMzCisgICAg ICAgIEZpeCBhbiBlcnJvciBpbiBJbnNwZWN0b3JDb250cm9sbGVyJ3MgYmluZGluZ3MsIGNsZWFu IHVwIGEgZmV3IGhlYWRlcgorICAgICAgICBpbmNsdWRlcywgbWFrZSBlbXB0eSBvYmplY3QgY29u c3RydWN0aW9uIGluIFNjcmlwdE9iamVjdCBsZXNzIGFtYmlndW91cy4KKworICAgICAgICAqIGJp bmRpbmdzL2pzL0pTSW5zcGVjdG9yQ29udHJvbGxlckN1c3RvbS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpKU0luc3BlY3RvckNvbnRyb2xsZXI6OnNldFNldHRpbmcpOiBTZW5kIGNvcnJlY3QgYXJn dW1lbnQgZnJvbQorICAgICAgICAgICAgdGhlIGJpbmRpbmdzLgorICAgICAgICAqIGJpbmRpbmdz L2pzL1NjcmlwdE9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JpcHRPYmplY3Q6OmNy ZWF0ZU5ldyk6IEFkZGVkLgorICAgICAgICAqIGJpbmRpbmdzL2pzL1NjcmlwdE9iamVjdC5oOiBS ZW1vdmVkIGNvbnN0cnVjdG9yLCBhZGRlZCBkZWNsIGZvciBjcmVhdGVOZXcuCisgICAgICAgICog aW5zcGVjdG9yL0NvbnNvbGVNZXNzYWdlLmNwcDogUmVtb3ZlIHVudXNlZCBoZWFkZXIuCisgICAg ICAgICogaW5zcGVjdG9yL0NvbnNvbGVNZXNzYWdlLmg6IERpdHRvLgorICAgICAgICAqIGluc3Bl Y3Rvci9JbnNwZWN0b3JSZXNvdXJjZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjcmVhdGVIZWFk ZXJzT2JqZWN0KTogQ2hhbmdlZCB0byB1c2UgU2NyaXB0T2JqZWN0OjpjcmVhdGVOZXcuCisKIDIw MDktMDQtMTAgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgogCiAgICAgICAgIEdpdmUg V2luZG93cydzIDxzZWxlY3Q+IHBvcHVwIG1lbnVzIGRyb3Agc2hhZG93cwpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9iaW5kaW5ncy9qcy9KU0luc3BlY3RvckNvbnRyb2xsZXJDdXN0b20uY3BwIGIvV2Vi Q29yZS9iaW5kaW5ncy9qcy9KU0luc3BlY3RvckNvbnRyb2xsZXJDdXN0b20uY3BwCmluZGV4IDA3 MDIyYzIuLjk3MmZkZGMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvanMvSlNJbnNwZWN0 b3JDb250cm9sbGVyQ3VzdG9tLmNwcAorKysgYi9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTSW5zcGVj dG9yQ29udHJvbGxlckN1c3RvbS5jcHAKQEAgLTI3Nyw3ICsyNzcsNyBAQCBKU1ZhbHVlUHRyIEpT SW5zcGVjdG9yQ29udHJvbGxlcjo6c2V0U2V0dGluZyhFeGVjU3RhdGUqIGV4ZWMsIGNvbnN0IEFy Z0xpc3QmIGFyZwogCiAgICAgSW5zcGVjdG9yQ29udHJvbGxlcjo6U2V0dGluZyBzZXR0aW5nOwog Ci0gICAgSlNWYWx1ZVB0ciB2YWx1ZSA9IGFyZ3MuYXQoZXhlYywgMCk7CisgICAgSlNWYWx1ZVB0 ciB2YWx1ZSA9IGFyZ3MuYXQoZXhlYywgMSk7CiAgICAgaWYgKHZhbHVlLmlzVW5kZWZpbmVkKCkg fHwgdmFsdWUuaXNOdWxsKCkpIHsKICAgICAgICAgLy8gRG8gbm90aGluZy4gVGhlIHNldHRpbmcg aXMgYWxyZWFkeSBOb1R5cGUuCiAgICAgICAgIEFTU0VSVChzZXR0aW5nLnR5cGUoKSA9PSBJbnNw ZWN0b3JDb250cm9sbGVyOjpTZXR0aW5nOjpOb1R5cGUpOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9i aW5kaW5ncy9qcy9TY3JpcHRPYmplY3QuY3BwIGIvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRP YmplY3QuY3BwCmluZGV4IDViYzZhZjQuLjUxYjY5ZTkgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmlu ZGluZ3MvanMvU2NyaXB0T2JqZWN0LmNwcAorKysgYi9XZWJDb3JlL2JpbmRpbmdzL2pzL1Njcmlw dE9iamVjdC5jcHAKQEAgLTQ1LDE3ICs0NSw2IEBAIFNjcmlwdE9iamVjdDo6U2NyaXB0T2JqZWN0 KEpTT2JqZWN0KiBvYmplY3QpCiB7CiB9CiAKLXN0YXRpYyBKU1ZhbHVlUHRyIGNyZWF0ZUVtcHR5 T2JqZWN0KFNjcmlwdFN0YXRlKiBzY3JpcHRTdGF0ZSkKLXsKLSAgICBKU0xvY2sgbG9jayhmYWxz ZSk7Ci0gICAgcmV0dXJuIGNvbnN0cnVjdEVtcHR5T2JqZWN0KHNjcmlwdFN0YXRlKTsKLX0KLQot U2NyaXB0T2JqZWN0OjpTY3JpcHRPYmplY3QoU2NyaXB0U3RhdGUqIHNjcmlwdFN0YXRlKQotICAg IDogU2NyaXB0VmFsdWUoY3JlYXRlRW1wdHlPYmplY3Qoc2NyaXB0U3RhdGUpKQotewotfQotCiBz dGF0aWMgYm9vbCBoYW5kbGVFeGNlcHRpb24oU2NyaXB0U3RhdGUqIHNjcmlwdFN0YXRlKQogewog ICAgIGlmICghc2NyaXB0U3RhdGUtPmhhZEV4Y2VwdGlvbigpKQpAQCAtMTIxLDYgKzExMCwxMiBA QCBib29sIFNjcmlwdE9iamVjdDo6c2V0KFNjcmlwdFN0YXRlKiBzY3JpcHRTdGF0ZSwgY29uc3Qg Y2hhciogbmFtZSwgYm9vbCB2YWx1ZSkKICAgICByZXR1cm4gaGFuZGxlRXhjZXB0aW9uKHNjcmlw dFN0YXRlKTsKIH0KIAorU2NyaXB0T2JqZWN0IFNjcmlwdE9iamVjdDo6Y3JlYXRlTmV3KFNjcmlw dFN0YXRlKiBzY3JpcHRTdGF0ZSkKK3sKKyAgICBKU0xvY2sgbG9jayhmYWxzZSk7CisgICAgcmV0 dXJuIFNjcmlwdE9iamVjdChjb25zdHJ1Y3RFbXB0eU9iamVjdChzY3JpcHRTdGF0ZSkpOworfQor CiBib29sIFNjcmlwdEdsb2JhbE9iamVjdDo6c2V0KFNjcmlwdFN0YXRlKiBzY3JpcHRTdGF0ZSwg Y29uc3QgY2hhciogbmFtZSwgY29uc3QgU2NyaXB0T2JqZWN0JiB2YWx1ZSkKIHsKICAgICBKU0xv Y2sgbG9jayhmYWxzZSk7CmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdE9i amVjdC5oIGIvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRPYmplY3QuaAppbmRleCBlNWJiYzky Li44Njg3MzM3IDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdE9iamVjdC5o CisrKyBiL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0T2JqZWN0LmgKQEAgLTQzLDcgKzQzLDYg QEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgIGNsYXNzIFNjcmlwdE9iamVjdCA6IHB1YmxpYyBT Y3JpcHRWYWx1ZSB7CiAgICAgcHVibGljOgogICAgICAgICBTY3JpcHRPYmplY3QoSlNDOjpKU09i amVjdCopOwotICAgICAgICBTY3JpcHRPYmplY3QoU2NyaXB0U3RhdGUqKTsKICAgICAgICAgU2Ny aXB0T2JqZWN0KCkge30KICAgICAgICAgSlNDOjpKU09iamVjdCoganNPYmplY3QoKSBjb25zdCB7 IHJldHVybiBhc09iamVjdChqc1ZhbHVlKCkpOyB9CiAKQEAgLTU0LDYgKzUzLDggQEAgbmFtZXNw YWNlIFdlYkNvcmUgewogICAgICAgICBib29sIHNldChTY3JpcHRTdGF0ZSosIGNvbnN0IGNoYXIq IG5hbWUsIGxvbmcgbG9uZyk7CiAgICAgICAgIGJvb2wgc2V0KFNjcmlwdFN0YXRlKiwgY29uc3Qg Y2hhciogbmFtZSwgaW50KTsKICAgICAgICAgYm9vbCBzZXQoU2NyaXB0U3RhdGUqLCBjb25zdCBj aGFyKiBuYW1lLCBib29sKTsKKworICAgICAgICBzdGF0aWMgU2NyaXB0T2JqZWN0IGNyZWF0ZU5l dyhTY3JpcHRTdGF0ZSopOwogICAgIH07CiAKICAgICBjbGFzcyBTY3JpcHRHbG9iYWxPYmplY3Qg ewpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvQ29uc29sZU1lc3NhZ2UuY3BwIGIvV2Vi Q29yZS9pbnNwZWN0b3IvQ29uc29sZU1lc3NhZ2UuY3BwCmluZGV4IDQ4ZWUyMzAuLmM4MzJhNGMg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL0NvbnNvbGVNZXNzYWdlLmNwcAorKysgYi9X ZWJDb3JlL2luc3BlY3Rvci9Db25zb2xlTWVzc2FnZS5jcHAKQEAgLTMxLDcgKzMxLDYgQEAKICNp bmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJDb25zb2xlTWVzc2FnZS5oIgogCi0jaW5jbHVk ZSAiSlNJbnNwZWN0ZWRPYmplY3RXcmFwcGVyLmgiCiAjaW5jbHVkZSAiU2NyaXB0Q2FsbFN0YWNr LmgiCiAjaW5jbHVkZSAiU2NyaXB0Q2FsbEZyYW1lLmgiCiAjaW5jbHVkZSAiU2NyaXB0RnVuY3Rp b25DYWxsLmgiCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9Db25zb2xlTWVzc2FnZS5o IGIvV2ViQ29yZS9pbnNwZWN0b3IvQ29uc29sZU1lc3NhZ2UuaAppbmRleCBkOTdjYmIzLi5iNDFh Mzg2IDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9Db25zb2xlTWVzc2FnZS5oCisrKyBi L1dlYkNvcmUvaW5zcGVjdG9yL0NvbnNvbGVNZXNzYWdlLmgKQEAgLTM1LDcgKzM1LDYgQEAKICNp bmNsdWRlICJTY3JpcHRPYmplY3QuaCIKICNpbmNsdWRlICJTY3JpcHRTdGF0ZS5oIgogCi0jaW5j bHVkZSA8cnVudGltZS9Qcm90ZWN0Lmg+CiAjaW5jbHVkZSA8d3RmL1ZlY3Rvci5oPgogCiBuYW1l c3BhY2UgV2ViQ29yZSB7CmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JS ZXNvdXJjZS5jcHAgYi9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JSZXNvdXJjZS5jcHAKaW5k ZXggOGJjYTJjNi4uMjQ0ZTBhNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVj dG9yUmVzb3VyY2UuY3BwCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclJlc291cmNl LmNwcApAQCAtMTA2LDcgKzEwNiw3IEBAIHZvaWQgSW5zcGVjdG9yUmVzb3VyY2U6OnVwZGF0ZVJl c3BvbnNlKGNvbnN0IFJlc291cmNlUmVzcG9uc2UmIHJlc3BvbnNlKQogCiBzdGF0aWMgU2NyaXB0 T2JqZWN0IGNyZWF0ZUhlYWRlcnNPYmplY3QoU2NyaXB0U3RhdGUqIHNjcmlwdFN0YXRlLCBjb25z dCBIVFRQSGVhZGVyTWFwJiBoZWFkZXJzLCBib29sIGhhZEV4Y2VwdGlvbikKIHsKLSAgICBTY3Jp cHRPYmplY3Qgb2JqZWN0KHNjcmlwdFN0YXRlKTsKKyAgICBTY3JpcHRPYmplY3Qgb2JqZWN0ID0g U2NyaXB0T2JqZWN0OjpjcmVhdGVOZXcoc2NyaXB0U3RhdGUpOwogICAgIEhUVFBIZWFkZXJNYXA6 OmNvbnN0X2l0ZXJhdG9yIGVuZCA9IGhlYWRlcnMuZW5kKCk7CiAgICAgZm9yIChIVFRQSGVhZGVy TWFwOjpjb25zdF9pdGVyYXRvciBpdCA9IGhlYWRlcnMuYmVnaW4oKTsgaXQgIT0gZW5kOyArK2l0 KSB7CiAgICAgICAgIGlmICghb2JqZWN0LnNldChzY3JpcHRTdGF0ZSwgaXQtPmZpcnN0LnN0cmlu ZygpLCBpdC0+c2Vjb25kKSkgewo=