251133 2023-01-24 21:15:57 -0800 [Wasm-GC] Fix null checks for struct operations 2023-01-26 12:13:17 -0800 1 1 1 Unclassified WebKit WebAssembly WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 247394 1 asumu webkit-unassigned webkit-bug-importer oldest_to_newest 1928049 0 asumu 2023-01-24 21:15:57 -0800 There's a bug in the implementation of Wasm GC struct instructions such as `struct.get` and `struct.set`, in that they don't correctly implement null ref checks. Here's an example test case (can run in the JSTests/wasm/gc test directory): ``` import * as assert from "../assert.js"; import { compile, instantiate } from "./wast-wrapper.js"; let m = instantiate(` (module (type (struct (field i32))) (func (export "f") (result i32) (struct.get 0 0 (ref.null 0))) ) `); m.exports.f(); ``` This currently crashes, instead of raising a trap exception as needed. 1928050 1 asumu 2023-01-24 21:34:47 -0800 Pull request: https://github.com/WebKit/WebKit/pull/9091 1928677 2 ews-feeder 2023-01-26 12:12:01 -0800 Committed 259449@main (a5a87681d68f): <https://commits.webkit.org/259449@main> Reviewed commits have been landed. Closing PR #9091 and removing active labels. 1928678 3 webkit-bug-importer 2023-01-26 12:13:17 -0800 <rdar://problem/104707623>