<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>251071</bug_id>
          
          <creation_ts>2023-01-23 23:57:56 -0800</creation_ts>
          <short_desc>Fix IsoCellSet::remove()&apos;s return value.</short_desc>
          <delta_ts>2023-01-24 09:33:00 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=250847</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Mark Lam">mark.lam</reporter>
          <assigned_to name="Mark Lam">mark.lam</assigned_to>
          <cc>webkit-bug-importer</cc>
    
    <cc>yijia_huang</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1927732</commentid>
    <comment_count>0</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2023-01-23 23:57:56 -0800</bug_when>
    <thetext>In https://bugs.webkit.org/show_bug.cgi?id=250847, Yijia Huang found a bug in Bitmap::concurrentTestAndClear() where it&apos;s returning the inverse of its expected result.  Checking for all uses of concurrentTestAndClear(), we find that one result of IsoCellSet::remove() is also similarly incorrect.

This patch fixes these errors, and also adds comments to document the intended return values of some relevant functions, as well as the reasoning behind how some of the return values are computed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1927733</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2023-01-23 23:58:22 -0800</bug_when>
    <thetext>&lt;rdar://problem/104590361&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1927735</commentid>
    <comment_count>2</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2023-01-24 00:07:18 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/9020</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1927839</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-01-24 09:32:55 -0800</bug_when>
    <thetext>Committed 259287@main (3589dd6fe569): &lt;https://commits.webkit.org/259287@main&gt;

Reviewed commits have been landed. Closing PR #9020 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>