25106 2009-04-08 18:18:19 -0700 Mismatched virtual function signatures in animations 2009-04-08 18:34:15 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED http://demo.webapp-net.com P2 Normal --- 1 simon.fraser simon.fraser cmarrin oldest_to_newest 116976 0 simon.fraser 2009-04-08 18:18:19 -0700 AnimationBase has virtual void endAnimation(bool, double) and the double is never used. Everything else has virtual void endAnimation(bool) I think this is causing a real bug on http://demo.webapp-net.com, where there's an opacity animation that's never cleaned up. 116977 1 29353 simon.fraser 2009-04-08 18:29:08 -0700 Created attachment 29353 Patch 116978 2 simon.fraser 2009-04-08 18:34:15 -0700 http://trac.webkit.org/changeset/42346 29353 2009-04-08 18:29:08 -0700 2009-04-08 18:30:35 -0700 Patch 25106_patch.txt text/plain 1259 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDdmMTRiNS4uMDAwYjc1NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0wNC0wOCAgU2ltb24gRnJhc2Vy ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjUxMDYKKyAgICAgICAgCisgICAgICAgIEZpeCBzaWduYXR1cmUgb2YgdmlydHVhbCBmdW5j dGlvbiBvbiBBbmltYXRpb25CYXNlIHNvIHRoYXQgaXQgbWF0Y2hlcworICAgICAgICB0aG9zZSBp biB0aGUgZGVyaXZlZCBjbGFzc2VzLCBieSByZW1vdmluZyB1bnVzZWQgcGFyYW1ldGVyLgorICAg ICAgICAKKyAgICAgICAgKiBwYWdlL2FuaW1hdGlvbi9BbmltYXRpb25CYXNlLmg6CisgICAgICAg IChXZWJDb3JlOjpBbmltYXRpb25CYXNlOjplbmRBbmltYXRpb24pOgorCiAyMDA5LTA0LTA4ICBE YW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2Ft IFdlaW5pZy4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGFnZS9hbmltYXRpb24vQW5pbWF0aW9uQmFz ZS5oIGIvV2ViQ29yZS9wYWdlL2FuaW1hdGlvbi9BbmltYXRpb25CYXNlLmgKaW5kZXggZGE0MzQx Yi4uODI2NjMwMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL2FuaW1hdGlvbi9BbmltYXRpb25C YXNlLmgKKysrIGIvV2ViQ29yZS9wYWdlL2FuaW1hdGlvbi9BbmltYXRpb25CYXNlLmgKQEAgLTE4 Niw3ICsxODYsNyBAQCBwcm90ZWN0ZWQ6CiAgICAgdmlydHVhbCB2b2lkIG9uQW5pbWF0aW9uSXRl cmF0aW9uKGRvdWJsZSAvKmVsYXBzZWRUaW1lKi8pIHsgfQogICAgIHZpcnR1YWwgdm9pZCBvbkFu aW1hdGlvbkVuZChkb3VibGUgLyplbGFwc2VkVGltZSovKSB7IH0KICAgICB2aXJ0dWFsIGJvb2wg c3RhcnRBbmltYXRpb24oZG91YmxlIC8qYmVnaW5UaW1lKi8pIHsgcmV0dXJuIGZhbHNlOyB9Ci0g ICAgdmlydHVhbCB2b2lkIGVuZEFuaW1hdGlvbihib29sIC8qcmVzZXQqLywgZG91YmxlIC8qZm9y Y2VQYXVzZVRpbWUqLyA9IC0xKSB7IH0KKyAgICB2aXJ0dWFsIHZvaWQgZW5kQW5pbWF0aW9uKGJv b2wgLypyZXNldCovKSB7IH0KIAogICAgIHZvaWQgZ29JbnRvRW5kaW5nT3JMb29waW5nU3RhdGUo KTsKIAo=