<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>251042</bug_id>
          
          <creation_ts>2023-01-23 14:27:13 -0800</creation_ts>
          <short_desc>Editing - Code refactoring to avoid several calls to hasEditableStyle() in loop</short_desc>
          <delta_ts>2023-01-24 01:45:30 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>HTML Editing</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ahmad Saleem">ahmad.saleem792</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>webkit-bug-importer</cc>
    
    <cc>wenson_hsieh</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1927591</commentid>
    <comment_count>0</comment_count>
    <who name="Ahmad Saleem">ahmad.saleem792</who>
    <bug_when>2023-01-23 14:27:13 -0800</bug_when>
    <thetext>Hi Team,

I came across this possible merge, which is to avoid looping and reduce calls to hasEditableStyle() in VisibleUnits.cpp:

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/editing/VisibleUnits.cpp#1121 &amp; https://searchfox.org/wubkat/source/Source/WebCore/editing/VisibleUnits.cpp#1178

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/85355b065acfc6ffbf960afa2d8e175104c556fa

It is just a refactoring to reduce calls, so I think it would be fine to land without any dedicated testcase.

Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1927753</commentid>
    <comment_count>1</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-01-24 01:44:40 -0800</bug_when>
    <thetext>Committed 259267@main (e2e91f349dc7): &lt;https://commits.webkit.org/259267@main&gt;

Reviewed commits have been landed. Closing PR #8993 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1927756</commentid>
    <comment_count>2</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2023-01-24 01:45:30 -0800</bug_when>
    <thetext>&lt;rdar://problem/104592394&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>