25093 2009-04-08 09:24:11 -0700 REGRESSION: some scripts are showing in the Inspector with only "true" as the source 2009-04-08 10:53:28 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 timothy webkit-unassigned aroben dglazkov kmccullough timothy oldest_to_newest 116886 0 timothy 2009-04-08 09:24:11 -0700 Recently some scripts have started to just show "true" as the source. It seems to be eval scripts and anything using the ScriptView class. 116893 1 timothy 2009-04-08 09:32:09 -0700 <rdar://problem/6769932> 116894 2 dglazkov 2009-04-08 09:32:26 -0700 I think I fixed it in the last commit. It was this: http://trac.webkit.org/changeset/42295/trunk/WebCore/bindings/js/JSInspectorControllerCustom.cpp But I'll check. 116902 3 29338 dglazkov 2009-04-08 10:39:45 -0700 Created attachment 29338 Fix conversion problem, v1. WebCore/ChangeLog | 12 ++++++++++++ WebCore/inspector/InspectorController.cpp | 4 ++-- 2 files changed, 14 insertions(+), 2 deletions(-) 116903 4 dglazkov 2009-04-08 10:40:33 -0700 This was all my fault. 116905 5 dglazkov 2009-04-08 10:53:28 -0700 Landed as http://trac.webkit.org/changeset/42325. 29338 2009-04-08 10:39:45 -0700 2009-04-08 10:44:30 -0700 Fix conversion problem, v1. Fix-conversion-problem-v1..patch text/plain 1988 dglazkov Njk4NDA4ODkwYjJhNmY5OWU4OTk3NjgxOWRkZjgwNmYxNGE2NTRjYwpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0ZTM1ODI1Li4yZGZmNjIz IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE1IEBACisyMDA5LTA0LTA4ICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1MDkzCisgICAg ICAgIFJFR1JFU1NJT046IHNvbWUgc2NyaXB0cyBhcmUgc2hvd2luZyBpbiB0aGUgSW5zcGVjdG9y IHdpdGggb25seSAidHJ1ZSIKKyAgICAgICAgYXMgdGhlIHNvdXJjZS4KKworICAgICAgICAqIGlu c3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3Bl Y3RvckNvbnRyb2xsZXI6OmRpZFBhcnNlU291cmNlKTogRml4ZWQgY29udmVyc2lvbiBpc3N1ZS4K KyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckNvbnRyb2xsZXI6OmZhaWxlZFRvUGFyc2VTb3Vy Y2UpOiBEaXR0by4KKwogMjAwOS0wNC0wOCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCmRpZmYgLS1naXQg YS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcCBiL1dlYkNvcmUvaW5z cGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuY3BwCmluZGV4IDRmNmI3MjEuLjE1NWYyZDggMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuY3BwCisrKyBi L1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuY3BwCkBAIC0xNDIyLDcgKzE0 MjIsNyBAQCB2b2lkIEluc3BlY3RvckNvbnRyb2xsZXI6OmRpZFBhcnNlU291cmNlKEV4ZWNTdGF0 ZSosIGNvbnN0IFNvdXJjZUNvZGUmIHNvdXJjZSkKICAgICBTY3JpcHRGdW5jdGlvbkNhbGwgZnVu Y3Rpb24obV9zY3JpcHRTdGF0ZSwgbV93ZWJJbnNwZWN0b3IsICJwYXJzZWRTY3JpcHRTb3VyY2Ui KTsKICAgICBmdW5jdGlvbi5hcHBlbmRBcmd1bWVudChzdGF0aWNfY2FzdDxsb25nIGxvbmc+KHNv dXJjZS5wcm92aWRlcigpLT5hc0lEKCkpKTsKICAgICBmdW5jdGlvbi5hcHBlbmRBcmd1bWVudChz b3VyY2UucHJvdmlkZXIoKS0+dXJsKCkpOwotICAgIGZ1bmN0aW9uLmFwcGVuZEFyZ3VtZW50KHNv dXJjZS5kYXRhKCkpOworICAgIGZ1bmN0aW9uLmFwcGVuZEFyZ3VtZW50KEpTQzo6VVN0cmluZyhz b3VyY2UuZGF0YSgpLCBzb3VyY2UubGVuZ3RoKCkpKTsKICAgICBmdW5jdGlvbi5hcHBlbmRBcmd1 bWVudChzb3VyY2UuZmlyc3RMaW5lKCkpOwogICAgIGZ1bmN0aW9uLmNhbGwoKTsKIH0KQEAgLTE0 MzEsNyArMTQzMSw3IEBAIHZvaWQgSW5zcGVjdG9yQ29udHJvbGxlcjo6ZmFpbGVkVG9QYXJzZVNv dXJjZShFeGVjU3RhdGUqLCBjb25zdCBTb3VyY2VDb2RlJiBzb3VyCiB7CiAgICAgU2NyaXB0RnVu Y3Rpb25DYWxsIGZ1bmN0aW9uKG1fc2NyaXB0U3RhdGUsIG1fd2ViSW5zcGVjdG9yLCAiZmFpbGVk VG9QYXJzZVNjcmlwdFNvdXJjZSIpOwogICAgIGZ1bmN0aW9uLmFwcGVuZEFyZ3VtZW50KHNvdXJj ZS5wcm92aWRlcigpLT51cmwoKSk7Ci0gICAgZnVuY3Rpb24uYXBwZW5kQXJndW1lbnQoc291cmNl LmRhdGEoKSk7CisgICAgZnVuY3Rpb24uYXBwZW5kQXJndW1lbnQoSlNDOjpVU3RyaW5nKHNvdXJj ZS5kYXRhKCksIHNvdXJjZS5sZW5ndGgoKSkpOwogICAgIGZ1bmN0aW9uLmFwcGVuZEFyZ3VtZW50 KHNvdXJjZS5maXJzdExpbmUoKSk7CiAgICAgZnVuY3Rpb24uYXBwZW5kQXJndW1lbnQoZXJyb3JM aW5lKTsKICAgICBmdW5jdGlvbi5hcHBlbmRBcmd1bWVudChlcnJvck1lc3NhZ2UpOwo=