250899 2023-01-20 07:26:53 -0800 Cocoa readPixels is slower in GPUP WebGL than in-process WebGL 2023-05-22 05:22:44 -0700 1 1 1 Unclassified WebKit WebGL Safari 15 Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=252876 InRadar P2 Normal --- 251431 1 kkinnunen kkinnunen dino kbr kkinnunen mcatanzaro webkit-bug-importer zdobersek oldest_to_newest 1926891 0 kkinnunen 2023-01-20 07:26:53 -0800 GPUP WebGL readPixels is slower than in process Should and could be improved 1926892 1 webkit-bug-importer 2023-01-20 07:27:02 -0800 <rdar://problem/104475196> 1927762 2 kkinnunen 2023-01-24 02:28:40 -0800 Pull request: https://github.com/WebKit/WebKit/pull/9029 1929352 3 ews-feeder 2023-01-30 03:27:20 -0800 Committed 259550@main (4fbc3e1ca2be): <https://commits.webkit.org/259550@main> Reviewed commits have been landed. Closing PR #9029 and removing active labels. 1929391 4 mcatanzaro 2023-01-30 07:38:28 -0800 Hi, this won't work because the object is noncopyable on Unix: /home/mcatanzaro/Projects/WebKit/Source/WebKit/Platform/SharedMemory.h:70:9: error: explicitly defaulted copy constructor is implicitly deleted [-Werror,-Wdefaulted-function-deleted] Handle(const Handle&) = default; ^ /home/mcatanzaro/Projects/WebKit/Source/WebKit/Platform/SharedMemory.h:98:36: note: copy constructor of 'Handle' is implicitly deleted because field 'm_handle' has a deleted copy constructor mutable UnixFileDescriptor m_handle; ^ /home/mcatanzaro/Projects/WebKit/WebKitBuild/gtk4/WTF/Headers/wtf/unix/UnixFileDescriptor.h:37:26: note: 'UnixFileDescriptor' has been explicitly marked deleted here WTF_MAKE_NONCOPYABLE(UnixFileDescriptor); 1929392 5 mcatanzaro 2023-01-30 07:39:39 -0800 I'll try this: diff --git a/Source/WebKit/Platform/SharedMemory.h b/Source/WebKit/Platform/SharedMemory.h index 45a30661faa3..ff78942ba3d8 100644 --- a/Source/WebKit/Platform/SharedMemory.h +++ b/Source/WebKit/Platform/SharedMemory.h @@ -67,11 +67,14 @@ public: class Handle { public: Handle() = default; - Handle(const Handle&) = default; Handle(Handle&&) = default; - Handle& operator=(const Handle&) = default; Handle& operator=(Handle&&) = default; +#if PLATFORM(COCOA) + Handle(const Handle&) = default; + Handle& operator=(const Handle&) = default; +#endif + bool isNull() const; size_t size() const { return m_size; } and see if that works. 1929393 6 mcatanzaro 2023-01-30 07:44:09 -0800 So that does seem to work. It doesn't feel great, though. 1929402 7 mcatanzaro 2023-01-30 07:57:44 -0800 Zan has a better solution in https://github.com/WebKit/WebKit/pull/9310 1929410 8 mcatanzaro 2023-01-30 08:09:44 -0800 (In reply to Michael Catanzaro from comment #7) > Zan has a better solution in https://github.com/WebKit/WebKit/pull/9310 Well, I wound up leaving some negative feedback there. Kimmo, any opinion on what to do here?