250879 2023-01-19 17:28:43 -0800 Delete unused Windows UA string logic 2024-09-24 14:51:40 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID https://bugs.webkit.org/show_bug.cgi?id=280295 InRadar P2 Normal --- 1 ahmad.saleem792 webkit-unassigned ap bfulgham fujii stephan.szabo webkit-bug-importer oldest_to_newest 1926777 0 ahmad.saleem792 2023-01-19 17:28:43 -0800 Hi Team, While going through Blink's commit, I came cross another clean-up commit, which can be merged into WebKit. Blink Commit - https://chromium.googlesource.com/chromium/blink/+/6d5bdc2b3dc4b675747a86b190fa555c5a018014 WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/platform/win/SystemInfo.cpp#80 etc. Just wanted to raise, so we can track and clean-up some old code and enjoy cleaner WebKit. Thanks! 1926793 1 ap 2023-01-19 18:39:30 -0800 We do use this function, so probably no easy cleanup: Source/WebKitLegacy/win/WebView.cpp: static const NeverDestroyed<String> prefix = makeString("Mozilla/5.0 (", windowsVersionForUAString(), ") AppleWebKit/", webKitVersionString(), " (KHTML, like Gecko)"); Source/WebCore/platform/win/UserAgentWin.cpp: return makeString("Mozilla/5.0 (", windowsVersionForUAString(), ") AppleWebKit/605.1.15 (KHTML, like Gecko)", 1928761 2 webkit-bug-importer 2023-01-26 17:29:15 -0800 <rdar://problem/104721654> 2062846 3 fujii 2024-09-24 14:36:24 -0700 Yes, it's used. Closed.