25083 2009-04-07 15:08:58 -0700 Chromium Linux: use fLeading rather than fHeight 2009-04-07 15:31:14 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 agl webkit-unassigned oldest_to_newest 116806 0 agl 2009-04-07 15:08:58 -0700 Skia was previously calculating the leading value incorrectly, leading us to add fHeight to get the height of a line of text. Now that Skia is calculating fLeading correctly, we can remove fHeight. (should be the last one) 116807 1 29318 agl 2009-04-07 15:09:51 -0700 Created attachment 29318 patch 116811 2 fishd 2009-04-07 15:31:14 -0700 Landed as: http://trac.webkit.org/changeset/42294 29318 2009-04-07 15:09:51 -0700 2009-04-07 15:27:45 -0700 patch patch text/plain 1552 agl ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MDY2OThjNy4uZDhmMzkxZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMCBAQAogMjAwOS0wNC0wNyAgQWRhbSBMYW5nbGV5 ICA8YWdsQGdvb2dsZS5jb20+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1MDgz CisKKyAgICAgICAgU2tpYSB3YXMgcHJldmlvdXNseSBjYWxjdWxhdGluZyB0aGUgbGVhZGluZyB2 YWx1ZSBpbmNvcnJlY3RseSwgbGVhZGluZworICAgICAgICB1cyB0byBhZGQgZkhlaWdodCB0byBn ZXQgdGhlIGhlaWdodCBvZiBhIGxpbmUgb2YgdGV4dC4gTm93IHRoYXQgU2tpYQorICAgICAgICBp cyBjYWxjdWxhdGluZyBmTGVhZGluZyBjb3JyZWN0bHksIHdlIGNhbiByZW1vdmUgZkhlaWdodC4K KworICAgICAgICBUaGlzIGRvZXNuJ3QgYWZmZWN0IGFueSBsYXlvdXQgdGVzdHMuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9TaW1wbGVGb250RGF0YUxpbnV4LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlNpbXBsZUZvbnREYXRhOjpwbGF0Zm9ybUluaXQpOgorCisyMDA5 LTA0LTA3ICBBZGFtIExhbmdsZXkgIDxhZ2xAZ29vZ2xlLmNvbT4KKwogICAgICAgICBSZXZpZXdl ZCBieSBEYXJpbiBGaXNoZXIuCiAKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTI1MDgxCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2Nocm9taXVtL1NpbXBsZUZvbnREYXRhTGludXguY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jaHJvbWl1bS9TaW1wbGVGb250RGF0YUxpbnV4LmNwcAppbmRleCAwNDJiYWY4Li5mNTA2 M2I2IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1NpbXBs ZUZvbnREYXRhTGludXguY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21p dW0vU2ltcGxlRm9udERhdGFMaW51eC5jcHAKQEAgLTYxLDggKzYxLDkgQEAgdm9pZCBTaW1wbGVG b250RGF0YTo6cGxhdGZvcm1Jbml0KCkKICAgICAgICAgbV9hc2NlbnQgPSBtZXRyaWNzLmZWRE1Y QXNjZW50OwogICAgICAgICBtX2Rlc2NlbnQgPSBtZXRyaWNzLmZWRE1YRGVzY2VudDsKICAgICB9 IGVsc2UgeworICAgICAgICBTa1NjYWxhciBoZWlnaHQgPSBtZXRyaWNzLmZBc2NlbnQgKyBtZXRy aWNzLmZEZXNjZW50ICsgbWV0cmljcy5mTGVhZGluZzsKICAgICAgICAgbV9hc2NlbnQgPSBTa1Nj YWxhclJvdW5kKC1tZXRyaWNzLmZBc2NlbnQpOwotICAgICAgICBtX2Rlc2NlbnQgPSBTa1NjYWxh clJvdW5kKG1ldHJpY3MuZkhlaWdodCkgLSBtX2FzY2VudDsKKyAgICAgICAgbV9kZXNjZW50ID0g U2tTY2FsYXJSb3VuZChoZWlnaHQpIC0gbV9hc2NlbnQ7CiAgICAgfQogCiAgICAgaWYgKG1ldHJp Y3MuZlhIZWlnaHQpCg==