25081 2009-04-07 14:07:45 -0700 Update Chromium Linux's font metrics to match Skia 2009-04-07 15:04:45 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 agl webkit-unassigned oldest_to_newest 116788 0 agl 2009-04-07 14:07:45 -0700 Skia is changing from reporting the XRange to reporting the XMin and XMax. Obviously these are equivalent, but other users of the metrics need the two numbers to be separate. 116789 1 29316 agl 2009-04-07 14:08:12 -0700 Created attachment 29316 patch 116796 2 29316 fishd 2009-04-07 14:24:02 -0700 Comment on attachment 29316 patch When do you want this to be committed? 116797 3 agl 2009-04-07 14:25:35 -0700 Please commit whenever. When I see the bug closed I'll commit to the Chromium fork and commit the Chromium side at the same time. Thanks 116805 4 fishd 2009-04-07 15:04:45 -0700 In the future, please include a bug link in your ChangeLog entry. Thanks! Landed as: http://trac.webkit.org/changeset/42290 29316 2009-04-07 14:08:12 -0700 2009-04-07 14:24:02 -0700 patch patch text/plain 1492 agl ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZTJmMmM2ZC4uODYzMTI0ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0wNC0wNyAgQWRhbSBMYW5nbGV5 ICA8YWdsQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgU2tpYSBpcyBjaGFuZ2luZyBmcm9tIHJlcG9ydGluZyB0aGUgWFJhbmdlIHRv IHJlcG9ydGluZyB0aGUgWE1pbiBhbmQKKyAgICAgICAgWE1heC4gIE9idmlvdXNseSB0aGVzZSBh cmUgZXF1aXZhbGVudCwgYnV0IG90aGVyIHVzZXJzIG9mIHRoZSBtZXRyaWNzCisgICAgICAgIG5l ZWQgdGhlIHR3byBudW1iZXJzIHRvIGJlIHNlcGFyYXRlLgorCisgICAgICAgIFRoaXMgZG9lc24n dCBhZmZlY3QgYW55IGxheW91dCB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz L2Nocm9taXVtL1NpbXBsZUZvbnREYXRhTGludXguY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2lt cGxlRm9udERhdGE6OnBsYXRmb3JtSW5pdCk6CisKIDIwMDktMDQtMDcgIERhbiBCZXJuc3RlaW4g IDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlm ZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vU2ltcGxlRm9udERh dGFMaW51eC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1NpbXBsZUZv bnREYXRhTGludXguY3BwCmluZGV4IDgyMDAxNzUuLjA0MmJhZjggMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vU2ltcGxlRm9udERhdGFMaW51eC5jcHAKKysr IGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9TaW1wbGVGb250RGF0YUxpbnV4 LmNwcApAQCAtNzksNyArNzksOCBAQCB2b2lkIFNpbXBsZUZvbnREYXRhOjpwbGF0Zm9ybUluaXQo KQogICAgIC8vIGNhbGN1bGF0ZWQgZm9yIHVzLCBidXQgd2UgbmVlZCB0byBjYWxjdWxhdGUgbV9t YXhDaGFyV2lkdGggYW5kCiAgICAgLy8gbV9hdmdDaGFyV2lkdGggaW4gb3JkZXIgZm9yIHRleHQg ZW50cnkgd2lkZ2V0cyB0byBiZSBzaXplZCBjb3JyZWN0bHkuCiAKLSAgICBtX21heENoYXJXaWR0 aCA9IFNrU2NhbGFyUm91bmQobWV0cmljcy5mWFJhbmdlICogU2tTY2FsYXJSb3VuZChtX2ZvbnQu c2l6ZSgpKSk7CisgICAgU2tTY2FsYXIgeFJhbmdlID0gbWV0cmljcy5mWE1heCAtIG1ldHJpY3Mu ZlhNaW47CisgICAgbV9tYXhDaGFyV2lkdGggPSBTa1NjYWxhclJvdW5kKHhSYW5nZSAqIFNrU2Nh bGFyUm91bmQobV9mb250LnNpemUoKSkpOwogCiAgICAgaWYgKG1ldHJpY3MuZkF2Z0NoYXJXaWR0 aCkKICAgICAgICAgbV9hdmdDaGFyV2lkdGggPSBTa1NjYWxhclJvdW5kKG1ldHJpY3MuZkF2Z0No YXJXaWR0aCk7Cg==