<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>250806</bug_id>
          
          <creation_ts>2023-01-18 16:25:43 -0800</creation_ts>
          <short_desc>Require Int32 when constant-folding ParseInt in DFG</short_desc>
          <delta_ts>2023-01-19 11:47:57 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="David Degazio">d_degazio</reporter>
          <assigned_to name="David Degazio">d_degazio</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1926460</commentid>
    <comment_count>0</comment_count>
    <who name="David Degazio">d_degazio</who>
    <bug_when>2023-01-18 16:25:43 -0800</bug_when>
    <thetext>rdar://104071090

In DFG&apos;s constant folding phase, we fold ParseInt nodes when the radix is a Number equal to zero. In the DFG fixup phase, however, we more optimistically assume the radix is an Int32 and add a speculation check. We should make sure that the constant folding phase&apos;s behavior reflects the type constraints we introduce in the fixup phase.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1926464</commentid>
    <comment_count>1</comment_count>
    <who name="David Degazio">d_degazio</who>
    <bug_when>2023-01-18 16:31:21 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/8804</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1926683</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-01-19 11:47:54 -0800</bug_when>
    <thetext>Committed 259102@main (47b456d4d7f3): &lt;https://commits.webkit.org/259102@main&gt;

Reviewed commits have been landed. Closing PR #8804 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>