250803 2023-01-18 16:00:47 -0800 Improve intersection precision in FloatPoint 2023-01-30 11:15:49 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ahmad.saleem792 webkit-unassigned mattwoodrow mmaxfield simon.fraser webkit-bug-importer zalan oldest_to_newest 1926449 0 ahmad.saleem792 2023-01-18 16:00:47 -0800 Hi Team, While going through Blink's commit, I came cross this interesting commit: Blink Commit - https://chromium.googlesource.com/chromium/blink/+/4fee9ba6e16e703f282b5460d999ba207842b4ef WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/platform/graphics/GeometryUtilities.cpp#56 Should we merge this and whether it will gain any benefit, appreciate if someone can share input? Thanks! 1927190 1 ahmad.saleem792 2023-01-21 18:56:15 -0800 It is inspired from this - https://github.com/servo/skia-snapshots/blob/master/skia/experimental/Intersection/LineIntersection.cpp#L43 as per commentary on Review and also from https://en.wikipedia.org/wiki/Line–line_intersection. There were three tests requiring baseline after this: One of them - related to border: https://jsfiddle.net/nmL1g95c/show In Safari, we have hairline gaps in Safari 16.2 & STP161 while we don't have those in Chrome Canary 111. 1928317 2 webkit-bug-importer 2023-01-25 16:01:48 -0800 <rdar://problem/104671777> 1929010 3 mmaxfield 2023-01-27 11:36:38 -0800 This seems like a good change. If we merge it, does it cause any tests to pass? It looks like it caused some Chrome tests to pass for them. 1929065 4 ahmad.saleem792 2023-01-27 14:49:42 -0800 (In reply to Myles C. Maxfield from comment #3) > This seems like a good change. > > If we merge it, does it cause any tests to pass? It looks like it caused > some Chrome tests to pass for them. I haven't run it through EWS or any specific test suite but I have it as local testing on my local build since past two days and I tried to look into border radius, border shadow test cases with hairline gaps but it seems that it does not improve anything across them but it is just cleaner code as of right now. Let me do PR in Draft and see if anything pop-up. Thanks! 1929475 5 ews-feeder 2023-01-30 11:15:44 -0800 Committed 259574@main (4ecebb76cee1): <https://commits.webkit.org/259574@main> Reviewed commits have been landed. Closing PR #9257 and removing active labels.