250802 2023-01-18 15:54:54 -0800 Remove duplicate isLeapYear 2023-01-19 05:37:16 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ahmad.saleem792 ahmad.saleem792 ap bfulgham rniwa webkit-bug-importer oldest_to_newest 1926448 0 ahmad.saleem792 2023-01-18 15:54:54 -0800 Hi Team, I came across another refactoring patch to remove duplicate function: Blink Commit - https://chromium.googlesource.com/chromium/blink/+/ecbe8115cc1f014eb61dff29b96e405a0ab3ef51 WebKit Source - https://searchfox.org/wubkat/source/Source/WTF/wtf/DateMath.h#188 & https://searchfox.org/wubkat/source/Source/WebCore/platform/DateComponents.cpp#56 We have two functions exactly same, one is inline while another is static. Can we get rid of one? Thanks! 1926455 1 bfulgham 2023-01-18 16:23:47 -0800 Yes! Use the one in WTF/DateMath.h and delete the other one. 1926472 2 ap 2023-01-18 16:35:47 -0800 It would be nice to move other generic functions as well, and unify duplicates (like daysInMonths in ISO8601.cpp). But that would be a much larger effort. static int maxDayOfMonth(int year, int month) static int dayOfWeek(int year, int month, int day) 1926473 3 ahmad.saleem792 2023-01-18 16:36:59 -0800 (In reply to Alexey Proskuryakov from comment #2) > It would be nice to move other generic functions as well, and unify > duplicates (like daysInMonths in ISO8601.cpp). But that would be a much > larger effort. > > static int maxDayOfMonth(int year, int month) > static int dayOfWeek(int year, int month, int day) Should I create a bug for future? 1926474 4 ahmad.saleem792 2023-01-18 16:37:12 -0800 (In reply to Brent Fulgham from comment #1) > Yes! Use the one in WTF/DateMath.h and delete the other one. Happy to do PR. :-) 1926479 5 ap 2023-01-18 16:47:27 -0800 > Should I create a bug for future? I personally wouldn't bother (refactoring ideas don't usually get acted on), but it wouldn't be unreasonable to do if you feel like it. 1926483 6 ahmad.saleem792 2023-01-18 16:54:12 -0800 (In reply to Alexey Proskuryakov from comment #5) > > Should I create a bug for future? > > I personally wouldn't bother (refactoring ideas don't usually get acted on), > but it wouldn't be unreasonable to do if you feel like it. Not in near future (few weeks), still learning few bits around WebKit but in few months, I can explore it as a challenge. I will add it in my To-do Notes. :-) 1926488 7 ahmad.saleem792 2023-01-18 17:07:57 -0800 PR - https://github.com/WebKit/WebKit/pull/8806 1926580 8 ews-feeder 2023-01-19 05:36:50 -0800 Committed 259080@main (0b9c23b10f38): <https://commits.webkit.org/259080@main> Reviewed commits have been landed. Closing PR #8806 and removing active labels. 1926581 9 webkit-bug-importer 2023-01-19 05:37:16 -0800 <rdar://problem/104425042>