250800 2023-01-18 15:39:59 -0800 Fix moveTo to not use screenAvailableRect as an origin but as a boundary 2024-10-15 10:35:30 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=21413 InRadar P2 Normal --- 1 ahmad.saleem792 ahmad.saleem792 bfulgham rniwa webkit-bug-importer oldest_to_newest 1926440 0 ahmad.saleem792 2023-01-18 15:39:59 -0800 Hi Team, While going through Blink's commit, I came across another failing tests (where all browsers are failing few tests but Safari is failing more than others): Test Case - https://jsfiddle.net/84rogcy7/show ^ Safari 16.2 & STP 161 are failing: Testing - xxx with 0 arguments & Testing - xxx with with 1 argument where it suppose to throw exception, it is throwing undefined. While Chrome Canary 111 and Firefox Nightly 111 passes these. All browsers are failing two arguments tests. Blink Commit - https://chromium.googlesource.com/chromium/blink/+/f7557ab98c0e2bb380f9bfc6355666434c6e481f WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/page/DOMWindow.cpp#1813 Just wanted to raise to get input and whether it is good to fix at least 0 and 1 argument cases to match other browsers. Thanks! 1928308 1 webkit-bug-importer 2023-01-25 15:40:18 -0800 <rdar://problem/104670843> 1995420 2 ahmad.saleem792 2023-11-28 15:04:02 -0800 This compiles: void LocalDOMWindow::moveTo(int x, int y) const { if (!allowedToChangeWindowGeometry()) return; CheckedPtr page = frame()->page(); auto update = page->chrome().windowRect(); RefPtr localMainFrame = dynamicDowncast<LocalFrame>(page->mainFrame()); if (!localMainFrame) return; update.setLocation(LayoutPoint(x, y)); page->chrome().setWindowRect(adjustWindowRect(*page, update)); } 2004552 3 ahmad.saleem792 2024-01-11 15:06:43 -0800 (In reply to Ahmad Saleem from comment #2) > This compiles: > > void LocalDOMWindow::moveTo(int x, int y) const > { > if (!allowedToChangeWindowGeometry()) > return; > CheckedPtr page = frame()->page(); > auto update = page->chrome().windowRect(); > RefPtr localMainFrame = dynamicDowncast<LocalFrame>(page->mainFrame()); > if (!localMainFrame) > return; > update.setLocation(LayoutPoint(x, y)); > page->chrome().setWindowRect(adjustWindowRect(*page, update)); > } This is updated: void LocalDOMWindow::moveTo(int x, int y) const { if (!allowedToChangeWindowGeometry()) return; RefPtr page = frame()->page(); auto update = page->chrome().windowRect(); RefPtr localMainFrame = dynamicDowncast<LocalFrame>(page->mainFrame()); if (!localMainFrame) return; update.setLocation(LayoutPoint(x, y)); page->chrome().setWindowRect(adjustWindowRect(*page, update)); } 2068008 4 ahmad.saleem792 2024-10-15 02:46:17 -0700 Pull request: https://github.com/WebKit/WebKit/pull/35210 2068096 5 ews-feeder 2024-10-15 10:35:28 -0700 Committed 285205@main (ee0481b506b2): <https://commits.webkit.org/285205@main> Reviewed commits have been landed. Closing PR #35210 and removing active labels.