250799 2023-01-18 15:27:52 -0800 [ews-build.webkit.org] Use super for parent class invocations 2025-08-28 13:42:16 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=298058 InRadar P2 Normal --- 1 jbedard jbedard webkit-bug-importer oldest_to_newest 1926434 0 jbedard 2023-01-18 15:27:52 -0800 Throughout ews-build.webkit.org, we should use 'super' instead of explicitly invoking a class function. The reason for this is that 'super' calls will break unit tests very hard if our parent class doesn't have the function we're invoking, while directly invoking a member function of a class we aren't inherited from isn't nessesarily fatal. We're likely to make mistakes here as we switch certain steps to new-style. 1926435 1 webkit-bug-importer 2023-01-18 15:28:06 -0800 <rdar://problem/104400449> 1926436 2 jbedard 2023-01-18 15:31:11 -0800 Pull request: https://github.com/WebKit/WebKit/pull/8798 1927552 3 ews-feeder 2023-01-23 13:07:04 -0800 Committed 259233@main (419bb9a7d871): <https://commits.webkit.org/259233@main> Reviewed commits have been landed. Closing PR #8798 and removing active labels.