250699 2023-01-16 21:11:46 -0800 Remove redundant FrameSelection::debugRenderer 2023-01-17 08:13:18 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham changseok esprehn+autocc ews-watchlist glenn koivisto kondapallykalyan mifenton mmaxfield pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1925926 0 zalan 2023-01-16 21:11:46 -0800 ssia 1925927 1 464522 zalan 2023-01-16 21:14:26 -0800 Created attachment 464522 Patch 1925983 2 464522 koivisto 2023-01-17 07:04:25 -0800 Comment on attachment 464522 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=464522&action=review > COMMIT_MESSAGE:6 > +This code is not used since r6289 (Mar 31, 2004). I was just about to use it! 1925985 3 zalan 2023-01-17 07:28:39 -0800 (In reply to Antti Koivisto from comment #2) > Comment on attachment 464522 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=464522&action=review > > > COMMIT_MESSAGE:6 > > +This code is not used since r6289 (Mar 31, 2004). > > I was just about to use it! I am just going to pretend I've never read this line and casually proceed with cq+. 1925992 4 ews-feeder 2023-01-17 08:12:36 -0800 Committed 258982@main (1680b1fa9de4): <https://commits.webkit.org/258982@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 464522. 1925993 5 webkit-bug-importer 2023-01-17 08:13:18 -0800 <rdar://problem/104334119> 464522 2023-01-16 21:14:26 -0800 2023-01-17 08:12:37 -0800 Patch bug-250699-20230116211425.patch text/plain 5352 zalan RnJvbSBmZmFkZGIyM2MzNTdjYWM2YjFjM2E1YmZiMjc4N2ViY2FmNzI3ZmFlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJhcmFkbGF5IDx6YWxhbkBhcHBsZS5jb20+CkRhdGU6 IE1vbiwgMTYgSmFuIDIwMjMgMjE6MTI6MTcgLTA4MDAKU3ViamVjdDogW1BBVENIXSBSZW1vdmUg cmVkdW5kYW50IEZyYW1lU2VsZWN0aW9uOjpkZWJ1Z1JlbmRlcmVyCiBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjUwNjk5CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KClRoaXMgY29kZSBpcyBub3QgdXNlZCBzaW5jZSByNjI4OSAoTWFyIDMxLCAyMDA0KS4KCiog U291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5jcHA6CihXZWJDb3JlOjpGcmFt ZVNlbGVjdGlvbjo6ZGVidWdSZW5kZXJlciBjb25zdCk6IERlbGV0ZWQuCiogU291cmNlL1dlYkNv cmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5oOgoqIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJUZXh0Lmg6CihXZWJDb3JlOjpSZW5kZXJUZXh0OjpmaW5kTmV4dElubGluZVRleHRCb3gg Y29uc3QpOiBEZWxldGVkLgotLS0KIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVTZWxlY3Rp b24uY3BwIHwgNjUgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIFNvdXJjZS9XZWJDb3JlL2VkaXRp bmcvRnJhbWVTZWxlY3Rpb24uaCAgIHwgIDIgLQogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlclRleHQuaCAgICAgfCAgMiAtCiAzIGZpbGVzIGNoYW5nZWQsIDY5IGRlbGV0aW9ucygtKQoK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVTZWxlY3Rpb24uY3BwIGIv U291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5jcHAKaW5kZXggN2RlYzI1ZGVm ZDgyLi41YTE5MmYzZDZlN2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJh bWVTZWxlY3Rpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVTZWxlY3Rp b24uY3BwCkBAIC0xOTQzLDcxICsxOTQzLDYgQEAgRG9jdW1lbnQqIEZyYW1lU2VsZWN0aW9uOjpk b2N1bWVudCgpCiAgICAgcmV0dXJuIG1fZG9jdW1lbnQuZ2V0KCk7CiB9CiAKLXZvaWQgRnJhbWVT ZWxlY3Rpb246OmRlYnVnUmVuZGVyZXIoUmVuZGVyT2JqZWN0KiByZW5kZXJlciwgYm9vbCBzZWxl Y3RlZCkgY29uc3QKLXsKLSAgICBpZiAoaXM8RWxlbWVudD4oKnJlbmRlcmVyLT5ub2RlKCkpKSB7 Ci0gICAgICAgIEVsZW1lbnQmIGVsZW1lbnQgPSBkb3duY2FzdDxFbGVtZW50PigqcmVuZGVyZXIt Pm5vZGUoKSk7Ci0gICAgICAgIGZwcmludGYoc3RkZXJyLCAiJXMlc1xuIiwgc2VsZWN0ZWQgPyAi PT0+ICIgOiAiICAgICIsIGVsZW1lbnQubG9jYWxOYW1lKCkuc3RyaW5nKCkudXRmOCgpLmRhdGEo KSk7Ci0gICAgfSBlbHNlIGlmIChpczxSZW5kZXJUZXh0PigqcmVuZGVyZXIpKSB7Ci0gICAgICAg IFJlbmRlclRleHQmIHRleHRSZW5kZXJlciA9IGRvd25jYXN0PFJlbmRlclRleHQ+KCpyZW5kZXJl cik7Ci0gICAgICAgIGlmICh0ZXh0UmVuZGVyZXIudGV4dCgpLmlzRW1wdHkoKSB8fCAhdGV4dFJl bmRlcmVyLmZpcnN0VGV4dEJveCgpKSB7Ci0gICAgICAgICAgICBmcHJpbnRmKHN0ZGVyciwgIiVz I3RleHQgKGVtcHR5KVxuIiwgc2VsZWN0ZWQgPyAiPT0+ICIgOiAiICAgICIpOwotICAgICAgICAg ICAgcmV0dXJuOwotICAgICAgICB9Ci0gICAgICAgIAotICAgICAgICBzdGF0aWMgY29uc3QgaW50 IG1heCA9IDM2OwotICAgICAgICBTdHJpbmcgdGV4dCA9IHRleHRSZW5kZXJlci50ZXh0KCk7Ci0g ICAgICAgIGludCB0ZXh0TGVuZ3RoID0gdGV4dC5sZW5ndGgoKTsKLSAgICAgICAgaWYgKHNlbGVj dGVkKSB7Ci0gICAgICAgICAgICBpbnQgb2Zmc2V0ID0gMDsKLSAgICAgICAgICAgIGlmIChyZW5k ZXJlci0+bm9kZSgpID09IG1fc2VsZWN0aW9uLnN0YXJ0KCkuY29udGFpbmVyTm9kZSgpKQotICAg ICAgICAgICAgICAgIG9mZnNldCA9IG1fc2VsZWN0aW9uLnN0YXJ0KCkuY29tcHV0ZU9mZnNldElu Q29udGFpbmVyTm9kZSgpOwotICAgICAgICAgICAgZWxzZSBpZiAocmVuZGVyZXItPm5vZGUoKSA9 PSBtX3NlbGVjdGlvbi5lbmQoKS5jb250YWluZXJOb2RlKCkpCi0gICAgICAgICAgICAgICAgb2Zm c2V0ID0gbV9zZWxlY3Rpb24uZW5kKCkuY29tcHV0ZU9mZnNldEluQ29udGFpbmVyTm9kZSgpOwot Ci0gICAgICAgICAgICBpbnQgcG9zOwotICAgICAgICAgICAgTGVnYWN5SW5saW5lVGV4dEJveCog Ym94ID0gdGV4dFJlbmRlcmVyLmZpbmROZXh0SW5saW5lVGV4dEJveChvZmZzZXQsIHBvcyk7Ci0g ICAgICAgICAgICB0ZXh0ID0gdGV4dC5zdWJzdHJpbmcoYm94LT5zdGFydCgpLCBib3gtPmxlbigp KTsKLSAgICAgICAgICAgIAotICAgICAgICAgICAgU3RyaW5nIHNob3c7Ci0gICAgICAgICAgICBp bnQgbWlkID0gbWF4IC8gMjsKLSAgICAgICAgICAgIGludCBjYXJldCA9IDA7Ci0gICAgICAgICAg ICAKLSAgICAgICAgICAgIC8vIHRleHQgaXMgc2hvcnRlciB0aGFuIG1heAotICAgICAgICAgICAg aWYgKHRleHRMZW5ndGggPCBtYXgpIHsKLSAgICAgICAgICAgICAgICBzaG93ID0gdGV4dDsKLSAg ICAgICAgICAgICAgICBjYXJldCA9IHBvczsKLSAgICAgICAgICAgIH0gZWxzZSBpZiAocG9zIC0g bWlkIDwgMCkgewotICAgICAgICAgICAgICAgIC8vIHRvbyBmZXcgY2hhcmFjdGVycyB0byBsZWZ0 Ci0gICAgICAgICAgICAgICAgc2hvdyA9IG1ha2VTdHJpbmcoU3RyaW5nVmlldyh0ZXh0KS5sZWZ0 KG1heCAtIDMpLCAiLi4uIik7Ci0gICAgICAgICAgICAgICAgY2FyZXQgPSBwb3M7Ci0gICAgICAg ICAgICB9IGVsc2UgaWYgKHBvcyAtIG1pZCA+PSAwICYmIHBvcyArIG1pZCA8PSB0ZXh0TGVuZ3Ro KSB7Ci0gICAgICAgICAgICAgICAgLy8gZW5vdWdoIGNoYXJhY3RlcnMgb24gZWFjaCBzaWRlCi0g ICAgICAgICAgICAgICAgc2hvdyA9IG1ha2VTdHJpbmcoIi4uLiIsIFN0cmluZ1ZpZXcodGV4dCku c3Vic3RyaW5nKHBvcyAtIG1pZCArIDMsIG1heCAtIDYpLCAiLi4uIik7Ci0gICAgICAgICAgICAg ICAgY2FyZXQgPSBtaWQ7Ci0gICAgICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgICAgIC8v IHRvbyBmZXcgY2hhcmFjdGVycyBvbiByaWdodAotICAgICAgICAgICAgICAgIHNob3cgPSBtYWtl U3RyaW5nKCIuLi4iLCBTdHJpbmdWaWV3KHRleHQpLnJpZ2h0KG1heCAtIDMpKTsKLSAgICAgICAg ICAgICAgICBjYXJldCA9IHBvcyAtICh0ZXh0TGVuZ3RoIC0gc2hvdy5sZW5ndGgoKSk7Ci0gICAg ICAgICAgICB9Ci0gICAgICAgICAgICAKLSAgICAgICAgICAgIHNob3cgPSBtYWtlU3RyaW5nQnlS ZXBsYWNpbmdBbGwoc2hvdywgJ1xuJywgJyAnKTsKLSAgICAgICAgICAgIHNob3cgPSBtYWtlU3Ry aW5nQnlSZXBsYWNpbmdBbGwoc2hvdywgJ1xyJywgJyAnKTsKLSAgICAgICAgICAgIGZwcmludGYo c3RkZXJyLCAiPT0+ICN0ZXh0IDogXCIlc1wiIGF0IG9mZnNldCAlZFxuIiwgc2hvdy51dGY4KCku ZGF0YSgpLCBwb3MpOwotICAgICAgICAgICAgZnByaW50ZihzdGRlcnIsICIgICAgICAgICAgICIp OwotICAgICAgICAgICAgZm9yIChpbnQgaSA9IDA7IGkgPCBjYXJldDsgaSsrKQotICAgICAgICAg ICAgICAgIGZwcmludGYoc3RkZXJyLCAiICIpOwotICAgICAgICAgICAgZnByaW50ZihzdGRlcnIs ICJeXG4iKTsKLSAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgIGlmICgoaW50KXRleHQubGVu Z3RoKCkgPiBtYXgpCi0gICAgICAgICAgICAgICAgdGV4dCA9IHRleHQubGVmdChtYXggLSAzKSAr ICIuLi4iOwotICAgICAgICAgICAgZWxzZQotICAgICAgICAgICAgICAgIHRleHQgPSB0ZXh0Lmxl ZnQobWF4KTsKLSAgICAgICAgICAgIGZwcmludGYoc3RkZXJyLCAiICAgICN0ZXh0IDogXCIlc1wi XG4iLCB0ZXh0LnV0ZjgoKS5kYXRhKCkpOwotICAgICAgICB9Ci0gICAgfQotfQotCiBib29sIEZy YW1lU2VsZWN0aW9uOjpjb250YWlucyhjb25zdCBMYXlvdXRQb2ludCYgcG9pbnQpIGNvbnN0CiB7 CiAgICAgLy8gVHJlYXQgYSBjb2xsYXBzZWQgc2VsZWN0aW9uIGxpa2Ugbm8gc2VsZWN0aW9uLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5oIGIvU291 cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5oCmluZGV4IDFmODFhYWE4ZWY5Ny4u MTk4YjZhZmY2NzYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0ZyYW1lU2Vs ZWN0aW9uLmgKKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5oCkBA IC0xOTMsOCArMTkzLDYgQEAgcHVibGljOgogICAgIGJvb2wgaXNDYXJldE9yUmFuZ2UoKSBjb25z dCB7IHJldHVybiBtX3NlbGVjdGlvbi5pc0NhcmV0T3JSYW5nZSgpOyB9CiAgICAgYm9vbCBpc0Fs bChFZGl0aW5nQm91bmRhcnlDcm9zc2luZ1J1bGUgcnVsZSA9IENhbm5vdENyb3NzRWRpdGluZ0Jv dW5kYXJ5KSBjb25zdCB7IHJldHVybiBtX3NlbGVjdGlvbi5pc0FsbChydWxlKTsgfQogICAgIAot ICAgIHZvaWQgZGVidWdSZW5kZXJlcihSZW5kZXJPYmplY3QqLCBib29sIHNlbGVjdGVkKSBjb25z dDsKLQogICAgIHZvaWQgbm9kZVdpbGxCZVJlbW92ZWQoTm9kZSYpOwogICAgIHZvaWQgdGV4dFdh c1JlcGxhY2VkKENoYXJhY3RlckRhdGEmLCB1bnNpZ25lZCBvZmZzZXQsIHVuc2lnbmVkIG9sZExl bmd0aCwgdW5zaWduZWQgbmV3TGVuZ3RoKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclRleHQuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJU ZXh0LmgKaW5kZXggZWI5ZDgwODM2N2ZmLi5hMDQ4ZjhjOWEyMTUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlclRleHQuaApAQCAtMTUxLDggKzE1MSw2IEBAIHB1YmxpYzoKIAogICAgIHZv aWQgbW9tZW50YXJpbHlSZXZlYWxMYXN0VHlwZWRDaGFyYWN0ZXIodW5zaWduZWQgb2Zmc2V0QWZ0 ZXJMYXN0VHlwZWRDaGFyYWN0ZXIpOwogCi0gICAgTGVnYWN5SW5saW5lVGV4dEJveCogZmluZE5l eHRJbmxpbmVUZXh0Qm94KGludCBvZmZzZXQsIGludCYgcG9zKSBjb25zdCB7IHJldHVybiBtX2xp bmVCb3hlcy5maW5kTmV4dChvZmZzZXQsIHBvcyk7IH0KLQogICAgIGJvb2wgaXNBbGxDb2xsYXBz aWJsZVdoaXRlc3BhY2UoKSBjb25zdDsKIAogICAgIGJvb2wgY2FuVXNlU2ltcGxlRm9udENvZGVQ YXRoKCkgY29uc3QgeyByZXR1cm4gbV9jYW5Vc2VTaW1wbGVGb250Q29kZVBhdGg7IH0K