250584 2023-01-13 11:00:27 -0800 [WebRTC] Fix -Wdeprecated-copy warnings in the boringssl project 2023-01-13 21:40:38 -0800 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 250431 1 ddkilzer ddkilzer webkit-bug-importer youennf oldest_to_newest 1925389 0 ddkilzer 2023-01-13 11:00:27 -0800 Fix -Wdeprecated-copy warnings in the boringssl project: Source/third_party/boringssl/src/include/openssl/bytestring.h:53:3: error: definition of implicit copy assignment operator for 'cbs_st' is deprecated because it has a user-declared copy constructor [-Werror,-Wdeprecated-copy] cbs_st(const cbs_st &) = default; ^ Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/ssl/t1_lib.cc:183:14: note: in implicit copy assignment operator for 'cbs_st' first required here extensions = *cbs; ^ Source/third_party/boringssl/src/include/openssl/bytestring.h:53:3: error: definition of implicit copy assignment operator for 'cbs_st' is deprecated because it has a user-declared copy constructor [-Werror,-Wdeprecated-copy] cbs_st(const cbs_st &) = default; ^ Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/ssl/handshake_server.cc:452:18: note: in implicit copy assignment operator for 'cbs_st' first required here extensions = copy; ^ Source/third_party/boringssl/src/include/openssl/bytestring.h:53:3: error: definition of implicit copy assignment operator for 'cbs_st' is deprecated because it has a user-declared copy constructor [-Werror,-Wdeprecated-copy] cbs_st(const cbs_st &) = default; ^ Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/ssl/handshake.cc:176:18: note: in implicit copy assignment operator for 'cbs_st' first required here out_msg->raw = CBS(ech_client_hello_buf); ^ Fixed by upstream commit: Fix a -Wdeprecated-copy warning. https://github.com/google/boringssl/commit/f315a86df3d5cd51135db996c9d5747ec2641331 1925390 1 webkit-bug-importer 2023-01-13 11:00:51 -0800 <rdar://problem/104231355> 1925391 2 ddkilzer 2023-01-13 11:02:21 -0800 Pull request: https://github.com/WebKit/WebKit/pull/8631 1925538 3 ews-feeder 2023-01-13 21:40:36 -0800 Committed 258907@main (ade6fee2858e): <https://commits.webkit.org/258907@main> Reviewed commits have been landed. Closing PR #8631 and removing active labels.