25058 2009-04-06 10:55:35 -0700 Fix chromium build bustage caused by r42216 2009-04-06 13:49:31 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fishd fishd mbelshe sam oldest_to_newest 116638 0 fishd 2009-04-06 10:55:35 -0700 Fix chromium build bustage caused by r42216 That change included the following patch to DOMWindow.idl:http://trac.webkit.org/changeset/42216/trunk/WebCore/page/DOMWindow.idl Those changes should have used the JSC prefix for Custom attributes. Patch coming up... 116642 1 29280 fishd 2009-04-06 11:10:20 -0700 Created attachment 29280 v1 patch 116643 2 29280 dglazkov 2009-04-06 11:16:55 -0700 Comment on attachment 29280 v1 patch Ok. 116646 3 fishd 2009-04-06 11:24:02 -0700 Landed as: http://trac.webkit.org/changeset/42249 116652 4 fishd 2009-04-06 11:42:10 -0700 Whoops, that was not quite right. I revert this in r42250. 116667 5 29287 fishd 2009-04-06 13:36:55 -0700 Created attachment 29287 v2 patch Version 2, which actually works. It turns out that you cannot combine CustomGetter and CustomSetter. So, now I am using JSCCustom and V8CustomSetter. 116668 6 29287 dglazkov 2009-04-06 13:47:21 -0700 Comment on attachment 29287 v2 patch This one better work. 116669 7 fishd 2009-04-06 13:49:31 -0700 http://trac.webkit.org/changeset/42254 29280 2009-04-06 11:10:20 -0700 2009-04-06 11:44:14 -0700 v1 patch win_1.txt text/plain 1559 fishd SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQyMjQ2 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMDQt MDYgIERhcmluIEZpc2hlciAgPGRhcmluQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjUwNTgKKyAgICAgICAgRml4IGNocm9taXVtIGJ1aWxkIGJ1c3RhZ2Ug Y2F1c2VkIGJ5IHI0MjIxNgorCisgICAgICAgICogcGFnZS9ET01XaW5kb3cuaWRsOgorCiAyMDA5 LTA0LTA2ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IERhcmluIEFkbGVyCkluZGV4OiBwYWdlL0RPTVdpbmRvdy5pZGwKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gcGFnZS9ET01XaW5kb3cuaWRsCShyZXZpc2lvbiA0MjI0NCkKKysrIHBhZ2UvRE9N V2luZG93LmlkbAkod29ya2luZyBjb3B5KQpAQCAtNDQsNyArNDQsNyBAQCBtb2R1bGUgd2luZG93 IHsKICAgICBdIERPTVdpbmRvdyB7CiAgICAgICAgIC8vIERPTSBMZXZlbCAwCiAgICAgICAgIHJl YWRvbmx5IGF0dHJpYnV0ZSBTY3JlZW4gc2NyZWVuOwotICAgICAgICByZWFkb25seSBhdHRyaWJ1 dGUgW0RvTm90Q2hlY2tEb21haW5TZWN1cml0eSwgQ3VzdG9tR2V0dGVyXSBIaXN0b3J5IGhpc3Rv cnk7CisgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBbRG9Ob3RDaGVja0RvbWFpblNlY3VyaXR5 LCBKU0NDdXN0b21HZXR0ZXJdIEhpc3RvcnkgaGlzdG9yeTsKICAgICAgICAgYXR0cmlidXRlIFtS ZXBsYWNlYWJsZV0gQmFySW5mbyBsb2NhdGlvbmJhcjsKICAgICAgICAgYXR0cmlidXRlIFtSZXBs YWNlYWJsZV0gQmFySW5mbyBtZW51YmFyOwogICAgICAgICBhdHRyaWJ1dGUgW1JlcGxhY2VhYmxl XSBCYXJJbmZvIHBlcnNvbmFsYmFyOwpAQCAtNTMsNyArNTMsNyBAQCBtb2R1bGUgd2luZG93IHsK ICAgICAgICAgYXR0cmlidXRlIFtSZXBsYWNlYWJsZV0gQmFySW5mbyB0b29sYmFyOwogICAgICAg ICBhdHRyaWJ1dGUgW1JlcGxhY2VhYmxlXSBOYXZpZ2F0b3IgbmF2aWdhdG9yOwogICAgICAgICBh dHRyaWJ1dGUgW1JlcGxhY2VhYmxlXSBOYXZpZ2F0b3IgY2xpZW50SW5mb3JtYXRpb247Ci0gICAg ICAgIGF0dHJpYnV0ZSBbRG9Ob3RDaGVja0RvbWFpblNlY3VyaXR5LCBDdXN0b20sIFY4RGlzYWxs b3dTaGFkb3dpbmddIExvY2F0aW9uIGxvY2F0aW9uOworICAgICAgICBhdHRyaWJ1dGUgW0RvTm90 Q2hlY2tEb21haW5TZWN1cml0eSwgQ3VzdG9tU2V0dGVyLCBKU0NDdXN0b21HZXR0ZXIsIFY4RGlz YWxsb3dTaGFkb3dpbmddIExvY2F0aW9uIGxvY2F0aW9uOwogCiAgICAgICAgIERPTVNlbGVjdGlv biBnZXRTZWxlY3Rpb24oKTsKIAo= 29287 2009-04-06 13:36:55 -0700 2009-04-06 13:47:21 -0700 v2 patch win_2.txt text/plain 5685 fishd SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MjI1MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMDQtMDYgIERhcmluIEZpc2hlciAgPGRhcmluQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEdsYXprb3YuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1MDU4CisgICAgICAgIEZp eCBjaHJvbWl1bSBidWlsZCBidXN0YWdlIGNhdXNlZCBieSByNDIyMTYKKworICAgICAgICAqIGJp bmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtOgorICAgICAgICAqIHBhZ2UvRE9NV2lu ZG93LmlkbDoKKwogMjAwOS0wNC0wNiAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z3VzdGF2by5u b3JvbmhhQGNvbGxhYm9yYS5jby51az4KIAogICAgICAgICBSdWJiZXItc3RhbXBlZCBieSBTYW0g V2VpbmlnLgpJbmRleDogV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5w bQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpT LnBtCShyZXZpc2lvbiA0MjI1MCkKKysrIFdlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2Vu ZXJhdG9ySlMucG0JKHdvcmtpbmcgY29weSkKQEAgLTUzNiw4ICs1MzYsOCBAQCBzdWIgR2VuZXJh dGVIZWFkZXIKICAgICAgICAgZm9yZWFjaCAoQHskZGF0YU5vZGUtPmF0dHJpYnV0ZXN9KSB7CiAg ICAgICAgICAgICBteSAkYXR0cmlidXRlID0gJF87CiAgICAgICAgICAgICAkbnVtQ3VzdG9tQXR0 cmlidXRlcysrIGlmICRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57 IkN1c3RvbSJ9IHx8ICRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57 IkpTQ0N1c3RvbSJ9OwotICAgICAgICAgICAgJG51bUN1c3RvbUF0dHJpYnV0ZXMrKyBpZiAkYXR0 cmlidXRlLT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDdXN0b21HZXR0ZXIifTsK LSAgICAgICAgICAgICRudW1DdXN0b21BdHRyaWJ1dGVzKysgaWYgJGF0dHJpYnV0ZS0+c2lnbmF0 dXJlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiQ3VzdG9tU2V0dGVyIn07CisgICAgICAgICAgICAk bnVtQ3VzdG9tQXR0cmlidXRlcysrIGlmICRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+ZXh0ZW5kZWRB dHRyaWJ1dGVzLT57IkN1c3RvbUdldHRlciJ9IHx8ICRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+ZXh0 ZW5kZWRBdHRyaWJ1dGVzLT57IkpTQ0N1c3RvbUdldHRlciJ9OworICAgICAgICAgICAgJG51bUN1 c3RvbUF0dHJpYnV0ZXMrKyBpZiAkYXR0cmlidXRlLT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmli dXRlcy0+eyJDdXN0b21TZXR0ZXIifSB8fCAkYXR0cmlidXRlLT5zaWduYXR1cmUtPmV4dGVuZGVk QXR0cmlidXRlcy0+eyJKU0NDdXN0b21TZXR0ZXIifTsKICAgICAgICAgfQogICAgIH0KIApAQCAt NTUwLDkgKzU1MCw5IEBAIHN1YiBHZW5lcmF0ZUhlYWRlcgogICAgICAgICAgICAgICAgIGlmICgk YXR0cmlidXRlLT50eXBlICF+IC9ecmVhZG9ubHkvKSB7CiAgICAgICAgICAgICAgICAgICAgIHB1 c2goQGhlYWRlckNvbnRlbnQsICIgICAgdm9pZCBzZXQiIC4gJGNvZGVHZW5lcmF0b3ItPldLX3Vj Zmlyc3QoJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT5uYW1lKSAuICIoSlNDOjpFeGVjU3RhdGUqLCBK U0M6OkpTVmFsdWVQdHIpO1xuIik7CiAgICAgICAgICAgICAgICAgfQotICAgICAgICAgICAgfSBl bHNpZiAoJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiQ3VzdG9t R2V0dGVyIn0pIHsKKyAgICAgICAgICAgIH0gZWxzaWYgKCRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+ ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkN1c3RvbUdldHRlciJ9IHx8ICRhdHRyaWJ1dGUtPnNpZ25h dHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkpTQ0N1c3RvbUdldHRlciJ9KSB7CiAgICAgICAg ICAgICAgICAgcHVzaChAaGVhZGVyQ29udGVudCwgIiAgICBKU0M6OkpTVmFsdWVQdHIgIiAuICRj b2RlR2VuZXJhdG9yLT5XS19sY2ZpcnN0KCRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+bmFtZSkgLiAi KEpTQzo6RXhlY1N0YXRlKikgY29uc3Q7XG4iKTsKLSAgICAgICAgICAgIH0gZWxzaWYgKCRhdHRy aWJ1dGUtPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkN1c3RvbVNldHRlciJ9KSB7 CisgICAgICAgICAgICB9IGVsc2lmICgkYXR0cmlidXRlLT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0 cmlidXRlcy0+eyJDdXN0b21TZXR0ZXIifSB8fCAkYXR0cmlidXRlLT5zaWduYXR1cmUtPmV4dGVu ZGVkQXR0cmlidXRlcy0+eyJKU0NDdXN0b21TZXR0ZXIifSkgewogICAgICAgICAgICAgICAgIGlm ICgkYXR0cmlidXRlLT50eXBlICF+IC9ecmVhZG9ubHkvKSB7CiAgICAgICAgICAgICAgICAgICAg IHB1c2goQGhlYWRlckNvbnRlbnQsICIgICAgdm9pZCBzZXQiIC4gJGNvZGVHZW5lcmF0b3ItPldL X3VjZmlyc3QoJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT5uYW1lKSAuICIoSlNDOjpFeGVjU3RhdGUq LCBKU0M6OkpTVmFsdWVQdHIpO1xuIik7CiAgICAgICAgICAgICAgICAgfQpAQCAtMTEwMiw3ICsx MTAyLDcgQEAgc3ViIEdlbmVyYXRlSW1wbGVtZW50YXRpb24KICAgICAgICAgICAgICAgICAgICAg cHVzaChAaW1wbENvbnRlbnQsICIgICAgICAgIHJldHVybiBqc1VuZGVmaW5lZCgpO1xuIik7CiAg ICAgICAgICAgICAgICAgfQogCi0gICAgICAgICAgICAgICAgaWYgKCRhdHRyaWJ1dGUtPnNpZ25h dHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkN1c3RvbSJ9IHx8ICRhdHRyaWJ1dGUtPnNpZ25h dHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkpTQ0N1c3RvbSJ9IHx8ICRhdHRyaWJ1dGUtPnNp Z25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkN1c3RvbUdldHRlciJ9KSB7CisgICAgICAg ICAgICAgICAgaWYgKCRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57 IkN1c3RvbSJ9IHx8ICRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57 IkpTQ0N1c3RvbSJ9IHx8ICRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVz LT57IkN1c3RvbUdldHRlciJ9IHx8ICRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRy aWJ1dGVzLT57IkpTQ0N1c3RvbUdldHRlciJ9KSB7CiAgICAgICAgICAgICAgICAgICAgIHB1c2go QGltcGxDb250ZW50LCAiICAgIHJldHVybiBzdGF0aWNfY2FzdDwkY2xhc3NOYW1lKj4oYXNPYmpl Y3Qoc2xvdC5zbG90QmFzZSgpKSktPiRpbXBsR2V0dGVyRnVuY3Rpb25OYW1lKGV4ZWMpO1xuIik7 CiAgICAgICAgICAgICAgICAgfSBlbHNpZiAoJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT5leHRlbmRl ZEF0dHJpYnV0ZXMtPnsiQ2hlY2tOb2RlU2VjdXJpdHkifSkgewogICAgICAgICAgICAgICAgICAg ICAkaW1wbEluY2x1ZGVzeyJKU0RPTUJpbmRpbmcuaCJ9ID0gMTsKQEAgLTEyMzUsNyArMTIzNSw3 IEBAIHN1YiBHZW5lcmF0ZUltcGxlbWVudGF0aW9uCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgcHVzaChAaW1wbENvbnRlbnQsICIgICAgICAgIHJldHVybjtcbiIpOwogICAgICAgICAgICAg ICAgICAgICAgICAgfQogCi0gICAgICAgICAgICAgICAgICAgICAgICBpZiAoJGF0dHJpYnV0ZS0+ c2lnbmF0dXJlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiQ3VzdG9tIn0gfHwgJGF0dHJpYnV0ZS0+ c2lnbmF0dXJlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiSlNDQ3VzdG9tIn0gfHwgJGF0dHJpYnV0 ZS0+c2lnbmF0dXJlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiQ3VzdG9tU2V0dGVyIn0pIHsKKyAg ICAgICAgICAgICAgICAgICAgICAgIGlmICgkYXR0cmlidXRlLT5zaWduYXR1cmUtPmV4dGVuZGVk QXR0cmlidXRlcy0+eyJDdXN0b20ifSB8fCAkYXR0cmlidXRlLT5zaWduYXR1cmUtPmV4dGVuZGVk QXR0cmlidXRlcy0+eyJKU0NDdXN0b20ifSB8fCAkYXR0cmlidXRlLT5zaWduYXR1cmUtPmV4dGVu ZGVkQXR0cmlidXRlcy0+eyJDdXN0b21TZXR0ZXIifSB8fCAkYXR0cmlidXRlLT5zaWduYXR1cmUt PmV4dGVuZGVkQXR0cmlidXRlcy0+eyJKU0NDdXN0b21TZXR0ZXIifSkgewogICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiICAgIHN0YXRpY19jYXN0PCRjbGFz c05hbWUqPih0aGlzT2JqZWN0KS0+c2V0JGltcGxTZXR0ZXJGdW5jdGlvbk5hbWUoZXhlYywgdmFs dWUpO1xuIik7CiAgICAgICAgICAgICAgICAgICAgICAgICB9IGVsc2lmICgkdHlwZSBlcSAiRXZl bnRMaXN0ZW5lciIpIHsKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAkaW1wbEluY2x1ZGVz eyJKU0V2ZW50TGlzdGVuZXIuaCJ9ID0gMTsKSW5kZXg6IFdlYkNvcmUvcGFnZS9ET01XaW5kb3cu aWRsCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9ET01XaW5kb3cuaWRsCShyZXZpc2lvbiA0 MjI1MCkKKysrIFdlYkNvcmUvcGFnZS9ET01XaW5kb3cuaWRsCSh3b3JraW5nIGNvcHkpCkBAIC00 NCw3ICs0NCw3IEBAIG1vZHVsZSB3aW5kb3cgewogICAgIF0gRE9NV2luZG93IHsKICAgICAgICAg Ly8gRE9NIExldmVsIDAKICAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIFNjcmVlbiBzY3JlZW47 Ci0gICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBbRG9Ob3RDaGVja0RvbWFpblNlY3VyaXR5LCBD dXN0b21HZXR0ZXJdIEhpc3RvcnkgaGlzdG9yeTsKKyAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRl IFtEb05vdENoZWNrRG9tYWluU2VjdXJpdHksIEpTQ0N1c3RvbUdldHRlcl0gSGlzdG9yeSBoaXN0 b3J5OwogICAgICAgICBhdHRyaWJ1dGUgW1JlcGxhY2VhYmxlXSBCYXJJbmZvIGxvY2F0aW9uYmFy OwogICAgICAgICBhdHRyaWJ1dGUgW1JlcGxhY2VhYmxlXSBCYXJJbmZvIG1lbnViYXI7CiAgICAg ICAgIGF0dHJpYnV0ZSBbUmVwbGFjZWFibGVdIEJhckluZm8gcGVyc29uYWxiYXI7CkBAIC01Myw3 ICs1Myw3IEBAIG1vZHVsZSB3aW5kb3cgewogICAgICAgICBhdHRyaWJ1dGUgW1JlcGxhY2VhYmxl XSBCYXJJbmZvIHRvb2xiYXI7CiAgICAgICAgIGF0dHJpYnV0ZSBbUmVwbGFjZWFibGVdIE5hdmln YXRvciBuYXZpZ2F0b3I7CiAgICAgICAgIGF0dHJpYnV0ZSBbUmVwbGFjZWFibGVdIE5hdmlnYXRv ciBjbGllbnRJbmZvcm1hdGlvbjsKLSAgICAgICAgYXR0cmlidXRlIFtEb05vdENoZWNrRG9tYWlu U2VjdXJpdHksIEN1c3RvbSwgVjhEaXNhbGxvd1NoYWRvd2luZ10gTG9jYXRpb24gbG9jYXRpb247 CisgICAgICAgIGF0dHJpYnV0ZSBbRG9Ob3RDaGVja0RvbWFpblNlY3VyaXR5LCBKU0NDdXN0b20s IFY4Q3VzdG9tU2V0dGVyLCBWOERpc2FsbG93U2hhZG93aW5nXSBMb2NhdGlvbiBsb2NhdGlvbjsK IAogICAgICAgICBET01TZWxlY3Rpb24gZ2V0U2VsZWN0aW9uKCk7CiAK