250558 2023-01-13 03:29:05 -0800 texSubImage2D crashed on iOS16 + WebGL2 + large WASM memory 2023-05-22 01:23:18 -0700 1 1 1 Unclassified WebKit WebGL WebKit Local Build iPhone / iPad iOS 16 RESOLVED FIXED InRadar P2 Normal --- 1 fuyoucheng kkinnunen dino kbr kkinnunen ruba.merza webkit-bug-importer oldest_to_newest 1925287 0 fuyoucheng 2023-01-13 03:29:05 -0800 How to reproduce: 1. Create a new Untiy WebGL project with an empty scene, 2. Set graphic api to WebGL2， 3. Set WASM initial memory to a large size (by adding "-s TOTAL_MEMORY=768MB" to PlayerSettings.WebGL.emscriptenArgs) 4. Build and load with Safari on iPhone12 with iOS16, 5. Safari report error when loading. Rootcause: Unity called texSubImage2D during initialization, Safari report error when invoking this api due to insufficient memory. But that texture is 4*4 RGBA UNSIGNED_BYTE, should not cause any memory pressure. When looking into WebGL2RenderingContext::texSubImage2D in WebKit source code, we found: In WebGLRenderingContextBase::texImageArrayBufferViewHelper, variable 'data' created by WebGLRenderingContextBase::validateTexFuncData has incorrect value. data.m_bufSize ought to be pixel data length, but acturally assigned as arrayBuffer(whole WASM memory) length - pixel data offset, which is much more larger. Then later in IPC::Encoder::encodeFixedLengthData, encoder buffer will grow by this large size and lead to memory issue. 1925854 1 webkit-bug-importer 2023-01-16 12:38:23 -0800 <rdar://problem/104305743> 1930014 2 kkinnunen 2023-02-01 00:38:28 -0800 *** Bug 250862 has been marked as a duplicate of this bug. *** 1930015 3 kkinnunen 2023-02-01 00:38:48 -0800 See bug 250558 for a test case 1930094 4 kkinnunen 2023-02-01 06:51:29 -0800 Pull request: https://github.com/WebKit/WebKit/pull/9451 1930390 5 ews-feeder 2023-02-02 00:40:03 -0800 Committed 259742@main (905fdd75fe5d): <https://commits.webkit.org/259742@main> Reviewed commits have been landed. Closing PR #9451 and removing active labels. 1956868 6 kkinnunen 2023-05-22 01:23:18 -0700 The fix shipped in iOS 16.4, macOS 12.3, Safari 16.4