<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>250524</bug_id>
          
          <creation_ts>2023-01-12 13:15:57 -0800</creation_ts>
          <short_desc>Fix nit which is inefficient sequence to deleteMarkedNodes</short_desc>
          <delta_ts>2023-01-14 11:54:17 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Audio</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ahmad Saleem">ahmad.saleem792</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>cdumez</cc>
    
    <cc>jer.noble</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1925123</commentid>
    <comment_count>0</comment_count>
    <who name="Ahmad Saleem">ahmad.saleem792</who>
    <bug_when>2023-01-12 13:15:57 -0800</bug_when>
    <thetext>Hi Team,

While going through Blink&apos;s commit, I think we can fix inefficient sequence as well:

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/ec81c8eb26580fce076c096c13463d754f40e6c3

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/Modules/webaudio/BaseAudioContext.cpp#179

Move this below:

m_nodesToDelete = std::exchange(m_nodesMarkedForDeletion, { });
---&gt; here

Just wanted to raise so we can fix this.

Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1925591</commentid>
    <comment_count>1</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-01-14 11:53:25 -0800</bug_when>
    <thetext>Committed 258920@main (6eceb6d922f3): &lt;https://commits.webkit.org/258920@main&gt;

Reviewed commits have been landed. Closing PR #8590 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1925592</commentid>
    <comment_count>2</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2023-01-14 11:54:17 -0800</bug_when>
    <thetext>&lt;rdar://problem/104263455&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>