<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>250510</bug_id>
          
          <creation_ts>2023-01-12 04:16:40 -0800</creation_ts>
          <short_desc>Validate animation key paths sent over IPC</short_desc>
          <delta_ts>2023-02-01 11:33:51 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Animations</component>
          <version>Safari Technology Preview</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>250509</dependson>
    
    <dependson>250519</dependson>
    
    <dependson>250520</dependson>
    
    <dependson>250641</dependson>
    
    <dependson>250642</dependson>
    
    <dependson>250744</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Antoine Quint">graouts</reporter>
          <assigned_to name="Antoine Quint">graouts</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>dino</cc>
    
    <cc>graouts</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1925027</commentid>
    <comment_count>0</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2023-01-12 04:16:40 -0800</bug_when>
    <thetext>We currently send a CAAnimation&apos;s keyPath over IPC as a String. We should send this as a struct for the string to be generated in the UI Process for added security.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1925028</commentid>
    <comment_count>1</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2023-01-12 04:16:54 -0800</bug_when>
    <thetext>rdar://102433824</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1925108</commentid>
    <comment_count>2</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2023-01-12 12:14:17 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/8587</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1925755</commentid>
    <comment_count>3</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2023-01-16 01:16:13 -0800</bug_when>
    <thetext>Simon suggested that we keep using strings to represent animation key paths but instead validate the string in the UIProcess once received before creating the CAAnimation. Renaming bug to track this effort.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1925756</commentid>
    <comment_count>4</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2023-01-16 01:28:28 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/8680</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1926004</commentid>
    <comment_count>5</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-01-17 08:58:18 -0800</bug_when>
    <thetext>Committed 258986@main (a4467affde12): &lt;https://commits.webkit.org/258986@main&gt;

Reviewed commits have been landed. Closing PR #8680 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1926164</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2023-01-17 17:43:34 -0800</bug_when>
    <thetext>Re-opened since this is blocked by bug 250744</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1926224</commentid>
    <comment_count>7</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2023-01-18 02:03:33 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/8760</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1926531</commentid>
    <comment_count>8</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-01-18 22:44:37 -0800</bug_when>
    <thetext>Committed 259066@main (f554fc01c126): &lt;https://commits.webkit.org/259066@main&gt;

Reviewed commits have been landed. Closing PR #8760 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1930196</commentid>
    <comment_count>9</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2023-02-01 11:30:40 -0800</bug_when>
    <thetext>Re-opening for pull request https://github.com/WebKit/WebKit/pull/9466</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1930200</commentid>
    <comment_count>10</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2023-02-01 11:33:51 -0800</bug_when>
    <thetext>Mistakenly re-opened this, closing it again.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>