250503 2023-01-11 23:01:44 -0800 AX: Remove obsolete comment in AXIsolatedTree::updateChildren regarding subtree removals 2023-01-12 10:39:41 -0800 1 1 1 Unclassified WebKit Accessibility Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tyler_w tyler_w aboxhall andresg_22 apinheiro cfleizach dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1924997 0 tyler_w 2023-01-11 23:01:44 -0800 This comment in AXIsolatedTree::updateChildren: https://github.com/WebKit/WebKit/blob/65cbbd06b50bb3c8e45aabd0c47322e540baf4fd/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp#L609#L613 Was obsoleted by this commit: https://github.com/WebKit/WebKit/commit/755fc266ed7bbbbcd5505c9e842d89caf9796c19 Because the referenced variable (`idsBeingChanged`) was obsoleted by checking m_unresolvedPendingAppends in AXIsolatedTree::removeSubtreeFromNodeMap (which accomplishes the same thing). 1924998 1 webkit-bug-importer 2023-01-11 23:01:55 -0800 <rdar://problem/104156450> 1924999 2 464467 tyler_w 2023-01-11 23:08:11 -0800 Created attachment 464467 Patch 1925094 3 ews-feeder 2023-01-12 10:39:39 -0800 Committed 258839@main (88766c1ad26b): <https://commits.webkit.org/258839@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 464467. 464467 2023-01-11 23:08:11 -0800 2023-01-12 10:39:40 -0800 Patch bug-250503-20230111230810.patch text/plain 3380 tyler_w RnJvbSBiOGYyNjc4ZTU4ZTY3OTdlNTFjOWQ2NmUzYzc4MGVjYTgwNTUyN2ZiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUeWxlciBXaWxjb2NrIDx0eWxlcl93QGFwcGxlLmNvbT4KRGF0 ZTogV2VkLCAxMSBKYW4gMjAyMyAyMzowMjowMSAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIEFYOiBS ZW1vdmUgb2Jzb2xldGUgY29tbWVudCBpbiBBWElzb2xhdGVkVHJlZTo6dXBkYXRlQ2hpbGRyZW4K IHJlZ2FyZGluZyBzdWJ0cmVlIHJlbW92YWxzIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yNTA1MDMKIHJkYXI6Ly9wcm9ibGVtLzEwNDE1NjQ1MAoKUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCgpUaGlzIGNvbW1lbnQgaW4gQVhJc29sYXRlZFRyZWU6OnVwZGF0ZUNo aWxkcmVuIHJlZ2FyZGluZyBzdWJ0cmVlIHJlbW92YWwgYmVoYXZpb3Igd2FzIG9ic29sZXRlZCBi eSB0aGlzIGNvbW1pdDoKCmh0dHBzOi8vZ2l0aHViLmNvbS9XZWJLaXQvV2ViS2l0L2NvbW1pdC83 NTVmYzI2NmVkN2JiYmJjZDU1MDVjOWU4NDJkODljYWY5Nzk2YzE5CgpCZWNhdXNlIHRoZSByZWZl cmVuY2VkIHZhcmlhYmxlIChpZHNCZWluZ0NoYW5nZWQpIHdhcyBvYnNvbGV0ZWQgYnkgY2hlY2tp bmcgbV91bnJlc29sdmVkUGVuZGluZ0FwcGVuZHMgaW4KQVhJc29sYXRlZFRyZWU6OnJlbW92ZVN1 YnRyZWVGcm9tTm9kZU1hcCAod2hpY2ggYWNjb21wbGlzaGVzIHRoZSBzYW1lIHRoaW5nKS4KCkFs c28sIG1vdmUgdGhlIG9iamVjdElEKCkuaXNWYWxpZCgpIGNoZWNrIHBlcmZvcm1lZCBiZWZvcmUg Y2FsbGluZyByZW1vdmVTdWJ0cmVlRnJvbU5vZGVNYXAgdG8gcmVtb3ZlU3VidHJlZUZyb21Ob2Rl TWFwIGl0c2VsZi4KVGhpcyBtYWtlcyBBWElzb2xhdGVkVHJlZTo6dXBkYXRlQ2hpbGRyZW4gbGVz cyBkZW5zZSwgYW5kIGltcHJvdmVzIHRoZSBsb2dnaW5nIGdlbmVyYXRlZCBieSByZW1vdmVTdWJ0 cmVlRnJvbU5vZGVNYXAKYXMgaXQgd2lsbCBubyBsb25nZXIgbG9nICJUcmllZCB0byByZW1vdmUg QVhJRCAwIHRoYXQgaXMgbm8gbG9uZ2VyIGluIG1fbm9kZU1hcC4iIGZvciBpbnZhbGlkIElEcy4K CiogU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUvQVhJc29sYXRlZFRy ZWUuY3BwOgooV2ViQ29yZTo6QVhJc29sYXRlZFRyZWU6OnVwZGF0ZUNoaWxkcmVuKToKKFdlYkNv cmU6OkFYSXNvbGF0ZWRUcmVlOjpyZW1vdmVTdWJ0cmVlRnJvbU5vZGVNYXApOgotLS0KIC4uLi9h Y2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9BWElzb2xhdGVkVHJlZS5jcHAgIHwgMTQgKysrKyst LS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUv QVhJc29sYXRlZFRyZWUuY3BwIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9pc29sYXRl ZHRyZWUvQVhJc29sYXRlZFRyZWUuY3BwCmluZGV4IGU1ZDY0MDMwMWQzNS4uOTc5MzIxODdkMmUz IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9B WElzb2xhdGVkVHJlZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9pc29s YXRlZHRyZWUvQVhJc29sYXRlZFRyZWUuY3BwCkBAIC02MDUsMTUgKzYwNSw4IEBAIHZvaWQgQVhJ c29sYXRlZFRyZWU6OnVwZGF0ZUNoaWxkcmVuKEFjY2Vzc2liaWxpdHlPYmplY3QmIGF4T2JqZWN0 LCBSZXNvbHZlTm9kZUNoCiAKICAgICAvLyBXaGF0IGlzIGxlZnQgaW4gb2xkQ2hpbGRyZW5JRHMg YXJlIHRoZSBJRHMgdGhhdCBhcmUgbm8gbG9uZ2VyIGNoaWxkcmVuIG9mIGF4QW5jZXN0b3IuCiAg ICAgLy8gVGh1cywgcmVtb3ZlIHRoZW0gZnJvbSBtX25vZGVNYXAgYW5kIHF1ZXVlIHRoZW0gdG8g YmUgcmVtb3ZlZCBmcm9tIHRoZSB0cmVlLgotICAgIGZvciAoY29uc3QgQVhJRCYgYXhJRCA6IG9s ZENoaWxkcmVuSURzKSB7Ci0gICAgICAgIC8vIEhvd2V2ZXIsIHdlIGRvbid0IHdhbnQgdG8gcmVt b3ZlIHN1YnRyZWVzIGZyb20gdGhlIG5vZGVtYXAgdGhhdCBhcmUgcGFydCBvZiB0aGUgdG8tYmUt cXVldWVkIG5vZGUgY2hhbmdlcyAoaS5lIHRob3NlIGluIGBpZHNCZWluZ0NoYW5nZWRgKS4KLSAg ICAgICAgLy8gVGhpcyBpcyBpbXBvcnRhbnQgd2hlbiBhIG5vZGUgbW92ZXMgdG8gYSBkaWZmZXJl bnQgcGFydCBvZiB0aGUgdHJlZSByYXRoZXIgdGhhbiBiZWluZyBkZWxldGVkIC0tIGZvciBleGFt cGxlOgotICAgICAgICAvLyAgIDEuIE9iamVjdCAxMjMgaXMgc2xhdGVkIHRvIGJlIGEgY2hpbGQg b2YgdGhpcyBvYmplY3QgKGkuZS4gaW4gbmV3Q2hpbGRyZW4pLCBhbmQgd2UgY29sbGVjdCBub2Rl IGNoYW5nZXMgZm9yIGl0LgotICAgICAgICAvLyAgIDIuIE9iamVjdCAxMjMgaXMgY3VycmVudGx5 IGEgbWVtYmVyIG9mIGEgc3VidHJlZSBvZiBzb21lIG90aGVyIG9iamVjdCBpbiBvbGRDaGlsZHJl bklEcy4KLSAgICAgICAgLy8gICAzLiBUaHVzLCB3ZSBkb24ndCB3YW50IHRvIGRlbGV0ZSBPYmpl Y3QgMTIzIGZyb20gdGhlIG5vZGVtYXAsIGluc3RlYWQgYWxsb3dpbmcgaXQgdG8gYmUgbW92ZWQu Ci0gICAgICAgIGlmIChheElELmlzVmFsaWQoKSkKLSAgICAgICAgICAgIHJlbW92ZVN1YnRyZWVG cm9tTm9kZU1hcChheElELCBheEFuY2VzdG9yKTsKLSAgICB9CisgICAgZm9yIChjb25zdCBBWElE JiBheElEIDogb2xkQ2hpbGRyZW5JRHMpCisgICAgICAgIHJlbW92ZVN1YnRyZWVGcm9tTm9kZU1h cChheElELCBheEFuY2VzdG9yKTsKIAogICAgIGlmIChyZXNvbHZlTm9kZUNoYW5nZXMgPT0gUmVz b2x2ZU5vZGVDaGFuZ2VzOjpZZXMpCiAgICAgICAgIHF1ZXVlUmVtb3ZhbHNBbmRVbnJlc29sdmVk Q2hhbmdlcyhXVEZNb3ZlKG9sZENoaWxkcmVuSURzKSk7CkBAIC02OTYsNiArNjg5LDkgQEAgdm9p ZCBBWElzb2xhdGVkVHJlZTo6cmVtb3ZlU3VidHJlZUZyb21Ob2RlTWFwKEFYSUQgb2JqZWN0SUQs IEFYQ29yZU9iamVjdCogYXhQYXIKICAgICBBWExPRyhtYWtlU3RyaW5nKCJSZW1vdmluZyBzdWJ0 cmVlIGZvciBvYmplY3RJRCAiLCBvYmplY3RJRC5sb2dnaW5nU3RyaW5nKCkpKTsKICAgICBBU1NF UlQoaXNNYWluVGhyZWFkKCkpOwogCisgICAgaWYgKCFvYmplY3RJRC5pc1ZhbGlkKCkpCisgICAg ICAgIHJldHVybjsKKwogICAgIGlmICghbV9ub2RlTWFwLmNvbnRhaW5zKG9iamVjdElEKSkgewog ICAgICAgICBBWExPRyhtYWtlU3RyaW5nKCJUcmllZCB0byByZW1vdmUgQVhJRCAiLCBvYmplY3RJ RC5sb2dnaW5nU3RyaW5nKCksICIgdGhhdCBpcyBubyBsb25nZXIgaW4gbV9ub2RlTWFwLiIpKTsK ICAgICAgICAgcmV0dXJuOwo=