250276 2023-01-07 10:09:56 -0800 Adjust error-handling for invalid filter primitive references 2024-05-28 19:38:19 -0700 1 1 1 Unclassified WebKit SVG Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar, LayerBasedSVGEngine P2 Normal --- 1 ahmad.saleem792 webkit-unassigned sabouhallawa simon.fraser webkit-bug-importer zimmermann oldest_to_newest 1923825 0 ahmad.saleem792 2023-01-07 10:09:56 -0800 Hi Team, While going through Blink's commit, I came across another failing test case: Test Case - https://jsfiddle.net/xothm1vc/show ^ Safari 16.2 & STP160 only show two green rectangles. While Firefox Nightly 110 and Chrome Canary 111 show full green bar rectangle, not just two slots. Blink Commit - https://chromium.googlesource.com/chromium/blink/+/ffa39ae78904542a2864e2cb7d1c16c24ee2324e I haven't checked whether it is 1-1 merge or not but just wanted to raise for tracking. Thanks! 1925583 1 webkit-bug-importer 2023-01-14 10:10:15 -0800 <rdar://problem/104262208> 1953502 2 ahmad.saleem792 2023-05-07 04:17:26 -0700 WebKit ToT (263769@main) get full bar but half is 'red' while STP169 still shows only two rectangles. Just wanted to highlight small-progression. 1953503 3 ahmad.saleem792 2023-05-07 04:19:39 -0700 This commit removed 'SVGFilterBuilder.cpp' in WebKit - https://commits.webkit.org/251522@main 1953618 4 ahmad.saleem792 2023-05-08 02:29:16 -0700 (In reply to Ahmad Saleem from comment #2) > WebKit ToT (263769@main) get full bar but half is 'red' while STP169 still > shows only two rectangles. > > Just wanted to highlight small-progression. This is with LBSE turned on. LBSE off is still same. 1991316 5 ahmad.saleem792 2023-11-09 15:26:19 -0800 Something to do here ?: https://searchfox.org/wubkat/source/Source/WebCore/svg/graphics/filters/SVGFilterGraph.h#64 2034152 6 ahmad.saleem792 2024-05-08 16:38:21 -0700 This compiles and fixes this test case: RefPtr<NodeType> getNamedNode(const AtomString& id) const { if (!id.isEmpty()) { if (m_sourceNodes.contains(id)) return m_sourceNodes.get(id); if (m_namedNodes.contains(id)) return m_namedNodes.get(id); } if (m_lastNode) return m_lastNode; return sourceGraphic(); } in https://searchfox.org/wubkat/rev/7bf250e4832adfb28c2bf2bc518ad59958f2ae1b/Source/WebCore/svg/graphics/filters/SVGFilterGraph.h#78 For LBSE - there isn't any improvement or regression. 2038352 7 ews-feeder 2024-05-28 19:38:17 -0700 Committed 279421@main (8e028375b9c5): <https://commits.webkit.org/279421@main> Reviewed commits have been landed. Closing PR #28314 and removing active labels.