25027 2009-04-03 08:16:35 -0700 JavaScript parseInt wrong on negative numbers 2009-04-30 02:09:30 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 mihnea webkit-unassigned julien.dufrenne oldest_to_newest 116429 0 mihnea 2009-04-03 08:16:35 -0700 Hello, I used a simple test script for JavaScript parseInt function: <html> <head> <script> function testParseInt() { var result = -0.6; alert(parseInt(result)); } </script> </head> <body> <input type="button" onclick="testParseInt()" value="TestEval1"> </body> </html> However, instead of displaying 0, it display -1. The problem seems to be in: JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp function globalFuncParseInt at line: if (isfinite(d)) return jsNumber(exec, floor(d)); I think it should be: if (isfinite(d)) return jsNumber(exec, (d > 0) ? floor(d) : ceil(d)); I tested with latest WebKit build 42198 on Leopard and the alert displays -1 instead of 0. FF3/Opera/IE8(Win) display 0 on the same test. I can provide a patch but i was not sure where to put the layout test. Is it ok to change LayoutTests/fast/js/numeric-conversion-expected by adding test for this case or should i add another different unit test? Regards, Mihnea 116526 1 29250 mihnea 2009-04-04 00:58:45 -0700 Created attachment 29250 Simple patch for the issue Hello, I created the patch and added a simple test for the issue in LayoutTests/fast/js/numeric-conversion test. Regards, Mihnea 116656 2 29250 sam 2009-04-06 11:50:23 -0700 Comment on attachment 29250 Simple patch for the issue > - return jsNumber(exec, floor(d)); > + return jsNumber(exec, (d > 0)?floor(d):ceil(d)); Our style dictates that there should be spaces around the ? and : 116845 3 29325 mihnea 2009-04-08 00:19:41 -0700 Created attachment 29325 Patch following coding style rules Hello, I corrected the coding style and posted the patch again. Thanks for your comments. I will try to double check from now on the coding style before submitting a patch. I was mislead by the fact that in Xcode project i had formatted the code in appropriate style, while the script svn-create-patch somehow removed the spaces. Regards, Mihnea 117883 4 29325 oliver 2009-04-16 23:59:11 -0700 Comment on attachment 29325 Patch following coding style rules r=me! will land shortly 117884 5 oliver 2009-04-17 00:38:00 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp M LayoutTests/ChangeLog M LayoutTests/fast/js/numeric-conversion-expected.txt M LayoutTests/fast/js/resources/numeric-conversion.js Committed r42607 119440 6 julien.dufrenne 2009-04-30 02:09:30 -0700 *** Bug 25478 has been marked as a duplicate of this bug. *** 29250 2009-04-04 00:58:45 -0700 2009-04-08 00:19:41 -0700 Simple patch for the issue patch25027.txt text/plain 2878 mihnea SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQyMjI3KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDQtMDQgIE1paG5lYSBP dmlkZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisgICAgICAgIAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjUwMjcKKyAgICAgICAgCisgICAgICAgIFdoZW4gZGVhbGluZyB3aXRoIG5l Z2F0aXZlIG51bWJlcnMsIHBhcnNlSW50IHNob3VsZCB1c2UgY2VpbCBpbnN0ZWFkIG9mIGZsb29y LgorCisgICAgICAgICogcnVudGltZS9KU0dsb2JhbE9iamVjdEZ1bmN0aW9ucy5jcHA6CisgICAg ICAgIChKU0M6Omdsb2JhbEZ1bmNQYXJzZUludCk6CisKIDIwMDktMDQtMDIgIERhcmluIEFkbGVy ICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtldmluIERlY2tlci4K SW5kZXg6IEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxPYmplY3RGdW5jdGlvbnMuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxPYmplY3RGdW5j dGlvbnMuY3BwCShyZXZpc2lvbiA0MjIyNCkKKysrIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNH bG9iYWxPYmplY3RGdW5jdGlvbnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMDMsNyArMzAzLDcg QEAgSlNWYWx1ZVB0ciBnbG9iYWxGdW5jUGFyc2VJbnQoRXhlY1N0YXRlKgogICAgICAgICAgICAg cmV0dXJuIHZhbHVlOwogICAgICAgICBkb3VibGUgZCA9IHZhbHVlLnVuY2hlY2tlZEdldE51bWJl cigpOwogICAgICAgICBpZiAoaXNmaW5pdGUoZCkpCi0gICAgICAgICAgICByZXR1cm4ganNOdW1i ZXIoZXhlYywgZmxvb3IoZCkpOworICAgICAgICAgICAgcmV0dXJuIGpzTnVtYmVyKGV4ZWMsIChk ID4gMCk/Zmxvb3IoZCk6Y2VpbChkKSk7CiAgICAgICAgIGlmIChpc25hbihkKSB8fCBpc2luZihk KSkKICAgICAgICAgICAgIHJldHVybiBqc05hTigmZXhlYy0+Z2xvYmFsRGF0YSgpKTsKICAgICAg ICAgcmV0dXJuIGpzMCgpOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNDIyMjcpCisrKyBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAwOS0wNC0wNCAg TWlobmVhIE92aWRlbmllICA8bWlobmVhQGFkb2JlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yNTAyNworICAgICAgICAKKyAgICAgICAgQWRkIGEgc2ltcGxl IHRlc3QgZm9yIHBhcnNlSW50IHdpdGggbmVnYXRpdiBudW1iZXIuCisKKyAgICAgICAgKiBmYXN0 L2pzL251bWVyaWMtY29udmVyc2lvbi1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFzdC9qcy9y ZXNvdXJjZXMvbnVtZXJpYy1jb252ZXJzaW9uLmpzOgorCiAyMDA5LTA0LTA0ICBEYW4gQmVybnN0 ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFyayBSb3dlLgpJ bmRleDogTGF5b3V0VGVzdHMvZmFzdC9qcy9udW1lcmljLWNvbnZlcnNpb24tZXhwZWN0ZWQudHh0 Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvanMvbnVtZXJpYy1jb252ZXJzaW9uLWV4 cGVjdGVkLnR4dAkocmV2aXNpb24gNDIyMjQpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2pzL251bWVy aWMtY29udmVyc2lvbi1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTIwLDYgKzIwLDcg QEAgUEFTUyBwYXJzZUludCgnOTAwNzE5OTI1NDc0MDk5Mi4wZTIwMDAnKQogUEFTUyBwYXJzZUlu dChOYU4pIGlzIE5hTgogUEFTUyBwYXJzZUludCgtSW5maW5pdHkpIGlzIE5hTgogUEFTUyBwYXJz ZUludChJbmZpbml0eSkgaXMgTmFOCitQQVNTIHBhcnNlSW50KC0wLjYpLnRvU3RyaW5nKCkgaXMg JzAnCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCiAKIFRFU1QgQ09NUExFVEUKSW5k ZXg6IExheW91dFRlc3RzL2Zhc3QvanMvcmVzb3VyY2VzL251bWVyaWMtY29udmVyc2lvbi5qcwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2pzL3Jlc291cmNlcy9udW1lcmljLWNvbnZl cnNpb24uanMJKHJldmlzaW9uIDQyMjI0KQorKysgTGF5b3V0VGVzdHMvZmFzdC9qcy9yZXNvdXJj ZXMvbnVtZXJpYy1jb252ZXJzaW9uLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0yNiw0ICsyNiw2IEBA IHNob3VsZEJlKCJwYXJzZUludChOYU4pIiwgIk5hTiIpOwogc2hvdWxkQmUoInBhcnNlSW50KC1J bmZpbml0eSkiLCAiTmFOIik7CiBzaG91bGRCZSgicGFyc2VJbnQoSW5maW5pdHkpIiwgIk5hTiIp OwogCitzaG91bGRCZSgicGFyc2VJbnQoLTAuNikudG9TdHJpbmcoKSIsICInMCciKTsKKwogdmFy IHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7Cg== 29325 2009-04-08 00:19:41 -0700 2009-04-16 23:59:11 -0700 Patch following coding style rules patch25027New.txt text/plain 2892 mihnea SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQyMzE0KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDQtMDggIE1paG5lYSBP dmlkZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisgICAgICAgIAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjUwMjcKKyAgICAgICAgV2hlbiBkZWFsaW5nIHdpdGggbmVnYXRpdmUgbnVt YmVycywgcGFyc2VJbnQgc2hvdWxkIHVzZSBjZWlsIGluc3RlYWQgb2YgZmxvb3IuCisKKyAgICAg ICAgKiBydW50aW1lL0pTR2xvYmFsT2JqZWN0RnVuY3Rpb25zLmNwcDoKKyAgICAgICAgKEpTQzo6 Z2xvYmFsRnVuY1BhcnNlSW50KToKKwogMjAwOS0wNC0wNyAgRGF2aWQgTGV2aW4gIDxsZXZpbkBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZyBhbmQgR2VvZmYg R2FyZW4uCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsT2JqZWN0RnVuY3Rp b25zLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsT2Jq ZWN0RnVuY3Rpb25zLmNwcAkocmV2aXNpb24gNDIzMTMpCisrKyBKYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0pTR2xvYmFsT2JqZWN0RnVuY3Rpb25zLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzAzLDcg KzMwMyw3IEBAIEpTVmFsdWVQdHIgZ2xvYmFsRnVuY1BhcnNlSW50KEV4ZWNTdGF0ZSoKICAgICAg ICAgICAgIHJldHVybiB2YWx1ZTsKICAgICAgICAgZG91YmxlIGQgPSB2YWx1ZS51bmNoZWNrZWRH ZXROdW1iZXIoKTsKICAgICAgICAgaWYgKGlzZmluaXRlKGQpKQotICAgICAgICAgICAgcmV0dXJu IGpzTnVtYmVyKGV4ZWMsIGZsb29yKGQpKTsKKyAgICAgICAgICAgIHJldHVybiBqc051bWJlcihl eGVjLCAoZCA+IDApID8gZmxvb3IoZCkgOiBjZWlsKGQpKTsKICAgICAgICAgaWYgKGlzbmFuKGQp IHx8IGlzaW5mKGQpKQogICAgICAgICAgICAgcmV0dXJuIGpzTmFOKCZleGVjLT5nbG9iYWxEYXRh KCkpOwogICAgICAgICByZXR1cm4ganMwKCk7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA0MjMxNCkKKysr IExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisy MDA5LTA0LTA4ICBNaWhuZWEgT3ZpZGVuaWUgIDxtaWhuZWFAYWRvYmUuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1MDI3CisgICAgICAgIEFkZCBhIHNpbXBs ZSB0ZXN0IGZvciBwYXJzZUludCB3aXRoIG5lZ2F0aXYgbnVtYmVyLgorCisgICAgICAgICogZmFz dC9qcy9udW1lcmljLWNvbnZlcnNpb24tZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3QvanMv cmVzb3VyY2VzL251bWVyaWMtY29udmVyc2lvbi5qczoKKwogMjAwOS0wNC0wNyAgQWxleGV5IFBy b3NrdXJ5YWtvdiAgPGFwQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFjaWVq IFN0YWNob3dpYWsuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2pzL251bWVyaWMtY29udmVyc2lv bi1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9qcy9udW1lcmlj LWNvbnZlcnNpb24tZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA0MjMxMykKKysrIExheW91dFRlc3Rz L2Zhc3QvanMvbnVtZXJpYy1jb252ZXJzaW9uLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpA QCAtMjAsNiArMjAsNyBAQCBQQVNTIHBhcnNlSW50KCc5MDA3MTk5MjU0NzQwOTkyLjBlMjAwMCcp CiBQQVNTIHBhcnNlSW50KE5hTikgaXMgTmFOCiBQQVNTIHBhcnNlSW50KC1JbmZpbml0eSkgaXMg TmFOCiBQQVNTIHBhcnNlSW50KEluZmluaXR5KSBpcyBOYU4KK1BBU1MgcGFyc2VJbnQoLTAuNiku dG9TdHJpbmcoKSBpcyAnMCcKIFBBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKIAogVEVT VCBDT01QTEVURQpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9qcy9yZXNvdXJjZXMvbnVtZXJpYy1j b252ZXJzaW9uLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvanMvcmVzb3VyY2Vz L251bWVyaWMtY29udmVyc2lvbi5qcwkocmV2aXNpb24gNDIzMTMpCisrKyBMYXlvdXRUZXN0cy9m YXN0L2pzL3Jlc291cmNlcy9udW1lcmljLWNvbnZlcnNpb24uanMJKHdvcmtpbmcgY29weSkKQEAg LTI2LDQgKzI2LDYgQEAgc2hvdWxkQmUoInBhcnNlSW50KE5hTikiLCAiTmFOIik7CiBzaG91bGRC ZSgicGFyc2VJbnQoLUluZmluaXR5KSIsICJOYU4iKTsKIHNob3VsZEJlKCJwYXJzZUludChJbmZp bml0eSkiLCAiTmFOIik7CiAKK3Nob3VsZEJlKCJwYXJzZUludCgtMC42KS50b1N0cmluZygpIiwg IicwJyIpOworCiB2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsK