25023 2009-04-03 02:49:56 -0700 [Qt]Eliminating a leak in QNetworkReplyHandler 2010-03-16 06:06:41 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED P2 Major --- 0 Szirbucz.Tamas webkit-unassigned hausmann kbalazs oldest_to_newest 116409 0 Szirbucz.Tamas 2009-04-03 02:49:56 -0700 We found that QNetworkReplyHandler::m_reply has never been freed in some cases because QNetworkReplyHandler::release sets it to zero. Through that the call of deleteLater on it in QNetworkRepyHandler is useless. We did not see any problem when we had removed the problematic line. 116410 1 29223 Szirbucz.Tamas 2009-04-03 02:52:35 -0700 Created attachment 29223 proposed patch 116428 2 29223 hausmann 2009-04-03 07:28:42 -0700 Comment on attachment 29223 proposed patch I agree that there's probably a leak, but the purpose of release() is to transfer the ownership to the caller. If we don't reset m_reply to 0 a subsequent call to release() will return a pointer to the object whos ownership we transferred to the previous caller. In other words: I think the caller in abort() for example should call deleteLater on the reply(). Does that work for you? 116866 3 Szirbucz.Tamas 2009-04-08 05:48:24 -0700 Ops, sorry for the late response, this bug had got out of my mind. You are absolute right, the solution is to simply call deleteLater on reply in abort. 116867 4 29330 Szirbucz.Tamas 2009-04-08 05:49:06 -0700 Created attachment 29330 proposed patch 118379 5 ariya.hidayat 2009-04-22 05:10:23 -0700 Landed in r42747. Thanks! http://trac.webkit.org/changeset/42747 200155 6 kbalazs 2010-03-16 06:06:41 -0700 *** Bug 26922 has been marked as a duplicate of this bug. *** 29223 2009-04-03 02:52:35 -0700 2009-04-08 05:49:06 -0700 proposed patch tomiugyes.diff text/plain 1245 Szirbucz.Tamas ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MWNjMDI1ZS4uN2Y3NWYzMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0wNC0wMyAgVGFtYXMgU3ppcmJ1 Y3ogIDxTemlyYnVjei5UYW1hc0BzdHVkLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVsaW1pbmF0aW5nIGxlYWsgaW4gUU5ldHdv cmtSZXBseUhhbmRsZXIuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3Jr UmVwbHlIYW5kbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlFOZXR3b3JrUmVwbHlIYW5kbGVy OjpyZWxlYXNlKTogbm90IHNldCBtX3JlcGx5IHRvIDAgYmVjYXVzZSBkZWxldGVMYXRlciB3aWxs CisgICAgICAgIGJlIHVuZWZmZWN0aXZlIGxhdGVyIChpbiBmaW5pc2gpIGlmIHdlIGRvIGl0CisK IDIwMDktMDMtMzEgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJv bGxlZCBvdXQgdGhhdCBsYXN0IGNoYW5nZSB1bnRpbCBJIGNhbiBpbnZlc3RpZ2F0ZSB0aGUgcmVn cmVzc2lvbiB0ZXN0IGZhaWx1cmVzIGl0IHNlZW1zCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvcXQvUU5ldHdvcmtSZXBseUhhbmRsZXIuY3BwIGIvV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5kbGVyLmNwcAppbmRleCAyYzczMGE2Li45MGUx Yzk1IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvcXQvUU5ldHdvcmtSZXBs eUhhbmRsZXIuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9RTmV0d29ya1Jl cGx5SGFuZGxlci5jcHAKQEAgLTE4Nyw3ICsxODcsNiBAQCBRTmV0d29ya1JlcGx5KiBRTmV0d29y a1JlcGx5SGFuZGxlcjo6cmVsZWFzZSgpCiAgICAgICAgIC8vIHBvc3RlZCBtZXRhIGNhbGwgZXZl bnRzIHRoYXQgd2VyZSB0aGUgcmVzdWx0IG9mIGEgc2lnbmFsIGVtaXNzaW9uCiAgICAgICAgIC8v IGRvbid0IHJlYWNoIHRoZSBzbG90cyBpbiBvdXIgaW5zdGFuY2UuCiAgICAgICAgIFFDb3JlQXBw bGljYXRpb246OnJlbW92ZVBvc3RlZEV2ZW50cyh0aGlzLCBRRXZlbnQ6Ok1ldGFDYWxsKTsKLSAg ICAgICAgbV9yZXBseSA9IDA7CiAgICAgfQogICAgIHJldHVybiByZXBseTsKIH0K 29330 2009-04-08 05:49:06 -0700 2009-04-22 04:59:33 -0700 proposed patch tomiugyes2.diff text/plain 1079 Szirbucz.Tamas ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MmNhZTAwMy4uNjNlYzhmMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0wNC0wOCAgVGFtYXMgU3ppcmJ1 Y3ogIDxzemlyYnVjei50YW1hc0BzdHVkLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZyZWUgcmVwbHkgaW4gUU5ldHdvcmtSZXBs eUhhbmRsZXI6OmFib3J0LgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9xdC9RTmV0d29y a1JlcGx5SGFuZGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpRTmV0d29ya1JlcGx5SGFuZGxl cjo6YWJvcnQpOiBDYWxsIGRlbGV0ZUxhdGVyIG9uIHRoZSBRTmV0V29ya1JlcGx5IHdoYXQgd2UK KyAgICAgICAgZ2V0IGZyb20gcmVsZWFzZSBiZWNhdXNlIG90aGVyd2lzZSBpdCB3b3VsZCBiZSBs ZWFraW5nLgorCiAyMDA5LTA0LTA2ICBNaWtlIEJlbHNoZSA8bWlrZUBiZWxzaGUuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0 Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5kbGVyLmNwcCBiL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9xdC9RTmV0d29ya1JlcGx5SGFuZGxlci5jcHAKaW5kZXggMmM3MzBhNi4uM2U5 YjIzOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVw bHlIYW5kbGVyLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvcXQvUU5ldHdvcmtS ZXBseUhhbmRsZXIuY3BwCkBAIC0xNzQsNiArMTc0LDcgQEAgdm9pZCBRTmV0d29ya1JlcGx5SGFu ZGxlcjo6YWJvcnQoKQogICAgIGlmIChtX3JlcGx5KSB7CiAgICAgICAgIFFOZXR3b3JrUmVwbHkq IHJlcGx5ID0gcmVsZWFzZSgpOwogICAgICAgICByZXBseS0+YWJvcnQoKTsKKyAgICAgICAgcmVw bHktPmRlbGV0ZUxhdGVyKCk7CiAgICAgICAgIGRlbGV0ZUxhdGVyKCk7CiAgICAgfQogfQo=