250149 2023-01-05 14:01:40 -0800 Add plumbing for Gamepad.vibrationActuator support 2023-01-06 16:28:04 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 248989 1 cdumez mcatanzaro mcatanzaro webkit-bug-importer oldest_to_newest 1923274 0 cdumez 2023-01-05 14:01:40 -0800 Add plumbing for Gamepad.vibrationActuator support: - https://w3c.github.io/gamepad/extensions.html#dom-gamepadhapticactuator 1923275 1 cdumez 2023-01-05 14:17:49 -0800 Pull request: https://github.com/WebKit/WebKit/pull/8251 1923595 2 ews-feeder 2023-01-06 13:57:03 -0800 Committed 258559@main (7203ee047b6c): <https://commits.webkit.org/258559@main> Reviewed commits have been landed. Closing PR #8251 and removing active labels. 1923596 3 webkit-bug-importer 2023-01-06 13:58:16 -0800 <rdar://problem/103966957> 1923640 4 mcatanzaro 2023-01-06 16:05:05 -0800 Looks like this broke the GTK build: /home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/gamepad/EmptyGamepadProvider.cpp: In member function ‘virtual void WebCore::EmptyGamepadProvider::playEffect(unsigned int, const WTF::String&, WebCore::GamepadHapticEffectType, const WebCore::GamepadEffectParameters&, WTF::CompletionHandler<void(bool)>&&)’: /home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/gamepad/EmptyGamepadProvider.cpp:52:22: error: no match for call to ‘(WTF::CompletionHandler<void(bool)>) (bool)’ 52 | completionHandler(false); | ~~~~~~~~~~~~~~~~~^~~~~~~ /home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/gamepad/EmptyGamepadProvider.cpp: In member function ‘virtual void WebCore::EmptyGamepadProvider::stopEffects(unsigned int, const WTF::String&, WTF::CompletionHandler<void()>&&)’: /home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/gamepad/EmptyGamepadProvider.cpp:57:22: error: no match for call to ‘(WTF::CompletionHandler<void()>) ()’ 57 | completionHandler(); | ~~~~~~~~~~~~~~~~~^~ The code *looks* correct, though... 1923645 5 cdumez 2023-01-06 16:11:22 -0800 (In reply to Michael Catanzaro from comment #4) > Looks like this broke the GTK build: > > /home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/gamepad/ > EmptyGamepadProvider.cpp: In member function ‘virtual void > WebCore::EmptyGamepadProvider::playEffect(unsigned int, const WTF::String&, > WebCore::GamepadHapticEffectType, const WebCore::GamepadEffectParameters&, > WTF::CompletionHandler<void(bool)>&&)’: > /home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/gamepad/ > EmptyGamepadProvider.cpp:52:22: error: no match for call to > ‘(WTF::CompletionHandler<void(bool)>) (bool)’ > 52 | completionHandler(false); > | ~~~~~~~~~~~~~~~~~^~~~~~~ > /home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/gamepad/ > EmptyGamepadProvider.cpp: In member function ‘virtual void > WebCore::EmptyGamepadProvider::stopEffects(unsigned int, const WTF::String&, > WTF::CompletionHandler<void()>&&)’: > /home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/gamepad/ > EmptyGamepadProvider.cpp:57:22: error: no match for call to > ‘(WTF::CompletionHandler<void()>) ()’ > 57 | completionHandler(); > | ~~~~~~~~~~~~~~~~~^~ > > The code *looks* correct, though... Maybe we need to include <wtf/CompletionHandler.h> inside EmptyGamepadProvider.cpp. Would you be able to try? 1923650 6 mcatanzaro 2023-01-06 16:16:03 -0800 I had the same idea. Pretty sure it worked: my build is nearly done.... 1923654 7 mcatanzaro 2023-01-06 16:21:47 -0800 Yes, that works. 1923659 8 mcatanzaro 2023-01-06 16:24:23 -0800 Re-opening for pull request https://github.com/WebKit/WebKit/pull/8331 1923662 9 ews-feeder 2023-01-06 16:27:57 -0800 Committed 258578@main (3383a19ab4f9): <https://commits.webkit.org/258578@main> Reviewed commits have been landed. Closing PR #8331 and removing active labels.