250126 2023-01-05 04:55:50 -0800 RELEASE_ASSERT_NOT_REACHED in AccessibilityObjectAtspi::role() with MathML scripts 2023-01-16 23:28:49 -0800 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fred.wang fred.wang andresg_22 cgarcia jdiggs webkit-bug-importer oldest_to_newest 1923127 0 464346 fred.wang 2023-01-05 04:55:50 -0800 Created attachment 464346 Reduced testcase Original repro: Open https://www.mathjax.org/#samples and click the select element to change the rendering mode. Attached is a testcase reduced with the help of lithium, which involves munder/mover/munderover elements. We are reaching the following assert: https://searchfox.org/wubkat/source/Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp#393 Per https://w3c.github.io/mathml-aam/ AccessibilityObjectAtspi::effectiveRole() should return Atspi::Role::Section for isMathUnderOver(). Here is a simple fix: diff --git a/Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp b/Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp index 0a869b206589..afaf6b9b0fb7 100644 --- a/Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp +++ b/Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp @@ -1225,7 +1225,7 @@ std::optional<unsigned> AccessibilityObjectAtspi::effectiveRole() const return Atspi::Role::TableRow; if (m_coreObject->isMathTableCell()) return Atspi::Role::TableCell; - if (m_coreObject->isMathSubscriptSuperscript() || m_coreObject->isMathMultiscript()) + if (m_coreObject->isMathUnderOver() || m_coreObject->isMathSubscriptSuperscript() || m_coreObject->isMathMultiscript()) return Atspi::Role::Section; if (m_coreObject->isMathFraction()) return Atspi::Role::MathFraction; 1923128 1 webkit-bug-importer 2023-01-05 04:56:04 -0800 <rdar://problem/103909843> 1923140 2 fred.wang 2023-01-05 07:03:43 -0800 Pull request: https://github.com/WebKit/WebKit/pull/8234 1925931 3 ews-feeder 2023-01-16 23:28:47 -0800 Committed 258971@main (c7e23e3505d3): <https://commits.webkit.org/258971@main> Reviewed commits have been landed. Closing PR #8234 and removing active labels. 464346 2023-01-05 04:55:50 -0800 2023-01-05 04:55:50 -0800 Reduced testcase a.html text/html 276 fred.wang PCFET0NUWVBFPgoKPHA+Q2xpY2sgYW55IG9mIHRoZXNlIGVsZW1lbnRzOjwvcD4KCjxtYXRoPgog IDxtdW5kZXI+CiAgICA8bW4+MDwvbW4+CiAgICA8bW4+MTwvbW4+CiAgPC9tdW5kZXI+CjwvbWF0 aD4KCjxtYXRoPgogIDxtb3Zlcj4KICAgIDxtbj4wPC9tbj4KICAgIDxtbj4xPC9tbj4KICA8L21v dmVyPgo8L21hdGg+Cgo8bWF0aD4KICA8bXVuZGVyb3Zlcj4KICAgIDxtbj4wPC9tbj4KICAgIDxt bj4xPC9tbj4KICAgIDxtbj4yPC9tbj4KICA8L211bmRlcm92ZXI+CjwvbWF0aD4K