250106 2023-01-04 14:38:15 -0800 Remove <!-- webkit-test-runner --> modeline from imported tests 2023-01-11 14:39:16 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 247926 1 emw webkit-unassigned bfulgham ntim webkit-bug-importer oldest_to_newest 1922993 0 emw 2023-01-04 14:38:15 -0800 We shouldn't export the <!-- webkit-test-runner --> control statements to WPT. Instead, let's mark features WPT uses as `testable`, or mark the tests as expected to fail. Moreover, I'd argue that we should avoid testing WPT using feature flags that are only turned on by our CI infra, so that our CI's ability to pass tests is reflective of WebKit's public WPT score. 1922997 1 bfulgham 2023-01-04 15:00:55 -0800 I think it's reasonable for us to have 'testable' features that run WPT locally to help us avoid regression bits of a feature that work while trying to complete other work. If we think the feature is usable, we would make it 'preview', and it should show in STP scores for WPT. Once it's on-by-default it would show in stable scores for WPT. I think this is a good idea to avoid artificial differences in WPT results, and to avoid modifying WPT tests as much as possible. 1922999 2 ntim 2023-01-04 15:03:26 -0800 I think the problem here is that if we don't export those changes, they get overriden next time someone imports. 1923000 3 bfulgham 2023-01-04 15:12:28 -0800 Right -- what I'm saying is that we should ditch the special comment, and just mark relevant features as 'testable' (just as Elliott suggested in this bug). 1924014 4 ntim 2023-01-09 02:03:54 -0800 Yeah that sounds reasonable. 1924894 5 webkit-bug-importer 2023-01-11 14:39:16 -0800 <rdar://problem/104140583>