250094 2023-01-04 11:36:57 -0800 run-jsc with the --debugger option should work with SIP enabled 2023-01-19 11:57:42 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 keith_miller keith_miller ap webkit-bug-importer oldest_to_newest 1922919 0 keith_miller 2023-01-04 11:36:57 -0800 run-jsc with the --debugger option should work with SIP enabled 1922920 1 464332 keith_miller 2023-01-04 11:37:26 -0800 Created attachment 464332 Patch 1922947 2 464332 ap 2023-01-04 12:48:59 -0800 Comment on attachment 464332 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=464332&action=review This somehow lacks a commit message? > Tools/Scripts/run-jsc:56 > $jsc = $debuggerCmd . " " . File::Spec->catfile(jscProductDir(), "jsc -- --useDollarVM=1 ") . "@ARGV"; Huh, this is not nice. "jsc -- --useDollarVM=1 " is not a path component. I'd suggest improving this line while at it. > Tools/Scripts/run-jsc:62 > $ENV{"DYLD_FRAMEWORK_PATH"} = $dyld; Is this still needed? 1923521 3 464332 keith_miller 2023-01-06 09:27:27 -0800 Comment on attachment 464332 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=464332&action=review >> Tools/Scripts/run-jsc:56 >> $jsc = $debuggerCmd . " " . File::Spec->catfile(jscProductDir(), "jsc -- --useDollarVM=1 ") . "@ARGV"; > > Huh, this is not nice. "jsc -- --useDollarVM=1 " is not a path component. I'd suggest improving this line while at it. Yeah, that's kinda weird. I'll fix. >> Tools/Scripts/run-jsc:62 >> $ENV{"DYLD_FRAMEWORK_PATH"} = $dyld; > > Is this still needed? I left it in case you have a custom debugger you want to use. It's also needed for the non-debugger case. Really though, I wanna know if there's a way to have the jsc binary specify where to find the library. 1923547 4 ap 2023-01-06 10:46:27 -0800 > Really though, I wanna know if there's a way to have the jsc binary specify where to find the library. Technically, there's @rpath that can be embedded in Mach-O loader commands (`otool -l` to see those in existing binaries). That would be tricky, as I don't think that jsc is always at the same relative path to the framework in all CI and development scenarios. I think that your approach in this patch is better. 1926375 5 keith_miller 2023-01-18 12:54:45 -0800 Pull request: https://github.com/WebKit/WebKit/pull/8789 1926686 6 ews-feeder 2023-01-19 11:57:39 -0800 Committed 259103@main (0e5741eb7500): <https://commits.webkit.org/259103@main> Reviewed commits have been landed. Closing PR #8789 and removing active labels. 464332 2023-01-04 11:37:26 -0800 2023-01-04 17:25:52 -0800 Patch bug-250094-20230104143725.patch text/plain 908 keith_miller ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcnVuLWpzYyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWpz YwppbmRleCAxNmQ4ZThmZThkYzVmNzZmMjZlNDIwOGI1NDBlNjhiYjlhMWY0YTI3Li42MWFkMmQ1 Y2I1MDZiZmFhNGVmZjU5ZDU0MWZmZTJmZWE2NWJiMDA1IDEwMDc1NQotLS0gYS9Ub29scy9TY3Jp cHRzL3J1bi1qc2MKKysrIGIvVG9vbHMvU2NyaXB0cy9ydW4tanNjCkBAIC00OSwxNSArNDksMTUg QEAgR2V0T3B0aW9ucygiZGVidWdnZXIiID0+IFwkZGVidWdnZXIpOwogCiBzZXRDb25maWd1cmF0 aW9uKCk7CiAKK215ICRkeWxkID0ganNjUHJvZHVjdERpcigpOwogbXkgJGpzYzsKIGlmICgkZGVi dWdnZXIpIHsKLSAgICBteSAkZGVidWdnZXJDbWQgPSBkZWZpbmVkKCRFTlZ7IkRFQlVHR0VSIn0p ID8gJEVOVnsiREVCVUdHRVIifSA6ICJsbGRiIjsKKyAgICBteSAkZGVidWdnZXJDbWQgPSBkZWZp bmVkKCRFTlZ7IkRFQlVHR0VSIn0pID8gJEVOVnsiREVCVUdHRVIifSA6ICJsbGRiIC0tb25lLWxp bmUgJ2VudiBEWUxEX0ZSQU1FV09SS19QQVRIPSIgLiAkZHlsZCAuICInIjsKICAgICAkanNjID0g JGRlYnVnZ2VyQ21kIC4gIiAiIC4gRmlsZTo6U3BlYy0+Y2F0ZmlsZShqc2NQcm9kdWN0RGlyKCks ICJqc2MgLS0gLS11c2VEb2xsYXJWTT0xICIpIC4gIkBBUkdWIjsKIH0gZWxzZSB7CiAgICAgJGpz YyA9IEZpbGU6OlNwZWMtPmNhdGZpbGUoanNjUHJvZHVjdERpcigpLCAianNjIC0tdXNlRG9sbGFy Vk09MSAiKSAuICJAQVJHViI7CiB9CiAKLW15ICRkeWxkID0ganNjUHJvZHVjdERpcigpOwogCiAk RU5WeyJEWUxEX0ZSQU1FV09SS19QQVRIIn0gPSAkZHlsZDsKIHByaW50IFNUREVSUiAiUnVubmlu ZyAkY291bnQgdGltZShzKTogRFlMRF9GUkFNRVdPUktfUEFUSD0kZHlsZCAkanNjXG4iOwo=