25005 2009-04-02 10:49:12 -0700 Upstream V8WorkerContextObjectEventListener for V8 bindings. 2009-04-02 14:35:23 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jianli jianli dglazkov oldest_to_newest 116316 0 jianli 2009-04-02 10:49:12 -0700 Upstream V8WorkerContextObjectEventListener for V8 bindings. 116318 1 29200 jianli 2009-04-02 10:56:43 -0700 Created attachment 29200 Proposed Patch 116338 2 29200 fishd 2009-04-02 13:10:46 -0700 Comment on attachment 29200 Proposed Patch > +++ b/WebCore/bindings/v8/V8WorkerContextObjectEventListener.cpp > +#if ENABLE(WORKERS) > + > +#include "V8WorkerContextObjectEventListener.h" > + > +#include "WorkerContextExecutionProxy.h" nit: gratuitous new line between those two includes? otherwise, R+ 116345 3 jianli 2009-04-02 13:34:28 -0700 (In reply to comment #2) > (From update of attachment 29200 [review]) > > +++ b/WebCore/bindings/v8/V8WorkerContextObjectEventListener.cpp > > +#if ENABLE(WORKERS) > > + > > +#include "V8WorkerContextObjectEventListener.h" > > + > > +#include "WorkerContextExecutionProxy.h" > > nit: gratuitous new line between those two includes? > > > otherwise, R+ > Do we need additional new line between header file for itself and all other included files? It seems that other WebKit files are doing like this. 116352 4 dimich 2009-04-02 14:35:23 -0700 Landed: http://trac.webkit.org/changeset/42185 29200 2009-04-02 10:56:43 -0700 2009-04-02 13:10:46 -0700 Proposed Patch 25005 text/plain 6057 jianli ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDZiZjQ3Yi4uYmExMWY4NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0wNC0wMiAgSmlhbiBMaSAgPGpp YW5saUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVXBzdHJlYW0gVjhXb3JrZXJDb250ZXh0T2JqZWN0RXZlbnRMaXN0ZW5lciBm b3IgVjggYmluZGluZ3MuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yNTAwNQorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhXb3JrZXJDb250ZXh0T2Jq ZWN0RXZlbnRMaXN0ZW5lci5jcHA6IEFkZGVkLgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4V29y a2VyQ29udGV4dE9iamVjdEV2ZW50TGlzdGVuZXIuaDogQWRkZWQuCisKIDIwMDktMDQtMDEgIEJl biBNdXJkb2NoICA8YmVubUBnb29nbGUuY29tPgogCiAgICAgICAgIEZpeCBCdWcgMTk3NDM6IFJl bGVhc2UgYnVpbGQgZmFpbHMgb24gMzItYml0IFdpbmRvd3MKZGlmZiAtLWdpdCBhL1dlYkNvcmUv YmluZGluZ3MvdjgvVjhXb3JrZXJDb250ZXh0T2JqZWN0RXZlbnRMaXN0ZW5lci5jcHAgYi9XZWJD b3JlL2JpbmRpbmdzL3Y4L1Y4V29ya2VyQ29udGV4dE9iamVjdEV2ZW50TGlzdGVuZXIuY3BwCm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmJlYzI1ZjEKLS0tIC9kZXYvbnVsbAor KysgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4V29ya2VyQ29udGV4dE9iamVjdEV2ZW50TGlzdGVu ZXIuY3BwCkBAIC0wLDAgKzEsNTkgQEAKKy8qCisgKiBDb3B5cmlnaHQgKEMpIDIwMDkgR29vZ2xl IEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqCisgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNl IGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKKyAqIG1vZGlmaWNh dGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9u cyBhcmUKKyAqIG1ldDoKKyAqCisgKiAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNv ZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorICogbm90aWNlLCB0aGlzIGxpc3Qg b2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorICogICAgICogUmVk aXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZQorICog Y29weXJpZ2h0IG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dp bmcgZGlzY2xhaW1lcgorICogaW4gdGhlIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVy aWFscyBwcm92aWRlZCB3aXRoIHRoZQorICogZGlzdHJpYnV0aW9uLgorICogICAgICogTmVpdGhl ciB0aGUgbmFtZSBvZiBHb29nbGUgSW5jLiBub3IgdGhlIG5hbWVzIG9mIGl0cworICogY29udHJp YnV0b3JzIG1heSBiZSB1c2VkIHRvIGVuZG9yc2Ugb3IgcHJvbW90ZSBwcm9kdWN0cyBkZXJpdmVk IGZyb20KKyAqIHRoaXMgc29mdHdhcmUgd2l0aG91dCBzcGVjaWZpYyBwcmlvciB3cml0dGVuIHBl cm1pc3Npb24uCisgKgorICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBUSEUgQ09QWVJJ R0hUIEhPTERFUlMgQU5EIENPTlRSSUJVVE9SUworICogIkFTIElTIiBBTkQgQU5ZIEVYUFJFU1Mg T1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QKKyAqIExJTUlURUQgVE8s IFRIRSBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZP UgorICogQSBQQVJUSUNVTEFSIFBVUlBPU0UgQVJFIERJU0NMQUlNRUQuIElOIE5PIEVWRU5UIFNI QUxMIFRIRSBDT1BZUklHSFQKKyAqIE9XTkVSIE9SIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9S IEFOWSBESVJFQ1QsIElORElSRUNULCBJTkNJREVOVEFMLAorICogU1BFQ0lBTCwgRVhFTVBMQVJZ LCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMgKElOQ0xVRElORywgQlVUIE5PVAorICogTElNSVRF RCBUTywgUFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBHT09EUyBPUiBTRVJWSUNFUzsgTE9TUyBP RiBVU0UsCisgKiBEQVRBLCBPUiBQUk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhP V0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkKKyAqIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIg SU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQKKyAqIChJTkNMVURJTkcgTkVH TElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQor ICogT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBP RiBTVUNIIERBTUFHRS4KKyAqLworCisjaW5jbHVkZSAiY29uZmlnLmgiCisKKyNpZiBFTkFCTEUo V09SS0VSUykKKworI2luY2x1ZGUgIlY4V29ya2VyQ29udGV4dE9iamVjdEV2ZW50TGlzdGVuZXIu aCIKKworI2luY2x1ZGUgIldvcmtlckNvbnRleHRFeGVjdXRpb25Qcm94eS5oIgorCituYW1lc3Bh Y2UgV2ViQ29yZSB7CisKK3N0YXRpYyB2b2lkIHdlYWtPYmplY3RFdmVudExpc3RlbmVyQ2FsbGJh Y2sodjg6OlBlcnNpc3RlbnQ8djg6OlZhbHVlPiwgdm9pZCogcGFyYW1ldGVyKQoreworICAgIFY4 V29ya2VyQ29udGV4dE9iamVjdEV2ZW50TGlzdGVuZXIqIGxpc3RlbmVyID0gc3RhdGljX2Nhc3Q8 VjhXb3JrZXJDb250ZXh0T2JqZWN0RXZlbnRMaXN0ZW5lcio+KHBhcmFtZXRlcik7CisKKyAgICAv LyBSZW1vdmUgdGhlIHdyYXBwZXIKKyAgICBsaXN0ZW5lci0+cHJveHkoKS0+UmVtb3ZlRXZlbnRM aXN0ZW5lcihsaXN0ZW5lcik7CisKKyAgICBsaXN0ZW5lci0+ZGlzcG9zZUxpc3RlbmVyT2JqZWN0 KCk7Cit9CisKK1Y4V29ya2VyQ29udGV4dE9iamVjdEV2ZW50TGlzdGVuZXI6OlY4V29ya2VyQ29u dGV4dE9iamVjdEV2ZW50TGlzdGVuZXIoV29ya2VyQ29udGV4dEV4ZWN1dGlvblByb3h5KiBwcm94 eSwgdjg6OkxvY2FsPHY4OjpPYmplY3Q+IGxpc3RlbmVyLCBib29sIGlzSW5saW5lKQorICAgIDog VjhXb3JrZXJDb250ZXh0RXZlbnRMaXN0ZW5lcihwcm94eSwgbGlzdGVuZXIsIGlzSW5saW5lKQor eworICAgIG1fbGlzdGVuZXIuTWFrZVdlYWsodGhpcywgd2Vha09iamVjdEV2ZW50TGlzdGVuZXJD YWxsYmFjayk7Cit9CisKK30gLy8gbmFtZXNwYWNlIFdlYkNvcmUKKworI2VuZGlmIC8vIFdPUktF UlMKZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhXb3JrZXJDb250ZXh0T2JqZWN0 RXZlbnRMaXN0ZW5lci5oIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFdvcmtlckNvbnRleHRPYmpl Y3RFdmVudExpc3RlbmVyLmgKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uNjQ3 MTYzNwotLS0gL2Rldi9udWxsCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhXb3JrZXJDb250 ZXh0T2JqZWN0RXZlbnRMaXN0ZW5lci5oCkBAIC0wLDAgKzEsNTkgQEAKKy8qCisgKiBDb3B5cmln aHQgKEMpIDIwMDkgR29vZ2xlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqCisgKiBSZWRp c3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdp dGhvdXQKKyAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBm b2xsb3dpbmcgY29uZGl0aW9ucyBhcmUKKyAqIG1ldDoKKyAqCisgKiAgICAgKiBSZWRpc3RyaWJ1 dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorICog bm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFp bWVyLgorICogICAgICogUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9k dWNlIHRoZSBhYm92ZQorICogY29weXJpZ2h0IG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlv bnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lcgorICogaW4gdGhlIGRvY3VtZW50YXRpb24g YW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZQorICogZGlzdHJpYnV0aW9u LgorICogICAgICogTmVpdGhlciB0aGUgbmFtZSBvZiBHb29nbGUgSW5jLiBub3IgdGhlIG5hbWVz IG9mIGl0cworICogY29udHJpYnV0b3JzIG1heSBiZSB1c2VkIHRvIGVuZG9yc2Ugb3IgcHJvbW90 ZSBwcm9kdWN0cyBkZXJpdmVkIGZyb20KKyAqIHRoaXMgc29mdHdhcmUgd2l0aG91dCBzcGVjaWZp YyBwcmlvciB3cml0dGVuIHBlcm1pc3Npb24uCisgKgorICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9W SURFRCBCWSBUSEUgQ09QWVJJR0hUIEhPTERFUlMgQU5EIENPTlRSSUJVVE9SUworICogIkFTIElT IiBBTkQgQU5ZIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBO T1QKKyAqIExJTUlURUQgVE8sIFRIRSBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklM SVRZIEFORCBGSVRORVNTIEZPUgorICogQSBQQVJUSUNVTEFSIFBVUlBPU0UgQVJFIERJU0NMQUlN RUQuIElOIE5PIEVWRU5UIFNIQUxMIFRIRSBDT1BZUklHSFQKKyAqIE9XTkVSIE9SIENPTlRSSUJV VE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElSRUNULCBJTkNJREVOVEFMLAorICog U1BFQ0lBTCwgRVhFTVBMQVJZLCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMgKElOQ0xVRElORywg QlVUIE5PVAorICogTElNSVRFRCBUTywgUFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBHT09EUyBP UiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsCisgKiBEQVRBLCBPUiBQUk9GSVRTOyBPUiBCVVNJTkVT UyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkKKyAqIFRIRU9SWSBPRiBM SUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQK KyAqIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdB WSBPVVQgT0YgVEhFIFVTRQorICogT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9G IFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KKyAqLworCisjaWZuZGVmIFY4V29ya2Vy Q29udGV4dE9iamVjdEV2ZW50TGlzdGVuZXJfaAorI2RlZmluZSBWOFdvcmtlckNvbnRleHRPYmpl Y3RFdmVudExpc3RlbmVyX2gKKworI2lmIEVOQUJMRShXT1JLRVJTKQorCisjaW5jbHVkZSAiVjhX b3JrZXJDb250ZXh0RXZlbnRMaXN0ZW5lci5oIgorI2luY2x1ZGUgPHY4Lmg+CisjaW5jbHVkZSA8 d3RmL1Bhc3NSZWZQdHIuaD4KKworbmFtZXNwYWNlIFdlYkNvcmUgeworCisgICAgY2xhc3MgV29y a2VyQ29udGV4dEV4ZWN1dGlvblByb3h5OworCisgICAgY2xhc3MgVjhXb3JrZXJDb250ZXh0T2Jq ZWN0RXZlbnRMaXN0ZW5lciA6IHB1YmxpYyBWOFdvcmtlckNvbnRleHRFdmVudExpc3RlbmVyIHsK KyAgICBwdWJsaWM6CisgICAgICAgIHN0YXRpYyBQYXNzUmVmUHRyPFY4V29ya2VyQ29udGV4dE9i amVjdEV2ZW50TGlzdGVuZXI+IGNyZWF0ZShXb3JrZXJDb250ZXh0RXhlY3V0aW9uUHJveHkqIHBy b3h5LCB2ODo6TG9jYWw8djg6Ok9iamVjdD4gbGlzdGVuZXIsIGJvb2wgaXNJbmxpbmUpCisgICAg ICAgIHsKKyAgICAgICAgICAgIHJldHVybiBhZG9wdFJlZihuZXcgVjhXb3JrZXJDb250ZXh0T2Jq ZWN0RXZlbnRMaXN0ZW5lcihwcm94eSwgbGlzdGVuZXIsIGlzSW5saW5lKSk7CisgICAgICAgIH0K KworICAgIHByaXZhdGU6CisgICAgICAgIFY4V29ya2VyQ29udGV4dE9iamVjdEV2ZW50TGlzdGVu ZXIoV29ya2VyQ29udGV4dEV4ZWN1dGlvblByb3h5Kiwgdjg6OkxvY2FsPHY4OjpPYmplY3Q+IGxp c3RlbmVyLCBib29sIGlzSW5saW5lKTsKKyAgICB9OworCit9IC8vIG5hbWVzcGFjZSBXZWJDb3Jl CisKKyNlbmRpZiAvLyBXT1JLRVJTCisKKyNlbmRpZiAvLyBWOFdvcmtlckNvbnRleHRPYmplY3RF dmVudExpc3RlbmVyX2gK