24997 2009-04-01 20:53:32 -0700 Race conditions in icon database threading code 2009-04-01 21:52:33 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 sfalken sfalken oldest_to_newest 116243 0 sfalken 2009-04-01 20:53:32 -0700 A bug was introduced in r27717 that broke the "icon database thread is running" check. This check is currently always returning false. This means we don't wait until the thread has shut down during icon database closes, and also allows the icon database to be disposed out from under the icon database thread. 116245 1 29182 sfalken 2009-04-01 20:55:58 -0700 Created attachment 29182 Set m_syncThreadRunning 116246 2 29182 oliver 2009-04-01 21:23:11 -0700 Comment on attachment 29182 Set m_syncThreadRunning r=me 116247 3 29182 oliver 2009-04-01 21:23:12 -0700 Comment on attachment 29182 Set m_syncThreadRunning r=me 116248 4 sfalken 2009-04-01 21:52:33 -0700 Fixed in r42163. 29182 2009-04-01 20:55:58 -0700 2009-04-01 21:23:11 -0700 Set m_syncThreadRunning patch.diff text/plain 1237 sfalken SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQyMTYy KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDQt MDEgIFN0ZXZlIEZhbGtlbmJ1cmcgIDxzZmFsa2VuQGFwcGxlLmNvbT4KKworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQ5OTcKKyAgICAgICAgUmFjZSBj b25kaXRpb25zIGluIGljb24gZGF0YWJhc2UgdGhyZWFkaW5nIGNvZGUKKyAgICAgICAgCisgICAg ICAgIG1fc3luY1RocmVhZFJ1bm5pbmcgc2V0IHdhcyBtaXN0YWtlbmx5IGVsaW1pbmF0ZWQgaW4g cjI3NzE3LgorICAgICAgICBUaGlzIHJlaW50cm9kdWNlcyBpdC4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGxvYWRlci9pY29uL0ljb25EYXRhYmFz ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJY29uRGF0YWJhc2U6Om9wZW4pOiBTZXQgbV9zeW5j VGhyZWFkUnVubmluZy4KKwogMjAwOS0wNC0wMSAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBs ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBsb2FkZXIv aWNvbi9JY29uRGF0YWJhc2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGxvYWRlci9pY29uL0ljb25EYXRh YmFzZS5jcHAJKHJldmlzaW9uIDQyMTUwKQorKysgbG9hZGVyL2ljb24vSWNvbkRhdGFiYXNlLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTUwLDYgKzE1MCw3IEBAIGJvb2wgSWNvbkRhdGFiYXNlOjpv cGVuKGNvbnN0IFN0cmluZyYgZGEKICAgICAvLyBjb21wbGV0ZXMgYW5kIG1fc3luY1RocmVhZFJ1 bm5pbmcgaXMgcHJvcGVybHkgc2V0CiAgICAgbV9zeW5jTG9jay5sb2NrKCk7CiAgICAgbV9zeW5j VGhyZWFkID0gY3JlYXRlVGhyZWFkKEljb25EYXRhYmFzZTo6aWNvbkRhdGFiYXNlU3luY1RocmVh ZFN0YXJ0LCB0aGlzLCAiV2ViQ29yZTogSWNvbkRhdGFiYXNlIik7CisgICAgbV9zeW5jVGhyZWFk UnVubmluZyA9IG1fc3luY1RocmVhZDsKICAgICBtX3N5bmNMb2NrLnVubG9jaygpOwogICAgIGlm ICghbV9zeW5jVGhyZWFkKQogICAgICAgICByZXR1cm4gZmFsc2U7Cg==