24993 2009-04-01 14:33:53 -0700 Standalone media should use a smaller intrinsic height 2009-04-01 17:58:37 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 dino webkit-unassigned cmarrin eric.carlson simon.fraser oldest_to_newest 116222 0 dino 2009-04-01 14:33:53 -0700 Standalone media documents use a <video> element to play all media. In the case of audio, this should not use the default intrinsic height of 150. This came up as a bug report from someone who was opening audio files in popup windows that were 100px high, and thus the controls were not visible. By setting the intrinsic height for all media on standalone documents to 0 (actually 1, see patch comments) everything works ok. Video gets resized to its native dimensions when the video loads. <rdar://problem/6458142> REGRESSION: Audio files have misplaced control bars (20687) 116223 1 29179 dino 2009-04-01 14:37:35 -0700 Created attachment 29179 patch for standalone audio fix 116239 2 dino 2009-04-01 17:58:37 -0700 Committed r42159 M WebCore/ChangeLog M WebCore/rendering/RenderVideo.cpp 29179 2009-04-01 14:37:35 -0700 2009-04-01 14:39:49 -0700 patch for standalone audio fix audio.patch text/plain 1744 dino ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NWJhZTAxNi4uNDc1ZjdkNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0wNC0wMSAgRGVhbiBKYWNrc29u ICA8ZGlub0BhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0OTkz CisKKyAgICAgICAgU3RhbmRhbG9uZSBtZWRpYSBzaG91bGQgaGF2ZSBhIHNtYWxsZXIgaW5zdHJp bnNpYworICAgICAgICBoZWlnaHQuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVmlkZW8u Y3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVmlkZW86OlJlbmRlclZpZGVvKToKKwogMjAw OS0wMy0zMSAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgU3R5bGUg Z3VpZGUgdmlvbGF0aW9uIQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlk ZW8uY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlkZW8uY3BwCmluZGV4IGQ2ZTk4ZTcu LjdhOGFhNzggMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclZpZGVvLmNwcAor KysgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJWaWRlby5jcHAKQEAgLTQxLDkgKzQxLDI0IEBA IG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogdXNpbmcgbmFtZXNwYWNlIEhUTUxOYW1lczsKIAorY29u c3QgaW50IGNEZWZhdWx0V2lkdGggPSAzMDA7Citjb25zdCBpbnQgY0RlZmF1bHRIZWlnaHQgPSAx NTA7CisKIFJlbmRlclZpZGVvOjpSZW5kZXJWaWRlbyhIVE1MTWVkaWFFbGVtZW50KiB2aWRlbykK LSAgICA6IFJlbmRlck1lZGlhKHZpZGVvLCB2aWRlby0+cGxheWVyKCkgPyB2aWRlby0+cGxheWVy KCktPm5hdHVyYWxTaXplKCkgOiBJbnRTaXplKDMwMCwgMTUwKSkKKyAgICA6IFJlbmRlck1lZGlh KHZpZGVvKQogeworICAgIGlmICh2aWRlby0+cGxheWVyKCkpCisgICAgICAgIHNldEludHJpbnNp Y1NpemUodmlkZW8tPnBsYXllcigpLT5uYXR1cmFsU2l6ZSgpKTsKKyAgICBlbHNlIHsKKyAgICAg ICAgLy8gVmlkZW8gaW4gc3RhbmRhbG9uZSBtZWRpYSBkb2N1bWVudHMgc2hvdWxkIG5vdCB1c2Ug dGhlIGRlZmF1bHQgMzAweDE1MAorICAgICAgICAvLyBzaXplIHNpbmNlIHRoZXkgYWxzbyBoYXZl IGF1ZGlvIHRocm93biBhdCB0aGVtLiBCeSBzZXR0aW5nIHRoZSBpbnRyaW5zaWMKKyAgICAgICAg Ly8gc2l6ZSB0byAzMDB4MSB0aGUgdmlkZW8gd2lsbCByZXNpemUgaXRzZWxmIGluIHRoZXNlIGNh c2VzLCBhbmQgYXVkaW8gd2lsbAorICAgICAgICAvLyBoYXZlIHRoZSBjb3JyZWN0IGhlaWdodCAo aXQgbmVlZHMgdG8gYmUgPiAwIGZvciBjb250cm9scyB0byByZW5kZXIgcHJvcGVybHkpLgorICAg ICAgICBpZiAodmlkZW8tPm93bmVyRG9jdW1lbnQoKSAmJiB2aWRlby0+b3duZXJEb2N1bWVudCgp LT5pc01lZGlhRG9jdW1lbnQoKSkKKyAgICAgICAgICAgIHNldEludHJpbnNpY1NpemUoSW50U2l6 ZShjRGVmYXVsdFdpZHRoLCAxKSk7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIHNldEludHJp bnNpY1NpemUoSW50U2l6ZShjRGVmYXVsdFdpZHRoLCBjRGVmYXVsdEhlaWdodCkpOworICAgIH0K IH0KIAogUmVuZGVyVmlkZW86On5SZW5kZXJWaWRlbygpCg==