249785 2022-12-22 10:04:54 -0800 Hook up willStartRenderingUpdateDisplay/didCompleteRenderingUpdateDisplay for WC 2023-01-05 12:36:10 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=249750 InRadar P2 Normal --- 1 simon.fraser fujii don.olmstead fujii simon.fraser webkit-bug-importer oldest_to_newest 1921406 0 simon.fraser 2022-12-22 10:04:54 -0800 In bug 249750/258248@main I added Page:: willStartRenderingUpdateDisplay() and Page:: didCompleteRenderingUpdateDisplay(), which get called before and after the painting phase and compositing phase of a rendering update. These are used to drive web inspector's "Composite" timeline events, and will also be used for other things soon. WebKit2 clients can call these via the same-named functions on WebPage. These need hooking up for WC, at the DrawingArea level. 1922196 1 webkit-bug-importer 2022-12-29 10:05:29 -0800 <rdar://problem/103762121> 1923090 2 fujii 2023-01-04 21:26:32 -0800 258311@main (bug#249807) added another hook didCompleteRenderingFrame. https://github.com/WebKit/WebKit/commit/bf82da4c0e3bbd409f44510fa9f3d1891808d770 1923092 3 464342 fujii 2023-01-04 21:35:28 -0800 Created attachment 464342 Patch 1923242 4 ews-feeder 2023-01-05 12:36:08 -0800 Committed 258501@main (27763ea20188): <https://commits.webkit.org/258501@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 464342. 464342 2023-01-04 21:35:28 -0800 2023-01-05 12:36:09 -0800 Patch bug-249785-20230105143527.patch text/plain 1677 fujii RnJvbSA0NWRiOTY2ZjY5YjVlYjc0YzJkMTViMjljNDMzZTEyZDMyOTgwYzI2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBIaXJvbm9yaSA8SGlyb25vcmkuRnVqaWlAc29ueS5j b20+CkRhdGU6IFRodSwgNSBKYW4gMjAyMyAxNDozMDozMyArMDkwMApTdWJqZWN0OiBbUEFUQ0hd IEhvb2sgdXAKIHdpbGxTdGFydFJlbmRlcmluZ1VwZGF0ZURpc3BsYXkvZGlkQ29tcGxldGVSZW5k ZXJpbmdVcGRhdGVEaXNwbGF5IGZvciBXQwogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTI0OTc4NQoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgoqIFNvdXJjZS9X ZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL3djL0RyYXdpbmdBcmVhV0MuY3BwOgooV2ViS2l0OjpE cmF3aW5nQXJlYVdDOjp1cGRhdGVSZW5kZXJpbmcpOiBDYWxsIHdpbGxTdGFydFJlbmRlcmluZ1Vw ZGF0ZURpc3BsYXkgYmVmb3JlIHRoZSByZW5kZXJpbmcgdXBkYXRlLgooV2ViS2l0OjpEcmF3aW5n QXJlYVdDOjpkaXNwbGF5RGlkUmVmcmVzaCk6CkNhbGwgZGlkQ29tcGxldGVSZW5kZXJpbmdVcGRh dGVEaXNwbGF5IGFuZCBkaWRDb21wbGV0ZVJlbmRlcmluZ0ZyYW1lIGFmdGVyIHRoZSByZW5kZXJp bmcgdXBkYXRlLgotLS0KIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL3djL0RyYXdp bmdBcmVhV0MuY3BwIHwgNCArKysrCiAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspCgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2Uvd2MvRHJhd2luZ0Fy ZWFXQy5jcHAgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS93Yy9EcmF3aW5nQXJl YVdDLmNwcAppbmRleCBlYjdmNWRiMjc0OTguLjRlYzFkNzk4OGIzYiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2Uvd2MvRHJhd2luZ0FyZWFXQy5jcHAKKysrIGIv U291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2Uvd2MvRHJhd2luZ0FyZWFXQy5jcHAKQEAg LTIzMCw2ICsyMzAsOCBAQCB2b2lkIERyYXdpbmdBcmVhV0M6OnVwZGF0ZVJlbmRlcmluZygpCiAg ICAgbV93ZWJQYWdlLmZpbmFsaXplUmVuZGVyaW5nVXBkYXRlKGZsYWdzKTsKICAgICBtX3dlYlBh Z2UuZGlkVXBkYXRlUmVuZGVyaW5nKCk7CiAKKyAgICB3aWxsU3RhcnRSZW5kZXJpbmdVcGRhdGVE aXNwbGF5KCk7CisKICAgICBpZiAoaXNDb21wb3NpdGluZ01vZGUoKSkKICAgICAgICAgc2VuZFVw ZGF0ZUFDKCk7CiAgICAgZWxzZQpAQCAtMzcyLDYgKzM3NCw4IEBAIFJlZlB0cjxJbWFnZUJ1ZmZl cj4gRHJhd2luZ0FyZWFXQzo6Y3JlYXRlSW1hZ2VCdWZmZXIoRmxvYXRTaXplIHNpemUpCiB2b2lk IERyYXdpbmdBcmVhV0M6OmRpc3BsYXlEaWRSZWZyZXNoKCkKIHsKICAgICBtX3dhaXREaWRVcGRh dGUgPSBmYWxzZTsKKyAgICBkaWRDb21wbGV0ZVJlbmRlcmluZ1VwZGF0ZURpc3BsYXkoKTsKKyAg ICBkaWRDb21wbGV0ZVJlbmRlcmluZ0ZyYW1lKCk7CiAgICAgaWYgKG1fZm9yY2VSZXBhaW50Q29t cGxldGlvbkhhbmRsZXIpIHsKICAgICAgICAgaWYgKG1faXNGb3JjZVJlcGFpbnRDb21wbGV0aW9u SGFuZGxlckRlZmVycmVkKQogICAgICAgICAgICAgbV9pc0ZvcmNlUmVwYWludENvbXBsZXRpb25I YW5kbGVyRGVmZXJyZWQgPSBmYWxzZTsK