249771 2022-12-22 06:32:35 -0800 Fix Decimal.floor() + Decimal.ceiling() for many non-integral values 2024-06-19 22:09:46 -0700 1 1 1 Unclassified WebKit Forms Safari Technology Preview Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=106456 BrowserCompat, InRadar P2 Normal --- 1 ahmad.saleem792 webkit-unassigned akeerthi cdumez karlcow rniwa webkit-bug-importer wenson_hsieh oldest_to_newest 1921360 0 ahmad.saleem792 2022-12-22 06:32:35 -0800 Hi Team, While going through Blink's commit, I came across another failing test case: Test Case - <input type="number" min="1.3" value="1.51" step="0.2"/> ^ Try to do step-up in Safari, it will first go from 1.51 to 1.5 and then 1.7 while Chrome Canary 111 and Firefox Nightly 110 works perfectly fine. Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=162197 WebKit GitHub Source - https://github.com/WebKit/WebKit/blob/dced9d40e0ba387b976739efb45a6513be9bcd4a/Source/WebCore/platform/Decimal.cpp#L622 Just wanted to raise it so we can fix it later. Thanks! 1921646 1 ahmad.saleem792 2022-12-23 02:02:39 -0800 Manage to have testcase - will try to do PR later today - https://jsfiddle.net/mwn0jy35/ 1922171 2 webkit-bug-importer 2022-12-29 06:33:15 -0800 <rdar://problem/103759613> 1926112 3 ahmad.saleem792 2023-01-17 15:32:13 -0800 I am closing this PR for time being because I noted that we still have other pre-requisite bugs to fix in StepUp and StepDown and closing my PR for time being with following comment: '' NOTE to myself - I am going to close this PR since there are still bugs in StepUp and StepDown, which we should fix since this might be causing this to fail. So I will look into this later, once I fix other bugs. '' PR - https://github.com/WebKit/WebKit/pull/8045 2026519 4 ahmad.saleem792 2024-04-06 09:49:21 -0700 Just copying that following compiles when added to 'Decimal.cpp' (for TestWebKit API): // Simulate core/html/forms/StepRange class DecimalStepRange { public: Decimal maximum; Decimal minimum; Decimal step; DecimalStepRange(const Decimal& minimum, const Decimal& maximum, const Decimal& step) : maximum(maximum) , minimum(minimum) , step(step) { } Decimal clampValue(Decimal value) const { const Decimal result = minimum + ((value - minimum) / step).round() * step; ASSERT(result.isFinite()); return result > maximum ? result - step : result; } }; class Decimcal : public testing::Test { protected: using Sign = Decimal::Sign; static constexpr Sign positive = Decimal::Positive; static constexpr Sign negative = Decimal::Negative; Decimal encode(uint64_t coefficient, int exponent, Sign sign) { return Decimal(sign, exponent, coefficient); } Decimal fromString(const String& string) { return Decimal::fromString(string); } Decimal stepDown(const String& minimum, const String& maximum, const String& step, const String& valueString, int numberOfStepTimes) { DecimalStepRange stepRange(fromString(minimum), fromString(maximum), fromString(step)); Decimal value = fromString(valueString); for (int i = 0; i < numberOfStepTimes; ++i) { value -= stepRange.step; value = stepRange.clampValue(value); } return value; } Decimal stepUp(const String& minimum, const String& maximum, const String& step, const String& valueString, int numberOfStepTimes) { DecimalStepRange stepRange(fromString(minimum), fromString(maximum), fromString(step)); Decimal value = fromString(valueString); for (int i = 0; i < numberOfStepTimes; ++i) { value += stepRange.step; value = stepRange.clampValue(value); } return value; } }; 2042166 5 ews-feeder 2024-06-19 22:09:44 -0700 Committed 280189@main (c79f2cd50054): <https://commits.webkit.org/280189@main> Reviewed commits have been landed. Closing PR #29941 and removing active labels.