249737 2022-12-21 12:15:41 -0800 Setting outerHTML on child of DocumentFragment throws error 2023-07-15 15:06:53 -0700 1 1 1 Unclassified WebKit DOM Safari Technology Preview Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=226808 BrowserCompat, InRadar P2 Normal --- 1 nlawson webkit-unassigned ahmad.saleem792 cdumez jarhar karlcow rniwa webkit-bug-importer oldest_to_newest 1921178 0 464152 nlawson 2022-12-21 12:15:41 -0800 Created attachment 464152 Repro HTML Steps to repro: 1. Go to https://codepen.io/nolanlawson-the-selector/pen/oNMgmXe 2. Notice that it says an error was thrown Minimal repro: const fragment = new DocumentFragment() fragment.appendChild(document.createElement('div')) fragment.firstChild.outerHTML = '' In Firefox this does not throw an Error. In Safari Technology Preview Release 146 (Safari 15.4, WebKit 16614.1.14.10.6), it throws an error: > Cannot set outerHTML on element because its parent is not an Element According to the spec [1]: > If parent is a DocumentFragment, let parent be a new Element […] So it appears that Firefox is following the spec here, but Safari is not. Note that my repro tests both a DocumentFragment and a ShadowRoot. Since a ShadowRoot is an instance of DocumentFragment, neither test should throw an error. Same bug filed on Chrome: https://bugs.chromium.org/p/chromium/issues/detail?id=1403060 [1]: https://w3c.github.io/DOM-Parsing/#dom-element-outerhtml 1921614 1 karlcow 2022-12-22 22:57:04 -0800 Blink error: > Uncaught DOMException: Failed to set the 'outerHTML' property on 'Element': This element's parent is of type '#document-fragment', which is not an element node. > at <anonymous>:1:31 WebKit error: > nomodificationallowederror: Cannot set outerHTML on element because its parent is not an Element Firefox returns: '' https://searchfox.org/wubkat/rev/9ced63bbda6ac9231451b1ca549a16f397e28c78/Source/WebCore/dom/Element.cpp#3554-3589 ``` ExceptionOr<void> Element::setOuterHTML(const String& html) { // The specification allows setting outerHTML on an Element whose parent is a DocumentFragment and Gecko supports this. // However, as of June 2021, Blink matches our behavior and throws a NoModificationAllowedError for non-Element parents. RefPtr parent = parentElement(); if (UNLIKELY(!parent)) { if (!parentNode()) return Exception { NoModificationAllowedError, "Cannot set outerHTML on element because it doesn't have a parent"_s }; return Exception { NoModificationAllowedError, "Cannot set outerHTML on element because its parent is not an Element"_s }; } // … cut for brevity } ``` This was added by Chris Dumez in June 2021 https://bugs.webkit.org/show_bug.cgi?id=226808 https://github.com/WebKit/WebKit/commit/dc33e397532ef8140d9e3fa80b7723e16b863746 1922090 2 webkit-bug-importer 2022-12-28 12:16:16 -0800 <rdar://problem/103746193> 1922187 3 jarhar 2022-12-29 08:59:33 -0800 I opened a spec issue: https://github.com/whatwg/html/issues/8657 1965002 4 ahmad.saleem792 2023-07-04 09:41:13 -0700 (In reply to Joey Arhar from comment #3) > I opened a spec issue: https://github.com/whatwg/html/issues/8657 As per following, Safari should align with Gecko behavior and should not throw. So I think we might need to revert Chris's patch, which made us match Blink. https://w3c.github.io/DOM-Parsing/#dom-element-outerhtml 1965138 5 cdumez 2023-07-05 09:21:52 -0700 (In reply to Ahmad Saleem from comment #4) > (In reply to Joey Arhar from comment #3) > > I opened a spec issue: https://github.com/whatwg/html/issues/8657 > > As per following, Safari should align with Gecko behavior and should not > throw. > > So I think we might need to revert Chris's patch, which made us match Blink. > > https://w3c.github.io/DOM-Parsing/#dom-element-outerhtml Yes, looks like Blink agreed on the spec issue to stop throwing so we should do the same. Do you want to do it or should I? 1965159 6 ahmad.saleem792 2023-07-05 10:54:04 -0700 PR with revert + not throw error: https://github.com/WebKit/WebKit/pull/15575 1966924 7 ews-feeder 2023-07-15 15:06:51 -0700 Committed 266086@main (b41af45ee409): <https://commits.webkit.org/266086@main> Reviewed commits have been landed. Closing PR #15575 and removing active labels. 464152 2022-12-21 12:15:41 -0800 2022-12-21 12:15:41 -0800 Repro HTML repro.html text/html 720 nlawson PCFkb2N0eXBlIGh0bWw+CjxodG1sPgo8cHJlIGlkPWRpc3BsYXk+PC9wcmU+CjxzY3JpcHQgdHlw ZT1tb2R1bGU+CgpmdW5jdGlvbiB0ZXN0KGNhbGxiYWNrKSB7CiAgdHJ5IHsKICAgIGNhbGxiYWNr KCkKICAgIHJldHVybiAnTm8gZXJyb3InCiAgfSBjYXRjaCAoZXJyKSB7CiAgICByZXR1cm4gZXJy Lm1lc3NhZ2UKICB9Cn0KCmNvbnN0IHJlczEgPSB0ZXN0KCgpID0+IHsKICBjb25zdCBmcmFnbWVu dCA9IG5ldyBEb2N1bWVudEZyYWdtZW50KCkKICBmcmFnbWVudC5hcHBlbmRDaGlsZChkb2N1bWVu dC5jcmVhdGVFbGVtZW50KCdkaXYnKSkKICBmcmFnbWVudC5maXJzdENoaWxkLm91dGVySFRNTCA9 ICcnCn0pCgpjb25zdCByZXMyID0gdGVzdCgoKSA9PiB7CiAgY29uc3QgY29udGFpbmVyID0gZG9j dW1lbnQuY3JlYXRlRWxlbWVudCgnZGl2JykKICBjb250YWluZXIuYXR0YWNoU2hhZG93KHttb2Rl OiAnb3Blbid9KS5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdkaXYnKSkKICBj b250YWluZXIuc2hhZG93Um9vdC5maXJzdENoaWxkLm91dGVySFRNTCA9ICcnCn0pCgoKZGlzcGxh eS5pbm5lckhUTUwgPSBgClNldHRpbmcgb3V0ZXJIVE1MIG9uIGNoaWxkIG9mIERvY3VtZW50RnJh Z21lbnQ6ICR7cmVzMX0KU2V0dGluZyBvdXRlckhUTUwgb24gY2hpbGQgb2YgU2hhZG93Um9vdDog JHtyZXMyfQpgLnRyaW0oKQoKPC9zY3JpcHQ+CjwvaHRtbD4K