249718 2022-12-21 08:43:56 -0800 Unify more of xcconfig content across projects 2022-12-30 18:46:15 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=249963 InRadar P2 Normal --- 1 ap ap emw webkit-bug-importer oldest_to_newest 1921089 0 ap 2022-12-21 08:43:56 -0800 Move more common variables from individual projects' xcconfigs to a central location, refactoring where they diverged. 1921090 1 webkit-bug-importer 2022-12-21 08:44:12 -0800 <rdar://problem/103600264> 1921097 2 ap 2022-12-21 09:13:14 -0800 Pull request: https://github.com/WebKit/WebKit/pull/7958 1921101 3 ap 2022-12-21 09:16:29 -0800 The configs are still far from what I'd consider nicely organized. My goal here was to move as much as possible, reducing the amount of almost-duplicated code with subtle differences. This will make it possible to have verifiably correct PRs for further cleanup. Some TODOs that I wrote down while working on this: - Update TARGET_MAC_OS_X_VERSION_MAJOR (and delete TARGET_MACOS_LEGACY_VERSION_IDENTIFIER) - Clean up SEARCH_PATHS, they generally make no sense - split them by production (deployment_location?) vs. engineering - Is SUPPORTED_PLATFORMS needed anywhere? - Eliminate WK_WHICH_BUILD_SYSTEM - DumpRenderTree.app - skip install on macOS (unsure about Catalyst) - Normalize prefixing search paths with SDK_DIR/SDKROOT (should be consistent, and maybe neither is needed) - Full path is currently needed when makefiles use the variable - Normalize when we use $(inherited), and when we don't. - _PATH vs. _DIR naming - which are full file system paths? Which ones end with a slash? Should we have something like _IF_NEEDED on those that are empty when unused? - What is COPY_STAGED_FRAMEWORKS_TO_SECONDARY_PATH? Why do we ever need to copy during build? - Use actual names for cryptexes etc. in variables, not the confusing "override/alternative" naming. - libANGLE-shared.dylib and libwebrtc.dylib LC_ID_DYLIB's are inconsistent in STP (one is loader path relative, another is absolute). 1921541 4 ews-feeder 2022-12-22 16:00:38 -0800 Committed 258266@main (e31966cc25b1): <https://commits.webkit.org/258266@main> Reviewed commits have been landed. Closing PR #7958 and removing active labels.