249697 2022-12-20 21:00:18 -0800 [IFC][hanging punctuation] LineBuilder::leadingPunctuationWidthForLineCandiate/trailingPunctuationWidthForLineCandiate should only start searching for contentful runs when punctuation is present 2022-12-22 09:42:16 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1920993 0 zalan 2022-12-20 21:00:18 -0800 ssia 1920994 1 464135 zalan 2022-12-20 21:01:56 -0800 Created attachment 464135 Patch 1921352 2 464163 zalan 2022-12-22 06:01:33 -0800 Created attachment 464163 Patch 1921398 3 ews-feeder 2022-12-22 09:41:53 -0800 Committed 258247@main (a790799aa36d): <https://commits.webkit.org/258247@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 464163. 1921399 4 webkit-bug-importer 2022-12-22 09:42:16 -0800 <rdar://problem/103641016> 464135 2022-12-20 21:01:56 -0800 2022-12-22 06:01:31 -0800 Patch bug-249697-20221220210155.patch text/plain 3595 zalan RnJvbSA3MmNkMmNkMWQyNWI1ZTM1MGUzOWQ3NTc3N2U3YzUyNWNlMjcwODYzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJhcmFkbGF5IDx6YWxhbkBhcHBsZS5jb20+CkRhdGU6 IFR1ZSwgMjAgRGVjIDIwMjIgMjE6MDA6MjcgLTA4MDAKU3ViamVjdDogW1BBVENIXSBbSUZDXVto YW5naW5nIHB1bmN0dWF0aW9uXQogTGluZUJ1aWxkZXI6OmxlYWRpbmdQdW5jdHVhdGlvbldpZHRo Rm9yTGluZUNhbmRpYXRlL3RyYWlsaW5nUHVuY3R1YXRpb25XaWR0aEZvckxpbmVDYW5kaWF0ZQog c2hvdWxkIG9ubHkgc3RhcnQgc2VhcmNoaW5nIGZvciBjb250ZW50ZnVsIHJ1bnMgd2hlbiBwdW5j dHVhdGlvbiBpcyBwcmVzZW50CiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjQ5Njk3CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiogU291cmNlL1dlYkNvcmUv bGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9pbmxpbmUvSW5saW5lTGluZUJ1aWxkZXIuY3BwOgoo V2ViQ29yZTo6TGF5b3V0OjpMaW5lQnVpbGRlcjo6bGVhZGluZ1B1bmN0dWF0aW9uV2lkdGhGb3JM aW5lQ2FuZGlhdGUgY29uc3QpOgooV2ViQ29yZTo6TGF5b3V0OjpMaW5lQnVpbGRlcjo6dHJhaWxp bmdQdW5jdHVhdGlvbldpZHRoRm9yTGluZUNhbmRpYXRlIGNvbnN0KToKLS0tCiAuLi4vaW5saW5l L0lubGluZUxpbmVCdWlsZGVyLmNwcCAgICAgICAgICAgICAgICAgICB8IDE0ICsrKysrKysrKyst LS0tCiAxIGZpbGUgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZm9ybWF0dGluZ0NvbnRleHRzL2lubGlu ZS9JbmxpbmVMaW5lQnVpbGRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZm9ybWF0dGlu Z0NvbnRleHRzL2lubGluZS9JbmxpbmVMaW5lQnVpbGRlci5jcHAKaW5kZXggMjkzYjUzYzAwNDFi Li4wOTc1ODRiNDcwZmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0 aW5nQ29udGV4dHMvaW5saW5lL0lubGluZUxpbmVCdWlsZGVyLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9sYXlvdXQvZm9ybWF0dGluZ0NvbnRleHRzL2lubGluZS9JbmxpbmVMaW5lQnVpbGRlci5j cHAKQEAgLTY0NCw2ICs2NDQsMTEgQEAgSW5saW5lTGF5b3V0VW5pdCBMaW5lQnVpbGRlcjo6bGVh ZGluZ1B1bmN0dWF0aW9uV2lkdGhGb3JMaW5lQ2FuZGlhdGUoc2l6ZV90IGZpcnMKICAgICBpZiAo IWlzRmlyc3RMaW5lRmlyc3RDb250ZW50KQogICAgICAgICByZXR1cm4geyB9OwogCisgICAgYXV0 byYgaW5saW5lVGV4dEl0ZW0gPSBkb3duY2FzdDxJbmxpbmVUZXh0SXRlbT4obV9pbmxpbmVJdGVt c1tmaXJzdElubGluZVRleHRJdGVtSW5kZXhdKTsKKyAgICBhdXRvJiBzdHlsZSA9IGlzRmlyc3RG b3JtYXR0ZWRMaW5lKCkgPyBpbmxpbmVUZXh0SXRlbS5maXJzdExpbmVTdHlsZSgpIDogaW5saW5l VGV4dEl0ZW0uc3R5bGUoKTsKKyAgICBpZiAoIVRleHRVdGlsOjpoYXNIYW5nYWJsZVB1bmN0dWF0 aW9uU3RhcnQoaW5saW5lVGV4dEl0ZW0sIHN0eWxlKSkKKyAgICAgICAgcmV0dXJuIHsgfTsKKwog ICAgIGlmIChmaXJzdElubGluZVRleHRJdGVtSW5kZXgpIHsKICAgICAgICAgLy8gVGhlIHRleHQg Y29udGVudCBpcyBub3QgdGhlIGZpcnN0IGluIHRoZSBjYW5kaWRhdGUgbGlzdC4gSG93ZXZlciBp dCBtYXkgYmUgdGhlIGZpcnN0IGNvbnRlbnRmdWwgb25lLgogICAgICAgICBmb3IgKGF1dG8gaW5k ZXggPSBmaXJzdElubGluZVRleHRJdGVtSW5kZXggLSAxOyBpbmRleCA+PSBjYW5kaWRhdGVDb250 ZW50U3RhcnRJbmRleDsgLS1pbmRleCkgewpAQCAtNjU4LDE0ICs2NjMsMTcgQEAgSW5saW5lTGF5 b3V0VW5pdCBMaW5lQnVpbGRlcjo6bGVhZGluZ1B1bmN0dWF0aW9uV2lkdGhGb3JMaW5lQ2FuZGlh dGUoc2l6ZV90IGZpcnMKICAgICAgICAgICAgICAgICByZXR1cm4geyB9OwogICAgICAgICB9CiAg ICAgfQotICAgIGF1dG8mIGlubGluZVRleHRJdGVtID0gZG93bmNhc3Q8SW5saW5lVGV4dEl0ZW0+ KG1faW5saW5lSXRlbXNbZmlyc3RJbmxpbmVUZXh0SXRlbUluZGV4XSk7Ci0gICAgYXV0byYgc3R5 bGUgPSBpc0ZpcnN0Rm9ybWF0dGVkTGluZSgpID8gaW5saW5lVGV4dEl0ZW0uZmlyc3RMaW5lU3R5 bGUoKSA6IGlubGluZVRleHRJdGVtLnN0eWxlKCk7CiAgICAgLy8gVGhpcyBjYW5kaWRhdGUgbGVh ZGluZyBjb250ZW50IG1heSBoYXZlIGhhbmdpbmcgcHVuY3R1YXRpb24gc3RhcnQuCiAgICAgcmV0 dXJuIFRleHRVdGlsOjpoYW5nYWJsZVB1bmN0dWF0aW9uU3RhcnRXaWR0aChpbmxpbmVUZXh0SXRl bSwgc3R5bGUpOwogfQogCiBJbmxpbmVMYXlvdXRVbml0IExpbmVCdWlsZGVyOjp0cmFpbGluZ1B1 bmN0dWF0aW9uV2lkdGhGb3JMaW5lQ2FuZGlhdGUoc2l6ZV90IGxhc3RJbmxpbmVUZXh0SXRlbUlu ZGV4LCBzaXplX3QgbGF5b3V0UmFuZ2VFbmQpIGNvbnN0CiB7CisgICAgYXV0byYgaW5saW5lVGV4 dEl0ZW0gPSBkb3duY2FzdDxJbmxpbmVUZXh0SXRlbT4obV9pbmxpbmVJdGVtc1tsYXN0SW5saW5l VGV4dEl0ZW1JbmRleF0pOworICAgIGF1dG8mIHN0eWxlID0gaXNGaXJzdEZvcm1hdHRlZExpbmUo KSA/IGlubGluZVRleHRJdGVtLmZpcnN0TGluZVN0eWxlKCkgOiBpbmxpbmVUZXh0SXRlbS5zdHls ZSgpOworICAgIGlmICghVGV4dFV0aWw6Omhhc0hhbmdhYmxlUHVuY3R1YXRpb25FbmQoaW5saW5l VGV4dEl0ZW0sIHN0eWxlKSkKKyAgICAgICAgcmV0dXJuIHsgfTsKKwogICAgIC8vIEZJWE1FOiBJ ZiB0aGlzIHR1cm5zIG91dCB0byBiZSBwcm9ibGVtYXRpYyAoZmluZGluZyBvdXQgaWYgdGhpcyBp cyB0aGUgbGFzdCBmb3JtYXR0ZWQgbGluZSB0aGF0IGlzKSwgd2UKICAgICAvLyBtYXkgaGF2ZSB0 byBmYWxsYmFjayB0byBhIHBvc3QtcHJvY2VzcyBzZXR1cCwgd2hlcmUgYWZ0ZXIgZmluaXNoaW5n IGxheWluZyBvdXQgdGhlIGNvbnRlbnQsIHdlIGdvIGJhY2sgYW5kIHJlLWxheW91dAogICAgIC8v IHRoZSBsYXN0ICgyPykgbGluZShzKSB3aGVuIHRoZXJlJ3MgdHJhaWxpbmcgaGFuZ2luZyBwdW5j dHVhdGlvbi4KQEAgLTY4MCw4ICs2ODgsNiBAQCBJbmxpbmVMYXlvdXRVbml0IExpbmVCdWlsZGVy Ojp0cmFpbGluZ1B1bmN0dWF0aW9uV2lkdGhGb3JMaW5lQ2FuZGlhdGUoc2l6ZV90IGxhcwogICAg ICAgICBpZiAoaXNDb250ZW50ZnVsKQogICAgICAgICAgICAgcmV0dXJuIHsgfTsKICAgICB9Ci0g ICAgYXV0byYgaW5saW5lVGV4dEl0ZW0gPSBkb3duY2FzdDxJbmxpbmVUZXh0SXRlbT4obV9pbmxp bmVJdGVtc1tsYXN0SW5saW5lVGV4dEl0ZW1JbmRleF0pOwotICAgIGF1dG8mIHN0eWxlID0gaXNG aXJzdEZvcm1hdHRlZExpbmUoKSA/IGlubGluZVRleHRJdGVtLmZpcnN0TGluZVN0eWxlKCkgOiBp bmxpbmVUZXh0SXRlbS5zdHlsZSgpOwogICAgIC8vIFRoaXMgY2FuZGlkYXRlIGxlYWRpbmcgY29u dGVudCBtYXkgaGF2ZSBoYW5naW5nIHB1bmN0dWF0aW9uIHN0YXJ0LgogICAgIHJldHVybiBUZXh0 VXRpbDo6aGFuZ2FibGVQdW5jdHVhdGlvbkVuZFdpZHRoKGlubGluZVRleHRJdGVtLCBzdHlsZSk7 CiB9Cg== 464163 2022-12-22 06:01:33 -0800 2022-12-22 09:41:54 -0800 Patch bug-249697-20221222060132.patch text/plain 3586 zalan RnJvbSBhMDg3NGUxOTU5YjJlNGE2YTg0YzZkNDhhNjZmZjdhNDVlNWY3NmQ5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJhcmFkbGF5IDx6YWxhbkBhcHBsZS5jb20+CkRhdGU6 IFRodSwgMjIgRGVjIDIwMjIgMDU6NTk6MjcgLTA4MDAKU3ViamVjdDogW1BBVENIXSBbSUZDXVto YW5naW5nIHB1bmN0dWF0aW9uXQogTGluZUJ1aWxkZXI6OmxlYWRpbmdQdW5jdHVhdGlvbldpZHRo Rm9yTGluZUNhbmRpYXRlL3RyYWlsaW5nUHVuY3R1YXRpb25XaWR0aEZvckxpbmVDYW5kaWF0ZQog c2hvdWxkIG9ubHkgc3RhcnQgc2VhcmNoaW5nIGZvciBjb250ZW50ZnVsIHJ1bnMgd2hlbiBwdW5j dHVhdGlvbiBpcyBwcmVzZW50CiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjQ5Njk3CgpSZXZpZXdlZCBieSBBbnR0aSBLb2l2aXN0by4KCiogU291cmNlL1dlYkNvcmUv bGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9pbmxpbmUvSW5saW5lTGluZUJ1aWxkZXIuY3BwOgoo V2ViQ29yZTo6TGF5b3V0OjpMaW5lQnVpbGRlcjo6bGVhZGluZ1B1bmN0dWF0aW9uV2lkdGhGb3JM aW5lQ2FuZGlhdGUgY29uc3QpOgooV2ViQ29yZTo6TGF5b3V0OjpMaW5lQnVpbGRlcjo6dHJhaWxp bmdQdW5jdHVhdGlvbldpZHRoRm9yTGluZUNhbmRpYXRlIGNvbnN0KToKLS0tCiAuLi4vaW5saW5l L0lubGluZUxpbmVCdWlsZGVyLmNwcCAgICAgICAgICAgICAgICAgICB8IDE0ICsrKysrKysrKyst LS0tCiAxIGZpbGUgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZm9ybWF0dGluZ0NvbnRleHRzL2lubGlu ZS9JbmxpbmVMaW5lQnVpbGRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZm9ybWF0dGlu Z0NvbnRleHRzL2lubGluZS9JbmxpbmVMaW5lQnVpbGRlci5jcHAKaW5kZXggZWVjMTg2YmZlYmZi Li5hMmU0ZjEyMzVkZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0 aW5nQ29udGV4dHMvaW5saW5lL0lubGluZUxpbmVCdWlsZGVyLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9sYXlvdXQvZm9ybWF0dGluZ0NvbnRleHRzL2lubGluZS9JbmxpbmVMaW5lQnVpbGRlci5j cHAKQEAgLTY0NCw2ICs2NDQsMTEgQEAgSW5saW5lTGF5b3V0VW5pdCBMaW5lQnVpbGRlcjo6bGVh ZGluZ1B1bmN0dWF0aW9uV2lkdGhGb3JMaW5lQ2FuZGlhdGUoc2l6ZV90IGZpcnMKICAgICBpZiAo IWlzRmlyc3RMaW5lRmlyc3RDb250ZW50KQogICAgICAgICByZXR1cm4geyB9OwogCisgICAgYXV0 byYgaW5saW5lVGV4dEl0ZW0gPSBkb3duY2FzdDxJbmxpbmVUZXh0SXRlbT4obV9pbmxpbmVJdGVt c1tmaXJzdElubGluZVRleHRJdGVtSW5kZXhdKTsKKyAgICBhdXRvJiBzdHlsZSA9IGlzRmlyc3RG b3JtYXR0ZWRMaW5lKCkgPyBpbmxpbmVUZXh0SXRlbS5maXJzdExpbmVTdHlsZSgpIDogaW5saW5l VGV4dEl0ZW0uc3R5bGUoKTsKKyAgICBpZiAoIVRleHRVdGlsOjpoYXNIYW5nYWJsZVB1bmN0dWF0 aW9uU3RhcnQoaW5saW5lVGV4dEl0ZW0sIHN0eWxlKSkKKyAgICAgICAgcmV0dXJuIHsgfTsKKwog ICAgIGlmIChmaXJzdElubGluZVRleHRJdGVtSW5kZXgpIHsKICAgICAgICAgLy8gVGhlIHRleHQg Y29udGVudCBpcyBub3QgdGhlIGZpcnN0IGluIHRoZSBjYW5kaWRhdGUgbGlzdC4gSG93ZXZlciBp dCBtYXkgYmUgdGhlIGZpcnN0IGNvbnRlbnRmdWwgb25lLgogICAgICAgICBmb3IgKHNpemVfdCBp bmRleCA9IGZpcnN0SW5saW5lVGV4dEl0ZW1JbmRleDsgaW5kZXgtLSA+IGNhbmRpZGF0ZUNvbnRl bnRTdGFydEluZGV4OykgewpAQCAtNjU4LDE0ICs2NjMsMTcgQEAgSW5saW5lTGF5b3V0VW5pdCBM aW5lQnVpbGRlcjo6bGVhZGluZ1B1bmN0dWF0aW9uV2lkdGhGb3JMaW5lQ2FuZGlhdGUoc2l6ZV90 IGZpcnMKICAgICAgICAgICAgICAgICByZXR1cm4geyB9OwogICAgICAgICB9CiAgICAgfQotICAg IGF1dG8mIGlubGluZVRleHRJdGVtID0gZG93bmNhc3Q8SW5saW5lVGV4dEl0ZW0+KG1faW5saW5l SXRlbXNbZmlyc3RJbmxpbmVUZXh0SXRlbUluZGV4XSk7Ci0gICAgYXV0byYgc3R5bGUgPSBpc0Zp cnN0Rm9ybWF0dGVkTGluZSgpID8gaW5saW5lVGV4dEl0ZW0uZmlyc3RMaW5lU3R5bGUoKSA6IGlu bGluZVRleHRJdGVtLnN0eWxlKCk7CiAgICAgLy8gVGhpcyBjYW5kaWRhdGUgbGVhZGluZyBjb250 ZW50IG1heSBoYXZlIGhhbmdpbmcgcHVuY3R1YXRpb24gc3RhcnQuCiAgICAgcmV0dXJuIFRleHRV dGlsOjpoYW5nYWJsZVB1bmN0dWF0aW9uU3RhcnRXaWR0aChpbmxpbmVUZXh0SXRlbSwgc3R5bGUp OwogfQogCiBJbmxpbmVMYXlvdXRVbml0IExpbmVCdWlsZGVyOjp0cmFpbGluZ1B1bmN0dWF0aW9u V2lkdGhGb3JMaW5lQ2FuZGlhdGUoc2l6ZV90IGxhc3RJbmxpbmVUZXh0SXRlbUluZGV4LCBzaXpl X3QgbGF5b3V0UmFuZ2VFbmQpIGNvbnN0CiB7CisgICAgYXV0byYgaW5saW5lVGV4dEl0ZW0gPSBk b3duY2FzdDxJbmxpbmVUZXh0SXRlbT4obV9pbmxpbmVJdGVtc1tsYXN0SW5saW5lVGV4dEl0ZW1J bmRleF0pOworICAgIGF1dG8mIHN0eWxlID0gaXNGaXJzdEZvcm1hdHRlZExpbmUoKSA/IGlubGlu ZVRleHRJdGVtLmZpcnN0TGluZVN0eWxlKCkgOiBpbmxpbmVUZXh0SXRlbS5zdHlsZSgpOworICAg IGlmICghVGV4dFV0aWw6Omhhc0hhbmdhYmxlUHVuY3R1YXRpb25FbmQoaW5saW5lVGV4dEl0ZW0s IHN0eWxlKSkKKyAgICAgICAgcmV0dXJuIHsgfTsKKwogICAgIC8vIEZJWE1FOiBJZiB0aGlzIHR1 cm5zIG91dCB0byBiZSBwcm9ibGVtYXRpYyAoZmluZGluZyBvdXQgaWYgdGhpcyBpcyB0aGUgbGFz dCBmb3JtYXR0ZWQgbGluZSB0aGF0IGlzKSwgd2UKICAgICAvLyBtYXkgaGF2ZSB0byBmYWxsYmFj ayB0byBhIHBvc3QtcHJvY2VzcyBzZXR1cCwgd2hlcmUgYWZ0ZXIgZmluaXNoaW5nIGxheWluZyBv dXQgdGhlIGNvbnRlbnQsIHdlIGdvIGJhY2sgYW5kIHJlLWxheW91dAogICAgIC8vIHRoZSBsYXN0 ICgyPykgbGluZShzKSB3aGVuIHRoZXJlJ3MgdHJhaWxpbmcgaGFuZ2luZyBwdW5jdHVhdGlvbi4K QEAgLTY4MCw4ICs2ODgsNiBAQCBJbmxpbmVMYXlvdXRVbml0IExpbmVCdWlsZGVyOjp0cmFpbGlu Z1B1bmN0dWF0aW9uV2lkdGhGb3JMaW5lQ2FuZGlhdGUoc2l6ZV90IGxhcwogICAgICAgICBpZiAo aXNDb250ZW50ZnVsKQogICAgICAgICAgICAgcmV0dXJuIHsgfTsKICAgICB9Ci0gICAgYXV0byYg aW5saW5lVGV4dEl0ZW0gPSBkb3duY2FzdDxJbmxpbmVUZXh0SXRlbT4obV9pbmxpbmVJdGVtc1ts YXN0SW5saW5lVGV4dEl0ZW1JbmRleF0pOwotICAgIGF1dG8mIHN0eWxlID0gaXNGaXJzdEZvcm1h dHRlZExpbmUoKSA/IGlubGluZVRleHRJdGVtLmZpcnN0TGluZVN0eWxlKCkgOiBpbmxpbmVUZXh0 SXRlbS5zdHlsZSgpOwogICAgIC8vIFRoaXMgY2FuZGlkYXRlIGxlYWRpbmcgY29udGVudCBtYXkg aGF2ZSBoYW5naW5nIHB1bmN0dWF0aW9uIHN0YXJ0LgogICAgIHJldHVybiBUZXh0VXRpbDo6aGFu Z2FibGVQdW5jdHVhdGlvbkVuZFdpZHRoKGlubGluZVRleHRJdGVtLCBzdHlsZSk7CiB9Cg==