249694 2022-12-20 20:14:24 -0800 [WinCairo] Assertion fails while ~RemoteImageBufferProxy in DrawingAreaWC CommitQueue 2022-12-21 14:01:18 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii don.olmstead kkinnunen webkit-bug-importer oldest_to_newest 1920986 0 fujii 2022-12-20 20:14:24 -0800 [WinCairo] Assertion fails while ~RemoteImageBufferProxy in DrawingAreaWC CommitQueue WinCairo WK2 Debug tester bot is reporting an assertion failure for the following tests. fast/transforms/interleaved-2d-transforms-with-gpu-process.html [ Crash ] webgl/webgl-and-dom-in-gpup.html [ Crash ] ASSERTION FAILED: !m_impl || !m_shouldEnableAssertions || m_impl->wasConstructedOnMainThread() == isMainThread() C:\jenkins_slave\wincairo-main\WebKitBuild\Debug\WTF\Headers\wtf/WeakPtr.h(135) : WTF::WeakPtr<class WebKit::RemoteRenderingBackendProxy,class WTF::DefaultWeakPtrImpl>::operator -> 1 00007FFF94DB248B WTFCrash 2 00007FFF6C0B2C1E WTFCrashWithInfo 3 00007FFF6D915BF4 WTF::WeakPtr<WebKit::RemoteRenderingBackendProxy,WTF::DefaultWeakPtrImpl>::operator-> 4 00007FFF6D7B1476 WebKit::RemoteImageBufferProxy::~RemoteImageBufferProxy 5 00007FFF6D934A28 WebKit::RemoteImageBufferProxy::`scalar deleting destructor' 6 00007FFF6C0BCE58 `WTF::ThreadSafeRefCounted<WebCore::ImageBuffer,0>::deref'::`2'::<lambda_1>::operator() 7 00007FFF6C0BEC84 WTF::ThreadSafeRefCounted<WebCore::ImageBuffer,0>::deref 8 00007FFF6C0BF063 WTF::DefaultRefDerefTraits<WebCore::ImageBuffer>::derefIfNotNull 9 00007FFF6C0BB63D WTF::RefPtr<WebCore::ImageBuffer,WTF::RawPtrTraits<WebCore::ImageBuffer>,WTF::DefaultRefDerefTraits<WebCore::ImageBuffer> >::~RefPtr<WebCore::ImageBuffer,WTF::RawPtrTraits<WebCore::ImageBuffer>,WTF::DefaultRefDerefTraits<WebCore::ImageBuffer> > 10 00007FFF6C1A4F5D `WebKit::DrawingAreaWC::sendUpdateNonAC'::`2'::<lambda_1>::~<lambda_1> 11 00007FFF6C1A5B9B WTF::Detail::CallableWrapper<`WebKit::DrawingAreaWC::sendUpdateNonAC'::`2'::<lambda_1>,void>::~CallableWrapper<`WebKit::DrawingAreaWC::sendUpdateNonAC'::`2'::<lambda_1>,void> 12 00007FFF6C1A5BD8 WTF::Detail::CallableWrapper<`WebKit::DrawingAreaWC::sendUpdateNonAC'::`2'::<lambda_1>,void>::`scalar deleting destructor' 13 00007FFF94DBED5F std::default_delete<WTF::Detail::CallableWrapperBase<void> >::operator() 14 00007FFF94DBE453 std::unique_ptr<WTF::Detail::CallableWrapperBase<void>,std::default_delete<WTF::Detail::CallableWrapperBase<void> > >::~unique_ptr<WTF::Detail::CallableWrapperBase<void>,std::default_delete<WTF::Detail::CallableWrapperBase<void> > > 15 00007FFF94DBE097 WTF::Function<void __cdecl(void)>::~Function<void __cdecl(void)> 16 00007FFF94F3FEAB `WTF::WorkQueueBase::dispatch'::`2'::<lambda_1>::~<lambda_1> 17 00007FFF94F4054B WTF::Detail::CallableWrapper<`WTF::WorkQueueBase::dispatch'::`2'::<lambda_1>,void>::~CallableWrapper<`WTF::WorkQueueBase::dispatch'::`2'::<lambda_1>,void> 18 00007FFF94F40588 WTF::Detail::CallableWrapper<`WTF::WorkQueueBase::dispatch'::`2'::<lambda_1>,void>::`scalar deleting destructor' 19 00007FFF94DBED5F std::default_delete<WTF::Detail::CallableWrapperBase<void> >::operator() 20 00007FFF94DBE453 std::unique_ptr<WTF::Detail::CallableWrapperBase<void>,std::default_delete<WTF::Detail::CallableWrapperBase<void> > >::~unique_ptr<WTF::Detail::CallableWrapperBase<void>,std::default_delete<WTF::Detail::CallableWrapperBase<void> > > 21 00007FFF94DBE097 WTF::Function<void __cdecl(void)>::~Function<void __cdecl(void)> 22 00007FFF94E61E82 WTF::RunLoop::performWork 23 00007FFF94F4D571 WTF::RunLoop::wndProc 24 00007FFF94F4D4D4 WTF::RunLoop::RunLoopWndProc 25 00007FFFBDEDE858 CallWindowProcW 26 00007FFFBDEDE299 DispatchMessageW 27 00007FFF94F4CA56 WTF::RunLoop::run 28 00007FFF94E61F4D `WTF::RunLoop::create'::`2'::<lambda_1>::operator() 29 00007FFF94E621CB WTF::Detail::CallableWrapper<`WTF::RunLoop::create'::`2'::<lambda_1>,void>::call 30 00007FFF94DCA503 WTF::Function<void __cdecl(void)>::operator() 31 00007FFF94E72488 WTF::Thread::entryPoint 1920987 1 fujii 2022-12-20 20:16:20 -0800 This isn't reprodusible on my PC. But, adding sleep makes it reprodusible. diff --git a/Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.cpp b/Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.cpp index c2ac3bd9e8bf..f81bbe5de247 100644 --- a/Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.cpp +++ b/Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.cpp @@ -341,6 +341,7 @@ void DrawingAreaWC::sendUpdateNonAC() updateInfo.bitmapHandle = std::get<ShareableBitmapHandle>(WTFMove(handle)); send(Messages::DrawingAreaProxy::Update(stateID, WTFMove(updateInfo))); }); + Sleep(3 * 1000); }); } 1920988 2 464132 fujii 2022-12-20 20:30:30 -0800 Created attachment 464132 Patch 1921158 3 464132 fujii 2022-12-21 11:41:11 -0800 Comment on attachment 464132 Patch Thank you for the review. 1921207 4 ews-feeder 2022-12-21 14:00:22 -0800 Committed 258214@main (7750f7a4299a): <https://commits.webkit.org/258214@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 464132. 1921208 5 webkit-bug-importer 2022-12-21 14:01:18 -0800 <rdar://problem/103612749> 464132 2022-12-20 20:30:30 -0800 2022-12-21 14:00:23 -0800 Patch bug-249694-20221221133029.patch text/plain 1942 fujii RnJvbSA1YzE5MTAwMGZjOGJjZmRjNzgwMzAwZTBkZmY5MDEzNzgyZTA2Y2RhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBIaXJvbm9yaSA8SGlyb25vcmkuRnVqaWlAc29ueS5j b20+CkRhdGU6IFdlZCwgMjEgRGVjIDIwMjIgMTM6MjI6MjkgKzA5MDAKU3ViamVjdDogW1BBVENI XSBbV2luQ2Fpcm9dIEFzc2VydGlvbiBmYWlscyB3aGlsZSB+UmVtb3RlSW1hZ2VCdWZmZXJQcm94 eSBpbgogRHJhd2luZ0FyZWFXQyBDb21taXRRdWV1ZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjQ5Njk0CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCkFuIGFz c2VydGlvbiBmYWlsZWQgYmVjYXVzZSBSZW1vdGVJbWFnZUJ1ZmZlclByb3h5IHdhcyBkZXN0cm95 ZWQgaW4KdGhlIG5vbi1tYWluIHRocmVhZC4KCiogU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dl YlBhZ2Uvd2MvRHJhd2luZ0FyZWFXQy5jcHA6CihXZWJLaXQ6OkRyYXdpbmdBcmVhV0M6OnNlbmRV cGRhdGVOb25BQyk6IERvbid0IGxlYXZlIHRoZSBsaWZldGltZSBvZgpSZWZQdHI8SW1hZ2VCdWZm ZXI+IGluIHRoZSBsYW1iZGEgZnVuY3Rpb25zLgotLS0KIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vz cy9XZWJQYWdlL3djL0RyYXdpbmdBcmVhV0MuY3BwIHwgNCArKy0tCiAxIGZpbGUgY2hhbmdlZCwg MiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvV2ViUHJvY2Vzcy9XZWJQYWdlL3djL0RyYXdpbmdBcmVhV0MuY3BwIGIvU291cmNlL1dlYktp dC9XZWJQcm9jZXNzL1dlYlBhZ2Uvd2MvRHJhd2luZ0FyZWFXQy5jcHAKaW5kZXggYzJhYzNiZDll OGJmLi45YjA2MWQzNWVlNjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9X ZWJQYWdlL3djL0RyYXdpbmdBcmVhV0MuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vz cy9XZWJQYWdlL3djL0RyYXdpbmdBcmVhV0MuY3BwCkBAIC0zMjEsMTAgKzMyMSwxMCBAQCB2b2lk IERyYXdpbmdBcmVhV0M6OnNlbmRVcGRhdGVOb25BQygpCiAgICAgICAgIG1fd2ViUGFnZS5kcmF3 UmVjdChpbWFnZS0+Y29udGV4dCgpLCByZWN0KTsKICAgICBpbWFnZS0+Zmx1c2hEcmF3aW5nQ29u dGV4dEFzeW5jKCk7CiAKLSAgICBtX2NvbW1pdFF1ZXVlLT5kaXNwYXRjaChbdGhpcywgd2Vha1Ro aXMgPSBXZWFrUHRyKCp0aGlzKSwgc3RhdGVJRCA9IG1fYmFja2luZ1N0b3JlU3RhdGVJRCwgdXBk YXRlSW5mbyA9IFdURk1vdmUodXBkYXRlSW5mbyksIGltYWdlXSgpIG11dGFibGUgeworICAgIG1f Y29tbWl0UXVldWUtPmRpc3BhdGNoKFt0aGlzLCB3ZWFrVGhpcyA9IFdlYWtQdHIoKnRoaXMpLCBz dGF0ZUlEID0gbV9iYWNraW5nU3RvcmVTdGF0ZUlELCB1cGRhdGVJbmZvID0gV1RGTW92ZSh1cGRh dGVJbmZvKSwgaW1hZ2UgPSBXVEZNb3ZlKGltYWdlKV0oKSBtdXRhYmxlIHsKICAgICAgICAgaWYg KGF1dG8gZmx1c2hlciA9IGltYWdlLT5jcmVhdGVGbHVzaGVyKCkpCiAgICAgICAgICAgICBmbHVz aGVyLT5mbHVzaCgpOwotICAgICAgICBSdW5Mb29wOjptYWluKCkuZGlzcGF0Y2goW3RoaXMsIHdl YWtUaGlzID0gV1RGTW92ZSh3ZWFrVGhpcyksIHN0YXRlSUQsIHVwZGF0ZUluZm8gPSBXVEZNb3Zl KHVwZGF0ZUluZm8pLCBpbWFnZV0oKSBtdXRhYmxlIHsKKyAgICAgICAgUnVuTG9vcDo6bWFpbigp LmRpc3BhdGNoKFt0aGlzLCB3ZWFrVGhpcyA9IFdURk1vdmUod2Vha1RoaXMpLCBzdGF0ZUlELCB1 cGRhdGVJbmZvID0gV1RGTW92ZSh1cGRhdGVJbmZvKSwgaW1hZ2UgPSBXVEZNb3ZlKGltYWdlKV0o KSBtdXRhYmxlIHsKICAgICAgICAgICAgIGlmICghd2Vha1RoaXMpCiAgICAgICAgICAgICAgICAg cmV0dXJuOwogICAgICAgICAgICAgaWYgKHN0YXRlSUQgIT0gbV9iYWNraW5nU3RvcmVTdGF0ZUlE KSB7Cg==