24965 2009-03-31 14:40:54 -0700 HTMLMediaElement: network state changes can be missed 2009-03-31 15:14:11 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 eric.carlson webkit-unassigned oldest_to_newest 116068 0 eric.carlson 2009-03-31 14:40:54 -0700 A bug in the logic of HTMLMediaElement::setNetworkState can cause a network state change to be missed. 116072 1 29132 eric.carlson 2009-03-31 14:51:44 -0700 Created attachment 29132 proposed patch 116079 2 29132 simon.fraser 2009-03-31 15:10:34 -0700 Comment on attachment 29132 proposed patch > + MediaPlayer::ReadyState currentState = m_player->readyState(); > + if (static_cast<ReadyState>(currentState) != m_readyState) This cast is pretty heinous. It would be nice to: 1. Have MediaPlayer ReadyState have a somewhat different name (PlayerReadyState). 2. Have a method that converts them: ReadyState readyStateForPlayerReadyState(PlayerReadyState) rather than casting. But those can be done in a later commit. 116080 3 eric.carlson 2009-03-31 15:14:11 -0700 Committed revision 42144. 29132 2009-03-31 14:51:44 -0700 2009-03-31 15:10:34 -0700 proposed patch patch.txt text/plain 3418 eric.carlson SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MjE0MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDMtMzEgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBh cHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0OTY1CisgICAgICAg IEJ1ZyAyNDk2NTogSFRNTE1lZGlhRWxlbWVudDogbmV0d29yayBzdGF0ZSBjaGFuZ2VzIGNhbiBi ZSBtaXNzZWQKKyAgICAgICAgCisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OnNldE5ldHdvcmtTdGF0ZSk6IEFs d2F5cyB1cGRhdGUgbV9uZXR3b3JrU3RhdGUgd2hlbiB0aGUKKyAgICAgICAgc3RhdGUgY2hhbmdl cywgZXZlbiB3aGVuIG5vIGV2ZW50IG5lZWRzIHRvIGJlIGZpcmVkLgorCiAyMDA5LTAzLTMxICBF cmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IERhcmluIEFkbGVyLgpJbmRleDogV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAkocmV2aXNp b24gNDIxNDEpCisrKyBXZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTU5NSwzMSArNTk1LDM4IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6c2V0TmV0 d29ya1N0YXRlKE0KICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotICAgIGlmIChzdGF0ZSA9PSBN ZWRpYVBsYXllcjo6SWRsZSAmJiBtX25ldHdvcmtTdGF0ZSA+IE5FVFdPUktfSURMRSkgeworICAg IGlmIChzdGF0ZSA9PSBNZWRpYVBsYXllcjo6SWRsZSkgewogICAgICAgICBBU1NFUlQoc3RhdGlj X2Nhc3Q8UmVhZHlTdGF0ZT4obV9wbGF5ZXItPnJlYWR5U3RhdGUoKSkgPCBIQVZFX0VOT1VHSF9E QVRBKTsKKyAgICAgICAgaWYgKG1fbmV0d29ya1N0YXRlID4gTkVUV09SS19JRExFKSB7CisgICAg ICAgICAgICBzdG9wUGVyaW9kaWNUaW1lcnMoKTsKKyAgICAgICAgICAgIHNjaGVkdWxlUHJvZ3Jl c3NFdmVudChldmVudE5hbWVzKCkuc3VzcGVuZEV2ZW50KTsKKyAgICAgICAgfQogICAgICAgICBt X25ldHdvcmtTdGF0ZSA9IE5FVFdPUktfSURMRTsKLSAgICAgICAgc3RvcFBlcmlvZGljVGltZXJz KCk7Ci0gICAgICAgIHNjaGVkdWxlUHJvZ3Jlc3NFdmVudChldmVudE5hbWVzKCkuc3VzcGVuZEV2 ZW50KTsKICAgICB9CiAKLSAgICBpZiAoc3RhdGUgPT0gTWVkaWFQbGF5ZXI6OkxvYWRpbmcgJiYg KG1fbmV0d29ya1N0YXRlIDwgTkVUV09SS19MT0FESU5HIHx8IG1fbmV0d29ya1N0YXRlID09IE5F VFdPUktfTk9fU09VUkNFKSkgeworICAgIGlmIChzdGF0ZSA9PSBNZWRpYVBsYXllcjo6TG9hZGlu ZykgewogICAgICAgICBBU1NFUlQoc3RhdGljX2Nhc3Q8UmVhZHlTdGF0ZT4obV9wbGF5ZXItPnJl YWR5U3RhdGUoKSkgPCBIQVZFX0VOT1VHSF9EQVRBKTsKKyAgICAgICAgaWYgKG1fbmV0d29ya1N0 YXRlIDwgTkVUV09SS19MT0FESU5HIHx8IG1fbmV0d29ya1N0YXRlID09IE5FVFdPUktfTk9fU09V UkNFKQorICAgICAgICAgICAgc3RhcnRQcm9ncmVzc0V2ZW50VGltZXIoKTsKICAgICAgICAgbV9u ZXR3b3JrU3RhdGUgPSBORVRXT1JLX0xPQURJTkc7Ci0gICAgICAgIHN0YXJ0UHJvZ3Jlc3NFdmVu dFRpbWVyKCk7CiAgICAgfQogCi0gICAgaWYgKHN0YXRlID09IE1lZGlhUGxheWVyOjpMb2FkZWQg JiYgKG1fbmV0d29ya1N0YXRlIDwgTkVUV09SS19MT0FERUQgfHwgbV9uZXR3b3JrU3RhdGUgPT0g TkVUV09SS19OT19TT1VSQ0UpKSB7CisgICAgaWYgKHN0YXRlID09IE1lZGlhUGxheWVyOjpMb2Fk ZWQpIHsKKyAgICAgICAgTmV0d29ya1N0YXRlIG9sZFN0YXRlID0gbV9uZXR3b3JrU3RhdGU7CisK ICAgICAgICAgbV9uZXR3b3JrU3RhdGUgPSBORVRXT1JLX0xPQURFRDsKLSAgICAgICAgbV9wcm9n cmVzc0V2ZW50VGltZXIuc3RvcCgpOworICAgICAgICBpZiAob2xkU3RhdGUgPCBORVRXT1JLX0xP QURFRCB8fCBvbGRTdGF0ZSA9PSBORVRXT1JLX05PX1NPVVJDRSkgeworICAgICAgICAgICAgbV9w cm9ncmVzc0V2ZW50VGltZXIuc3RvcCgpOwogCi0gICAgICAgIC8vIENoZWNrIHRvIHNlZSBpZiBy ZWFkeVN0YXRlIGNoYW5nZXMgbmVlZCB0byBiZSBkZWFsdCB3aXRoIGJlZm9yZSBzZW5kaW5nIHRo ZSAKLSAgICAgICAgLy8gJ2xvYWQnIGV2ZW50IHNvIHdlIHJlcG9ydCAnY2FucGxheXRocm91Z2gn IGZpcnN0LiBUaGlzIGlzIG5lY2Vzc2FyeSBiZWNhdXNlIGEKLSAgICAgICAgLy8gIG1lZGlhIGVu Z2luZSByZXBvcnRzIHJlYWR5U3RhdGUgYW5kIG5ldHdvcmtTdGF0ZSBjaGFuZ2VzIHNlcGFyYXRl bHkKLSAgICAgICAgTWVkaWFQbGF5ZXI6OlJlYWR5U3RhdGUgY3VycmVudFN0YXRlID0gbV9wbGF5 ZXItPnJlYWR5U3RhdGUoKTsKLSAgICAgICAgaWYgKHN0YXRpY19jYXN0PFJlYWR5U3RhdGU+KGN1 cnJlbnRTdGF0ZSkgIT0gbV9yZWFkeVN0YXRlKQotICAgICAgICAgICAgc2V0UmVhZHlTdGF0ZShj dXJyZW50U3RhdGUpOworICAgICAgICAgICAgLy8gQ2hlY2sgdG8gc2VlIGlmIHJlYWR5U3RhdGUg Y2hhbmdlcyBuZWVkIHRvIGJlIGRlYWx0IHdpdGggYmVmb3JlIHNlbmRpbmcgdGhlIAorICAgICAg ICAgICAgLy8gJ2xvYWQnIGV2ZW50IHNvIHdlIHJlcG9ydCAnY2FucGxheXRocm91Z2gnIGZpcnN0 LiBUaGlzIGlzIG5lY2Vzc2FyeSBiZWNhdXNlIGEKKyAgICAgICAgICAgIC8vICBtZWRpYSBlbmdp bmUgcmVwb3J0cyByZWFkeVN0YXRlIGFuZCBuZXR3b3JrU3RhdGUgY2hhbmdlcyBzZXBhcmF0ZWx5 CisgICAgICAgICAgICBNZWRpYVBsYXllcjo6UmVhZHlTdGF0ZSBjdXJyZW50U3RhdGUgPSBtX3Bs YXllci0+cmVhZHlTdGF0ZSgpOworICAgICAgICAgICAgaWYgKHN0YXRpY19jYXN0PFJlYWR5U3Rh dGU+KGN1cnJlbnRTdGF0ZSkgIT0gbV9yZWFkeVN0YXRlKQorICAgICAgICAgICAgICAgIHNldFJl YWR5U3RhdGUoY3VycmVudFN0YXRlKTsKIAotICAgICAgICAgc2NoZWR1bGVQcm9ncmVzc0V2ZW50 KGV2ZW50TmFtZXMoKS5sb2FkRXZlbnQpOyAKKyAgICAgICAgICAgICBzY2hlZHVsZVByb2dyZXNz RXZlbnQoZXZlbnROYW1lcygpLmxvYWRFdmVudCk7IAorICAgICAgICB9CiAgICAgfQogfQogCg==