249627 2022-12-19 18:02:30 -0800 option and optgroup shouldn't be focusable if they are hidden or in a menulist 2023-05-31 14:40:17 -0700 1 1 1 Unclassified WebKit Forms Safari Technology Preview Unspecified Unspecified RESOLVED FIXED BrowserCompat, InRadar P2 Normal --- 1 ahmad.saleem792 webkit-unassigned akeerthi cdumez karlcow rniwa webkit-bug-importer wenson_hsieh oldest_to_newest 1920668 0 ahmad.saleem792 2022-12-19 18:02:30 -0800 Hi Team, While going through Blink's commit, I came across few more test cases failure: Test Case - https://jsfiddle.net/n80ompfr/show ^ Safari 16.2 and STP160 both fail a single test case while Chrome Canary 111 and Firefox Nightly 110 passes all. Test Case - 2 - https://jsfiddle.net/grwehdk6/show ^ Safari 16.2 and STP160 both fail two test cases while Chrome Canary 111 and Firefox Nightly 110 passes all. Blink Commit - https://chromium.googlesource.com/chromium/blink/+/db4eb7807f1591c3beebe2e40a3c57d9e57a3c85 Just wanted to raise this bug so we can track this. Might try to do PR later. Thanks! 1920689 1 rniwa 2022-12-19 19:29:13 -0800 Seems sensible to merge this. 1921961 2 webkit-bug-importer 2022-12-26 18:03:15 -0800 <rdar://problem/103717395> 1958867 3 ahmad.saleem792 2023-05-30 13:36:33 -0700 Just need to add: RefPtr select = ownerSelectElement(); if (select && select->usesMenuList()) return false; return HTMLElement::isFocusable(); in HTMLOptionElement::isFocusable() and HTMLOptGroupElement::isFocusable(), no need to introduce new functions like Blink patch. Just fixed it locally, will do PR shortly. 1958878 4 ahmad.saleem792 2023-05-30 13:55:39 -0700 Fingers Crossed - https://github.com/WebKit/WebKit/pull/14507 1959155 5 ews-feeder 2023-05-31 14:40:15 -0700 Committed 264755@main (b9e0d14b62e6): <https://commits.webkit.org/264755@main> Reviewed commits have been landed. Closing PR #14507 and removing active labels.