249564 2022-12-18 17:07:13 -0800 KeyError: '__spec__' in apipkg.py with Python v3.11 2023-03-08 08:47:03 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=253572 InRadar P2 Normal --- 1 fujii fujii don.olmstead ews-watchlist glenn jbedard lmoura webkit-bug-importer oldest_to_newest 1920394 0 fujii 2022-12-18 17:07:13 -0800 WinCairo-64-bit-Debug-Tests is reporting test-webkitpy failure. https://build.webkit.org/#/builders/727/builds/59 This is reproduce on my PC with Python v3.11. Downloading py-1.5.2... Installing py-1.5.2... Installed py-1.5.2! Checking imports ...Traceback (most recent call last): File "C:\home\webkit\gc\Tools\Scripts\libraries\autoinstalled\python-3-AMD64\py\_vendored_packages\apipkg.py", line 141, in __makeattr modpath, attrname = self.__map__[name] ~~~~~~~~~~~~^^^^^^ KeyError: '__spec__' During handling of the above exception, another exception occurred: Traceback (most recent call last): File "C:\home\webkit\gc\Tools\Scripts\webkitpy\test\main.py", line 366, in <module> sys.exit(main()) ^^^^^^ File "C:\home\webkit\gc\Tools\Scripts\webkitpy\test\main.py", line 115, in main return not tester.run() ^^^^^^^^^^^^ File "C:\home\webkit\gc\Tools\Scripts\webkitpy\test\main.py", line 188, in run return self._run_tests(names) ^^^^^^^^^^^^^^^^^^^^^^ File "C:\home\webkit\gc\Tools\Scripts\webkitpy\test\main.py", line 217, in _run_tests if not self._check_imports(names): ^^^^^^^^^^^^^^^^^^^^^^^^^^ File "C:\home\webkit\gc\Tools\Scripts\webkitpy\test\main.py", line 300, in _check_imports __import__(name) File "C:\home\webkit\gc\Tools\Scripts\webkitpy\common\config\committers_unittest.py", line 31, in <module> from webkitpy.test.markers import xfail File "C:\home\webkit\gc\Tools\Scripts\webkitpy\test\markers.py", line 26, in <module> import pytest File "C:\home\webkit\gc\Tools\Scripts\libraries\autoinstalled\python-3-AMD64\pytest\__init__.py", line 5, in <module> from _pytest.assertion import register_assert_rewrite File "C:\home\webkit\gc\Tools\Scripts\libraries\autoinstalled\python-3-AMD64\_pytest\assertion\__init__.py", line 9, in <module> from _pytest.assertion import rewrite File "C:\home\webkit\gc\Tools\Scripts\libraries\autoinstalled\python-3-AMD64\_pytest\assertion\rewrite.py", line 34, in <module> from _pytest.assertion import util File "C:\home\webkit\gc\Tools\Scripts\libraries\autoinstalled\python-3-AMD64\_pytest\assertion\util.py", line 13, in <module> import _pytest._code File "C:\home\webkit\gc\Tools\Scripts\libraries\autoinstalled\python-3-AMD64\_pytest\_code\__init__.py", line 2, in <module> from .code import Code File "C:\home\webkit\gc\Tools\Scripts\libraries\autoinstalled\python-3-AMD64\_pytest\_code\code.py", line 54, in <module> class Code: File "C:\home\webkit\gc\Tools\Scripts\libraries\autoinstalled\python-3-AMD64\_pytest\_code\code.py", line 81, in Code def path(self) -> Union[py.path.local, str]: ^^^^^^^^^^^^^ File "C:\home\webkit\gc\Tools\Scripts\libraries\autoinstalled\python-3-AMD64\py\_vendored_packages\apipkg.py", line 148, in __makeattr result = importobj(modpath, attrname) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "C:\home\webkit\gc\Tools\Scripts\libraries\autoinstalled\python-3-AMD64\py\_vendored_packages\apipkg.py", line 69, in importobj module = __import__(modpath, None, None, ['__doc__']) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "<frozen importlib._bootstrap>", line 1178, in _find_and_load File "<frozen importlib._bootstrap>", line 1138, in _find_and_load_unlocked File "C:\home\webkit\gc\Tools\Scripts\libraries\autoinstalled\python-3-AMD64\py\_vendored_packages\apipkg.py", line 146, in __makeattr raise AttributeError(name) AttributeError: __spec__ 1920396 1 fujii 2022-12-18 17:34:57 -0800 This problem was fixed by upstream. AttributeError __spec__ on Python 3.11 · Issue #273 · pytest-dev/py https://github.com/pytest-dev/py/issues/273 I tryed py 1.11.0. https://pypi.org/project/py/1.11.0/ diff --git a/Tools/Scripts/webkitpy/__init__.py b/Tools/Scripts/webkitpy/__init__.py index 7cc6593c1ef8..babfc798fdac 100644 --- a/Tools/Scripts/webkitpy/__init__.py +++ b/Tools/Scripts/webkitpy/__init__.py @@ -69,7 +69,7 @@ AutoInstall.register(Package('mozprocess', Version(1, 3, 0))) AutoInstall.register(Package('mozlog', Version(7, 1, 0), wheel=True)) AutoInstall.register(Package('mozterm', Version(1, 0, 0))) AutoInstall.register(Package('pluggy', Version(0, 13, 1))) -AutoInstall.register(Package('py', Version(1, 5, 2))) +AutoInstall.register(Package('py', Version(1, 11, 0))) AutoInstall.register(Package('pycodestyle', Version(2, 5, 0))) AutoInstall.register(Package('pyfakefs', Version(3, 7, 2))) AutoInstall.register(Package('scandir', Version(1, 10, 0))) Then, all tests failed: > [727/1813] webkitpy.layout_tests.run_webkit_tests_integrationtest.RunTest.test_output_diffs.test_output_diffs erred: > AttributeError: 'function' object has no attribute 'test_output_diffs' > > [728/1813] webkitpy.layout_tests.run_webkit_tests_integrationtest.RunTest.test_pixel_test_directories.test_pixel_test_directories erred: > AttributeError: 'function' object has no attribute 'test_pixel_test_directories' 1920411 2 fujii 2022-12-18 21:12:01 -0800 (In reply to Fujii Hironori from comment #1) > Then, all tests failed: Created another bug: Bug 249568 – Use unittest.TestCase.id() to get the test name instead of regexp matching 1920548 3 464106 fujii 2022-12-19 12:38:54 -0800 Created attachment 464106 Patch 1920551 4 464107 fujii 2022-12-19 13:00:03 -0800 Created attachment 464107 Patch 1920905 5 464107 fujii 2022-12-20 14:01:26 -0800 Comment on attachment 464107 Patch Thank you for the review. 1920918 6 ews-feeder 2022-12-20 15:10:56 -0800 Committed 258166@main (7177e82d539f): <https://commits.webkit.org/258166@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 464107. 1920919 7 webkit-bug-importer 2022-12-20 15:11:19 -0800 <rdar://problem/103573028> 464106 2022-12-19 12:38:54 -0800 2022-12-19 12:53:09 -0800 Patch bug-249564-20221220053852.patch text/plain 2501 fujii RnJvbSA4YTIzOTYzYTI3MWM1OGI2MjE5Zjg2NTk0YTFiNTZmZTU0ZmVjMWEyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBIaXJvbm9yaSA8SGlyb25vcmkuRnVqaWlAc29ueS5j b20+CkRhdGU6IFR1ZSwgMjAgRGVjIDIwMjIgMDU6MzA6MDIgKzA5MDAKU3ViamVjdDogW1BBVENI XSBLZXlFcnJvcjogJ19fc3BlY19fJyBpbiBhcGlwa2cucHkgd2l0aCBQeXRob24gdjMuMTEKIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDk1NjQKClJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgoKdGVzdC13ZWJraXRweSB3YXMgZmFpbGluZyB0byBydW4gd2l0aCBQ eXRob24gMy4xMS4gQXR0cmlidXRlRXJyb3IKZXhjZXB0aW9uIHdhcyB0aHJvd24gaW4gYXBpcGtn LnB5IG9mIHB5LiBUaGUgbGF0ZXN0IHB5IDEuMTEuMCBmaXhlZAp0aGUgcHJvYmxlbS4KPGh0dHBz Oi8vZ2l0aHViLmNvbS9weXRlc3QtZGV2L3B5L2lzc3Vlcy8yNzM+CgpVcGdyYWRlZCBhbGwgcHl0 ZXN0IHJlbGF0ZWQgbW9kdWxlcyB0byB0aGUgbGF0ZXN0LiBUaGV5IHN1cHBvcnQgUHl0aG9uCjMu Ny4KCiogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9fX2luaXRfXy5weToKLS0tCiBUb29scy9TY3Jp cHRzL3dlYmtpdHB5L19faW5pdF9fLnB5IHwgOCArKysrLS0tLQogMSBmaWxlIGNoYW5nZWQsIDQg aW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L19faW5pdF9fLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9fX2luaXRfXy5w eQppbmRleCA3Y2M2NTkzYzFlZjguLjcwNzMzMzFhYTQ5YyAxMDA2NDQKLS0tIGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9fX2luaXRfXy5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L19f aW5pdF9fLnB5CkBAIC0zNiw5ICszNiw5IEBAIEF1dG9JbnN0YWxsLnNldF9kaXJlY3Rvcnkob3Mu cGF0aC5qb2luKGxpYnJhcmllcywgJ2F1dG9pbnN0YWxsZWQnLCAncHl0aG9uLXt9LXt9CiAKIGlm IHN5cy52ZXJzaW9uX2luZm8gPj0gKDMsIDYpOgogICAgIEF1dG9JbnN0YWxsLnJlZ2lzdGVyKFBh Y2thZ2UoJ3B5bGludCcsIFZlcnNpb24oMiwgNiwgMCkpKQotICAgIEF1dG9JbnN0YWxsLnJlZ2lz dGVyKFBhY2thZ2UoJ3B5dGVzdF9hc3luY2lvJywgVmVyc2lvbigwLCAxNCksIHB5cGlfbmFtZT0n cHl0ZXN0LWFzeW5jaW8nKSkKLSAgICBBdXRvSW5zdGFsbC5yZWdpc3RlcihQYWNrYWdlKCdweXRl c3RfdGltZW91dCcsIFZlcnNpb24oMSwgNCwgMiksIHB5cGlfbmFtZT0ncHl0ZXN0LXRpbWVvdXQn KSkKLSAgICBBdXRvSW5zdGFsbC5yZWdpc3RlcihQYWNrYWdlKCdweXRlc3QnLCBWZXJzaW9uKDYs IDIsIDUpLCBpbXBsaWNpdF9kZXBzPVsncHl0ZXN0X2FzeW5jaW8nLCAncHl0ZXN0X3RpbWVvdXQn XSkpCisgICAgQXV0b0luc3RhbGwucmVnaXN0ZXIoUGFja2FnZSgncHl0ZXN0X2FzeW5jaW8nLCBW ZXJzaW9uKDAsIDIwLCAzKSwgcHlwaV9uYW1lPSdweXRlc3QtYXN5bmNpbycpKQorICAgIEF1dG9J bnN0YWxsLnJlZ2lzdGVyKFBhY2thZ2UoJ3B5dGVzdF90aW1lb3V0JywgVmVyc2lvbigyLCAxLCAw KSwgcHlwaV9uYW1lPSdweXRlc3QtdGltZW91dCcpKQorICAgIEF1dG9JbnN0YWxsLnJlZ2lzdGVy KFBhY2thZ2UoJ3B5dGVzdCcsIFZlcnNpb24oNywgMiwgMCksIGltcGxpY2l0X2RlcHM9WydweXRl c3RfYXN5bmNpbycsICdweXRlc3RfdGltZW91dCddKSkKICAgICBBdXRvSW5zdGFsbC5yZWdpc3Rl cihQYWNrYWdlKCd3ZWJzb2NrZXRzJywgVmVyc2lvbig4LCAxKSkpCiBlbGlmIHN5cy52ZXJzaW9u X2luZm8gPj0gKDIsIDcpIGFuZCBzeXMudmVyc2lvbl9pbmZvIDwgKDMsKToKICAgICBBdXRvSW5z dGFsbC5yZWdpc3RlcihQYWNrYWdlKCdweWxpbnQnLCBWZXJzaW9uKDAsIDI4LCAwKSkpCkBAIC02 OSw3ICs2OSw3IEBAIEF1dG9JbnN0YWxsLnJlZ2lzdGVyKFBhY2thZ2UoJ21venByb2Nlc3MnLCBW ZXJzaW9uKDEsIDMsIDApKSkKIEF1dG9JbnN0YWxsLnJlZ2lzdGVyKFBhY2thZ2UoJ21vemxvZycs IFZlcnNpb24oNywgMSwgMCksIHdoZWVsPVRydWUpKQogQXV0b0luc3RhbGwucmVnaXN0ZXIoUGFj a2FnZSgnbW96dGVybScsIFZlcnNpb24oMSwgMCwgMCkpKQogQXV0b0luc3RhbGwucmVnaXN0ZXIo UGFja2FnZSgncGx1Z2d5JywgVmVyc2lvbigwLCAxMywgMSkpKQotQXV0b0luc3RhbGwucmVnaXN0 ZXIoUGFja2FnZSgncHknLCBWZXJzaW9uKDEsIDUsIDIpKSkKK0F1dG9JbnN0YWxsLnJlZ2lzdGVy KFBhY2thZ2UoJ3B5JywgVmVyc2lvbigxLCAxMSwgMCkpKQogQXV0b0luc3RhbGwucmVnaXN0ZXIo UGFja2FnZSgncHljb2Rlc3R5bGUnLCBWZXJzaW9uKDIsIDUsIDApKSkKIEF1dG9JbnN0YWxsLnJl Z2lzdGVyKFBhY2thZ2UoJ3B5ZmFrZWZzJywgVmVyc2lvbigzLCA3LCAyKSkpCiBBdXRvSW5zdGFs bC5yZWdpc3RlcihQYWNrYWdlKCdzY2FuZGlyJywgVmVyc2lvbigxLCAxMCwgMCkpKQo= 464107 2022-12-19 13:00:03 -0800 2022-12-20 15:10:57 -0800 Patch bug-249564-20221220060002.patch text/plain 2793 fujii RnJvbSA3OGU5ZjRiYTE2ZDQ1YWY0ZTUyODdkNGFlMDMwNDU5NzZmOGUxNTU4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBIaXJvbm9yaSA8SGlyb25vcmkuRnVqaWlAc29ueS5j b20+CkRhdGU6IFR1ZSwgMjAgRGVjIDIwMjIgMDU6MzA6MDIgKzA5MDAKU3ViamVjdDogW1BBVENI XSBLZXlFcnJvcjogJ19fc3BlY19fJyBpbiBhcGlwa2cucHkgd2l0aCBQeXRob24gdjMuMTEKIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDk1NjQKClJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgoKdGVzdC13ZWJraXRweSB3YXMgZmFpbGluZyB0byBydW4gd2l0aCBQ eXRob24gMy4xMS4gQXR0cmlidXRlRXJyb3IKZXhjZXB0aW9uIHdhcyB0aHJvd24gaW4gYXBpcGtn LnB5IG9mIHB5LiBUaGUgbGF0ZXN0IHB5IDEuMTEuMCBmaXhlZAp0aGUgcHJvYmxlbS4KPGh0dHBz Oi8vZ2l0aHViLmNvbS9weXRlc3QtZGV2L3B5L2lzc3Vlcy8yNzM+CgpVcGdyYWRlZCBhbGwgcHl0 ZXN0IHJlbGF0ZWQgbW9kdWxlcyB0byB0aGUgbGF0ZXN0LgpweSAxLjExLjAgc3VwcG9ydHMgUHl0 aG9uIDIuNyBhbmQgPjMuNS4KcHl0ZXN0IDcuMi4wIGFuZCBweXRlc3QtYXN5bmNpbyAwLjIwLjMg c3VwcG9ydCBQeXRob24gPjMuNy4KcHl0ZXN0LXRpbWVvdXQgMi4xLjAgc3VwcG9ydHMgUHl0aG9u ID4zLjYuCgoqIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvX19pbml0X18ucHk6Ci0tLQogVG9vbHMv U2NyaXB0cy93ZWJraXRweS9fX2luaXRfXy5weSB8IDEwICsrKysrLS0tLS0KIDEgZmlsZSBjaGFu Z2VkLCA1IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9fX2luaXRfXy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvX19p bml0X18ucHkKaW5kZXggN2NjNjU5M2MxZWY4Li5kMWE5ZjFlMTcxMzggMTAwNjQ0Ci0tLSBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvX19pbml0X18ucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9fX2luaXRfXy5weQpAQCAtMzQsMTEgKzM0LDExIEBAIGlmIHN5cy5wbGF0Zm9ybSA9PSAn ZGFyd2luJzoKIGZyb20gd2Via2l0Y29yZXB5IGltcG9ydCBBdXRvSW5zdGFsbCwgUGFja2FnZSwg VmVyc2lvbgogQXV0b0luc3RhbGwuc2V0X2RpcmVjdG9yeShvcy5wYXRoLmpvaW4obGlicmFyaWVz LCAnYXV0b2luc3RhbGxlZCcsICdweXRob24te30te30nLmZvcm1hdChzeXMudmVyc2lvbl9pbmZv WzBdLCBwbGF0Zm9ybS5tYWNoaW5lKCkpKSkKIAotaWYgc3lzLnZlcnNpb25faW5mbyA+PSAoMywg Nik6CitpZiBzeXMudmVyc2lvbl9pbmZvID49ICgzLCA3KToKICAgICBBdXRvSW5zdGFsbC5yZWdp c3RlcihQYWNrYWdlKCdweWxpbnQnLCBWZXJzaW9uKDIsIDYsIDApKSkKLSAgICBBdXRvSW5zdGFs bC5yZWdpc3RlcihQYWNrYWdlKCdweXRlc3RfYXN5bmNpbycsIFZlcnNpb24oMCwgMTQpLCBweXBp X25hbWU9J3B5dGVzdC1hc3luY2lvJykpCi0gICAgQXV0b0luc3RhbGwucmVnaXN0ZXIoUGFja2Fn ZSgncHl0ZXN0X3RpbWVvdXQnLCBWZXJzaW9uKDEsIDQsIDIpLCBweXBpX25hbWU9J3B5dGVzdC10 aW1lb3V0JykpCi0gICAgQXV0b0luc3RhbGwucmVnaXN0ZXIoUGFja2FnZSgncHl0ZXN0JywgVmVy c2lvbig2LCAyLCA1KSwgaW1wbGljaXRfZGVwcz1bJ3B5dGVzdF9hc3luY2lvJywgJ3B5dGVzdF90 aW1lb3V0J10pKQorICAgIEF1dG9JbnN0YWxsLnJlZ2lzdGVyKFBhY2thZ2UoJ3B5dGVzdF9hc3lu Y2lvJywgVmVyc2lvbigwLCAyMCwgMyksIHB5cGlfbmFtZT0ncHl0ZXN0LWFzeW5jaW8nKSkKKyAg ICBBdXRvSW5zdGFsbC5yZWdpc3RlcihQYWNrYWdlKCdweXRlc3RfdGltZW91dCcsIFZlcnNpb24o MiwgMSwgMCksIHB5cGlfbmFtZT0ncHl0ZXN0LXRpbWVvdXQnKSkKKyAgICBBdXRvSW5zdGFsbC5y ZWdpc3RlcihQYWNrYWdlKCdweXRlc3QnLCBWZXJzaW9uKDcsIDIsIDApLCBpbXBsaWNpdF9kZXBz PVsncHl0ZXN0X2FzeW5jaW8nLCAncHl0ZXN0X3RpbWVvdXQnXSkpCiAgICAgQXV0b0luc3RhbGwu cmVnaXN0ZXIoUGFja2FnZSgnd2Vic29ja2V0cycsIFZlcnNpb24oOCwgMSkpKQogZWxpZiBzeXMu dmVyc2lvbl9pbmZvID49ICgyLCA3KSBhbmQgc3lzLnZlcnNpb25faW5mbyA8ICgzLCk6CiAgICAg QXV0b0luc3RhbGwucmVnaXN0ZXIoUGFja2FnZSgncHlsaW50JywgVmVyc2lvbigwLCAyOCwgMCkp KQpAQCAtNjksNyArNjksNyBAQCBBdXRvSW5zdGFsbC5yZWdpc3RlcihQYWNrYWdlKCdtb3pwcm9j ZXNzJywgVmVyc2lvbigxLCAzLCAwKSkpCiBBdXRvSW5zdGFsbC5yZWdpc3RlcihQYWNrYWdlKCdt b3psb2cnLCBWZXJzaW9uKDcsIDEsIDApLCB3aGVlbD1UcnVlKSkKIEF1dG9JbnN0YWxsLnJlZ2lz dGVyKFBhY2thZ2UoJ21venRlcm0nLCBWZXJzaW9uKDEsIDAsIDApKSkKIEF1dG9JbnN0YWxsLnJl Z2lzdGVyKFBhY2thZ2UoJ3BsdWdneScsIFZlcnNpb24oMCwgMTMsIDEpKSkKLUF1dG9JbnN0YWxs LnJlZ2lzdGVyKFBhY2thZ2UoJ3B5JywgVmVyc2lvbigxLCA1LCAyKSkpCitBdXRvSW5zdGFsbC5y ZWdpc3RlcihQYWNrYWdlKCdweScsIFZlcnNpb24oMSwgMTEsIDApKSkKIEF1dG9JbnN0YWxsLnJl Z2lzdGVyKFBhY2thZ2UoJ3B5Y29kZXN0eWxlJywgVmVyc2lvbigyLCA1LCAwKSkpCiBBdXRvSW5z dGFsbC5yZWdpc3RlcihQYWNrYWdlKCdweWZha2VmcycsIFZlcnNpb24oMywgNywgMikpKQogQXV0 b0luc3RhbGwucmVnaXN0ZXIoUGFja2FnZSgnc2NhbmRpcicsIFZlcnNpb24oMSwgMTAsIDApKSkK