<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>249452</bug_id>
          
          <creation_ts>2022-12-15 23:05:26 -0800</creation_ts>
          <short_desc>REGRESSION(257681@main) [WebDriver] Invalid WebPageProxy references after RefPtr moved into callbacks</short_desc>
          <delta_ts>2022-12-16 07:43:17 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebDriver</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=248912</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Lauro Moura">lmoura</reporter>
          <assigned_to name="Lauro Moura">lmoura</assigned_to>
          <cc>bburg</cc>
    
    <cc>cgarcia</cc>
    
    <cc>ddkilzer</cc>
    
    <cc>ggaren</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1919826</commentid>
    <comment_count>0</comment_count>
    <who name="Lauro Moura">lmoura</who>
    <bug_when>2022-12-15 23:05:26 -0800</bug_when>
    <thetext>257681@main replaced plain WebPageProxy pointers with RefPtr, but IIUC, it also WTFMove&apos;d some of these RefPtr into lambda captures while they were still used outside leading to invalid references. For example, being passed into a WebProcessProxy&amp; parameter in the exitFullscreenWindowForPage() call inside setWindowFrameOfBrowsingContext() in [1]. When exit... executed, the page parameter received was (nil) after being moved.

As this happened in some WebAutomationSession methods used during the setup of many tests, the failures in the webdriver suite increased from ~23 to ~2008.

First build with failure: https://build.webkit.org/#/builders/37/builds/13372

Patch incoming.

[1] https://github.com/WebKit/WebKit/blob/main/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp#L417</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1919830</commentid>
    <comment_count>1</comment_count>
    <who name="Lauro Moura">lmoura</who>
    <bug_when>2022-12-15 23:43:01 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/7737</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1919928</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-12-16 07:42:49 -0800</bug_when>
    <thetext>Committed 257988@main (7301504e0c22): &lt;https://commits.webkit.org/257988@main&gt;

Reviewed commits have been landed. Closing PR #7737 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1919929</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-12-16 07:43:17 -0800</bug_when>
    <thetext>&lt;rdar://problem/103447051&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>