249431 2022-12-15 14:45:51 -0800 [IFC][Integration] RenderBox should not call first/lastLineBox on RenderInline 2022-12-16 08:50:11 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham changseok esprehn+autocc ews-watchlist glenn koivisto kondapallykalyan pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1919728 0 zalan 2022-12-15 14:45:51 -0800 use the iterator interface instead. 1919729 1 464063 zalan 2022-12-15 14:48:09 -0800 Created attachment 464063 [fast-cq]Patch 1919938 2 464063 koivisto 2022-12-16 08:02:38 -0800 Comment on attachment 464063 [fast-cq]Patch View in context: https://bugs.webkit.org/attachment.cgi?id=464063&action=review > Source/WebCore/rendering/RenderBox.cpp:3946 > + auto inlineBox = firstInlineBox; > + for (; inlineBox->nextInlineBox(); inlineBox.traverseNextInlineBox()) { } > + return inlineBox; Should add lastInlineBoxFor at some point 1919945 3 ews-feeder 2022-12-16 08:42:23 -0800 Committed 257992@main (cf7c7c33a97c): <https://commits.webkit.org/257992@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 464063. 1919946 4 webkit-bug-importer 2022-12-16 08:43:18 -0800 <rdar://problem/103448489> 1919947 5 zalan 2022-12-16 08:50:11 -0800 (In reply to Antti Koivisto from comment #2) > Comment on attachment 464063 [details] > [fast-cq]Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=464063&action=review > > > Source/WebCore/rendering/RenderBox.cpp:3946 > > + auto inlineBox = firstInlineBox; > > + for (; inlineBox->nextInlineBox(); inlineBox.traverseNextInlineBox()) { } > > + return inlineBox; > > Should add lastInlineBoxFor at some point totally 464063 2022-12-15 14:48:09 -0800 2022-12-16 08:42:24 -0800 [fast-cq]Patch bug-249431-20221215144808.patch text/plain 5739 zalan RnJvbSA2ZmE5OWI0ZTRkYjAyYTNmZThiNDg2MzQyNTM5NGFkNzM3N2U5YzkxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJhcmFkbGF5IDx6YWxhbkBhcHBsZS5jb20+CkRhdGU6 IFRodSwgMTUgRGVjIDIwMjIgMTQ6NDY6MDkgLTA4MDAKU3ViamVjdDogW1BBVENIXSBbSUZDXVtJ bnRlZ3JhdGlvbl0gUmVuZGVyQm94IHNob3VsZCBub3QgY2FsbAogZmlyc3QvbGFzdExpbmVCb3gg b24gUmVuZGVySW5saW5lCiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjQ5NDMxCgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KClVzZSB0aGUgSW5saW5lSXRlcmF0 b3IgaW50ZXJmYWNlIHRvIHF1ZXJ5IGlubGluZSBib3ggZ2VvbWV0cnkuClRoaXMgcGF0Y2ggaXMg YWxzbyBpbiBwcmVwYXJhdGlvbiBmb3IgYWRkaW5nIFJUTCBvdXQtb2YtZmxvdyBzdXBwb3J0IGZv ciBJRkMuCgoqIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guY3BwOgooV2ViQ29y ZTo6cG9zaXRpb25XaXRoUlRMSW5saW5lQm94Q29udGFpbmluZ0Jsb2NrKToKKFdlYkNvcmU6OlJl bmRlckJveDo6Y29tcHV0ZVBvc2l0aW9uZWRMb2dpY2FsV2lkdGhVc2luZyBjb25zdCk6CihXZWJD b3JlOjpSZW5kZXJCb3g6OmNvbXB1dGVQb3NpdGlvbmVkTG9naWNhbFdpZHRoUmVwbGFjZWQgY29u c3QpOgotLS0KIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guY3BwIHwgNTMgKysr KysrKysrKysrKysrKystLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAzNCBpbnNlcnRpb25zKCsp LCAxOSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyQm94LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guY3BwCmlu ZGV4IDg2MDdmYTYwMjkwOC4uM2MxZmQ1NjUzZDM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyQm94LmNwcApAQCAtMzkzMCw2ICszOTMwLDMxIEBAIHN0YXRpYyB2b2lkIGNvbXB1dGVM b2dpY2FsTGVmdFBvc2l0aW9uZWRPZmZzZXQoTGF5b3V0VW5pdCYgbG9naWNhbExlZnRQb3MsIGNv bnN0CiAgICAgICAgIGxvZ2ljYWxMZWZ0UG9zICs9IChjaGlsZC0+aXNIb3Jpem9udGFsV3JpdGlu Z01vZGUoKSA/IGNvbnRhaW5lckJsb2NrLmJvcmRlckxlZnQoKSA6IGNvbnRhaW5lckJsb2NrLmJv cmRlclRvcCgpKTsKIH0KIAorc3RhdGljIHN0ZDo6b3B0aW9uYWw8ZmxvYXQ+IHBvc2l0aW9uV2l0 aFJUTElubGluZUJveENvbnRhaW5pbmdCbG9jayhjb25zdCBSZW5kZXJFbGVtZW50JiBjb250YWlu aW5nQmxvY2ssIExheW91dFVuaXQgbG9naWNhbExlZnRWYWx1ZSwgTGF5b3V0VW5pdCBtYXJnaW5M b2dpY2FsTGVmdFZhbHVlKQoreworICAgIGlmICghaXM8UmVuZGVySW5saW5lPihjb250YWluaW5n QmxvY2spIHx8IGNvbnRhaW5pbmdCbG9jay5zdHlsZSgpLmlzTGVmdFRvUmlnaHREaXJlY3Rpb24o KSkKKyAgICAgICAgcmV0dXJuIHsgfTsKKworICAgIGF1dG8mIHJlbmRlcklubGluZSA9IGRvd25j YXN0PFJlbmRlcklubGluZT4oY29udGFpbmluZ0Jsb2NrKTsKKyAgICBhdXRvIGZpcnN0SW5saW5l Qm94ID0gSW5saW5lSXRlcmF0b3I6OmZpcnN0SW5saW5lQm94Rm9yKHJlbmRlcklubGluZSk7Cisg ICAgaWYgKCFmaXJzdElubGluZUJveCkKKyAgICAgICAgcmV0dXJuIHsgfTsKKworICAgIGF1dG8g bGFzdElubGluZUJveCA9IFsmXSB7CisgICAgICAgIGF1dG8gaW5saW5lQm94ID0gZmlyc3RJbmxp bmVCb3g7CisgICAgICAgIGZvciAoOyBpbmxpbmVCb3gtPm5leHRJbmxpbmVCb3goKTsgaW5saW5l Qm94LnRyYXZlcnNlTmV4dElubGluZUJveCgpKSB7IH0KKyAgICAgICAgcmV0dXJuIGlubGluZUJv eDsKKyAgICB9KCk7CisgICAgaWYgKGZpcnN0SW5saW5lQm94ID09IGxhc3RJbmxpbmVCb3gpCisg ICAgICAgIHJldHVybiB7IH07CisKKyAgICBhdXRvIGxhc3RJbmxpbmVCb3hQYWRkaW5nQm94Vmlz dWFsUmlnaHQgPSBsYXN0SW5saW5lQm94LT5sb2dpY2FsTGVmdCgpICsgcmVuZGVySW5saW5lLmJv cmRlckxvZ2ljYWxMZWZ0KCk7CisgICAgLy8gRklYTUU6IFRoaXMgZG9lcyBub3Qgd29yayB3aXRo IGRlY29yYXRpb24gYnJlYWsgY2xvbmUuCisgICAgYXV0byBmaXJzdElubGluZUJveFBhZGRpbmdC b3hWaXN1YWxSaWdodCA9IGZpcnN0SW5saW5lQm94LT5sb2dpY2FsTGVmdCgpOworICAgIGF1dG8g ZGlzdGFuY2UgPSBsYXN0SW5saW5lQm94UGFkZGluZ0JveFZpc3VhbFJpZ2h0IC0gZmlyc3RJbmxp bmVCb3hQYWRkaW5nQm94VmlzdWFsUmlnaHQ7CisgICAgcmV0dXJuIGxvZ2ljYWxMZWZ0VmFsdWUg KyBtYXJnaW5Mb2dpY2FsTGVmdFZhbHVlICsgZGlzdGFuY2U7Cit9CisKIHZvaWQgUmVuZGVyQm94 Ojpjb21wdXRlUG9zaXRpb25lZExvZ2ljYWxXaWR0aFVzaW5nKFNpemVUeXBlIHdpZHRoVHlwZSwg TGVuZ3RoIGxvZ2ljYWxXaWR0aCwgY29uc3QgUmVuZGVyQm94TW9kZWxPYmplY3QmIGNvbnRhaW5l ckJsb2NrLCBUZXh0RGlyZWN0aW9uIGNvbnRhaW5lckRpcmVjdGlvbiwKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIExheW91dFVuaXQgY29udGFpbmVy TG9naWNhbFdpZHRoLCBMYXlvdXRVbml0IGJvcmRlcnNQbHVzUGFkZGluZywKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIExlbmd0aCBsb2dpY2FsTGVm dCwgTGVuZ3RoIGxvZ2ljYWxSaWdodCwgTGVuZ3RoIG1hcmdpbkxvZ2ljYWxMZWZ0LCBMZW5ndGgg bWFyZ2luTG9naWNhbFJpZ2h0LApAQCAtNDEwNiwxOCArNDEzMSwxMyBAQCB2b2lkIFJlbmRlckJv eDo6Y29tcHV0ZVBvc2l0aW9uZWRMb2dpY2FsV2lkdGhVc2luZyhTaXplVHlwZSB3aWR0aFR5cGUs IExlbmd0aCBsbwogCiAgICAgLy8gVXNlIGNvbXB1dGVkIHZhbHVlcyB0byBjYWxjdWxhdGUgdGhl IGhvcml6b250YWwgcG9zaXRpb24uCiAKLSAgICAvLyBGSVhNRTogVGhpcyBoYWNrIGlzIG5lZWRl ZCB0byBjYWxjdWxhdGUgdGhlICBsb2dpY2FsIGxlZnQgcG9zaXRpb24gZm9yIGEgJ3J0bCcgcmVs YXRpdmVseQorICAgIC8vIEZJWE1FOiBUaGlzIGhhY2sgaXMgbmVlZGVkIHRvIGNhbGN1bGF0ZSB0 aGUgbG9naWNhbCBsZWZ0IHBvc2l0aW9uIGZvciBhICdydGwnIHJlbGF0aXZlbHkKICAgICAvLyBw b3NpdGlvbmVkLCBpbmxpbmUgYmVjYXVzZSByaWdodCBub3csIGl0IGlzIHVzaW5nIHRoZSBsb2dp Y2FsIGxlZnQgcG9zaXRpb24KLSAgICAvLyBvZiB0aGUgZmlyc3QgbGluZSBib3ggd2hlbiByZWFs bHkgaXQgc2hvdWxkIHVzZSB0aGUgbGFzdCBsaW5lIGJveC4gIFdoZW4KKyAgICAvLyBvZiB0aGUg Zmlyc3QgbGluZSBib3ggd2hlbiByZWFsbHkgaXQgc2hvdWxkIHVzZSB0aGUgbGFzdCBsaW5lIGJv eC4gV2hlbgogICAgIC8vIHRoaXMgaXMgZml4ZWQgZWxzZXdoZXJlLCB0aGlzIGJsb2NrIHNob3Vs ZCBiZSByZW1vdmVkLgotICAgIGlmIChpczxSZW5kZXJJbmxpbmU+KGNvbnRhaW5lckJsb2NrKSAm JiAhY29udGFpbmVyQmxvY2suc3R5bGUoKS5pc0xlZnRUb1JpZ2h0RGlyZWN0aW9uKCkpIHsKLSAg ICAgICAgY29uc3QgYXV0byYgZmxvdyA9IGRvd25jYXN0PFJlbmRlcklubGluZT4oY29udGFpbmVy QmxvY2spOwotICAgICAgICBMZWdhY3lJbmxpbmVGbG93Qm94KiBmaXJzdExpbmUgPSBmbG93LmZp cnN0TGluZUJveCgpOwotICAgICAgICBMZWdhY3lJbmxpbmVGbG93Qm94KiBsYXN0TGluZSA9IGZs b3cubGFzdExpbmVCb3goKTsKLSAgICAgICAgaWYgKGZpcnN0TGluZSAmJiBsYXN0TGluZSAmJiBm aXJzdExpbmUgIT0gbGFzdExpbmUpIHsKLSAgICAgICAgICAgIGNvbXB1dGVkVmFsdWVzLm1fcG9z aXRpb24gPSBsb2dpY2FsTGVmdFZhbHVlICsgbWFyZ2luTG9naWNhbExlZnRWYWx1ZSArIGxhc3RM aW5lLT5ib3JkZXJMb2dpY2FsTGVmdCgpICsgKGxhc3RMaW5lLT5sb2dpY2FsTGVmdCgpIC0gZmly c3RMaW5lLT5sb2dpY2FsTGVmdCgpKTsKLSAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgfQor ICAgIGlmIChhdXRvIHBvc2l0aW9uID0gcG9zaXRpb25XaXRoUlRMSW5saW5lQm94Q29udGFpbmlu Z0Jsb2NrKGNvbnRhaW5lckJsb2NrLCBsb2dpY2FsTGVmdFZhbHVlLCBtYXJnaW5Mb2dpY2FsTGVm dFZhbHVlKSkgeworICAgICAgICBjb21wdXRlZFZhbHVlcy5tX3Bvc2l0aW9uID0gKnBvc2l0aW9u OworICAgICAgICByZXR1cm47CiAgICAgfQogCiAgICAgY29tcHV0ZWRWYWx1ZXMubV9wb3NpdGlv biA9IGxvZ2ljYWxMZWZ0VmFsdWUgKyBtYXJnaW5Mb2dpY2FsTGVmdFZhbHVlOwpAQCAtNDYwMCwx NiArNDYyMCwxMSBAQCB2b2lkIFJlbmRlckJveDo6Y29tcHV0ZVBvc2l0aW9uZWRMb2dpY2FsV2lk dGhSZXBsYWNlZChMb2dpY2FsRXh0ZW50Q29tcHV0ZWRWYWx1ZQogCiAgICAgLy8gRklYTUU6IFRo aXMgaGFjayBpcyBuZWVkZWQgdG8gY2FsY3VsYXRlIHRoZSBsb2dpY2FsIGxlZnQgcG9zaXRpb24g Zm9yIGEgJ3J0bCcgcmVsYXRpdmVseQogICAgIC8vIHBvc2l0aW9uZWQsIGlubGluZSBjb250YWlu aW5nIGJsb2NrIGJlY2F1c2UgcmlnaHQgbm93LCBpdCBpcyB1c2luZyB0aGUgbG9naWNhbCBsZWZ0 IHBvc2l0aW9uCi0gICAgLy8gb2YgdGhlIGZpcnN0IGxpbmUgYm94IHdoZW4gcmVhbGx5IGl0IHNo b3VsZCB1c2UgdGhlIGxhc3QgbGluZSBib3guICBXaGVuCisgICAgLy8gb2YgdGhlIGZpcnN0IGxp bmUgYm94IHdoZW4gcmVhbGx5IGl0IHNob3VsZCB1c2UgdGhlIGxhc3QgbGluZSBib3guIFdoZW4K ICAgICAvLyB0aGlzIGlzIGZpeGVkIGVsc2V3aGVyZSwgdGhpcyBibG9jayBzaG91bGQgYmUgcmVt b3ZlZC4KLSAgICBpZiAoaXM8UmVuZGVySW5saW5lPihjb250YWluZXJCbG9jaykgJiYgIWNvbnRh aW5lckJsb2NrLnN0eWxlKCkuaXNMZWZ0VG9SaWdodERpcmVjdGlvbigpKSB7Ci0gICAgICAgIGNv bnN0IGF1dG8mIGZsb3cgPSBkb3duY2FzdDxSZW5kZXJJbmxpbmU+KGNvbnRhaW5lckJsb2NrKTsK LSAgICAgICAgTGVnYWN5SW5saW5lRmxvd0JveCogZmlyc3RMaW5lID0gZmxvdy5maXJzdExpbmVC b3goKTsKLSAgICAgICAgTGVnYWN5SW5saW5lRmxvd0JveCogbGFzdExpbmUgPSBmbG93Lmxhc3RM aW5lQm94KCk7Ci0gICAgICAgIGlmIChmaXJzdExpbmUgJiYgbGFzdExpbmUgJiYgZmlyc3RMaW5l ICE9IGxhc3RMaW5lKSB7Ci0gICAgICAgICAgICBjb21wdXRlZFZhbHVlcy5tX3Bvc2l0aW9uID0g bG9naWNhbExlZnRWYWx1ZSArIG1hcmdpbkxvZ2ljYWxMZWZ0QWxpYXMgKyBsYXN0TGluZS0+Ym9y ZGVyTG9naWNhbExlZnQoKSArIChsYXN0TGluZS0+bG9naWNhbExlZnQoKSAtIGZpcnN0TGluZS0+ bG9naWNhbExlZnQoKSk7Ci0gICAgICAgICAgICByZXR1cm47Ci0gICAgICAgIH0KKyAgICBpZiAo YXV0byBwb3NpdGlvbiA9IHBvc2l0aW9uV2l0aFJUTElubGluZUJveENvbnRhaW5pbmdCbG9jayhj b250YWluZXJCbG9jaywgbG9naWNhbExlZnRWYWx1ZSwgbWFyZ2luTG9naWNhbExlZnRBbGlhcykp IHsKKyAgICAgICAgY29tcHV0ZWRWYWx1ZXMubV9wb3NpdGlvbiA9ICpwb3NpdGlvbjsKKyAgICAg ICAgcmV0dXJuOwogICAgIH0KIAogICAgIExheW91dFVuaXQgbG9naWNhbExlZnRQb3MgPSBsb2dp Y2FsTGVmdFZhbHVlICsgbWFyZ2luTG9naWNhbExlZnRBbGlhczsK