<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>24938</bug_id>
          
          <creation_ts>2009-03-30 10:15:44 -0700</creation_ts>
          <short_desc>--no-svg has build problems</short_desc>
          <delta_ts>2009-03-30 13:00:13 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>SVG</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Greg Bolsinga">bolsinga</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ddkilzer</cc>
    
    <cc>simon.fraser</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>115837</commentid>
    <comment_count>0</comment_count>
    <who name="Greg Bolsinga">bolsinga</who>
    <bug_when>2009-03-30 10:15:44 -0700</bug_when>
    <thetext>When building with:

./WebKitTools/Scripts/build-webkit --no-svg --no-svg-animation --no-svg-filters --no-svg-foreign-object --no-svg-fonts --no-svg-as-image --no-svg-use

there are build errors. This fixes the compilation problems.

The WebCore.xcode project is copying DOMHTMLFrameElementPrivate.h and DOMHTMLIFrameElementPrivate.h. These are only generated when building ENABLE_SVG. I am not sure of the best way to conditionally copy those header files.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>115838</commentid>
    <comment_count>1</comment_count>
      <attachid>29075</attachid>
    <who name="Greg Bolsinga">bolsinga</who>
    <bug_when>2009-03-30 10:16:11 -0700</bug_when>
    <thetext>Created attachment 29075
This patch addresses the build problems</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>115843</commentid>
    <comment_count>2</comment_count>
      <attachid>29075</attachid>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2009-03-30 10:29:03 -0700</bug_when>
    <thetext>Comment on attachment 29075
This patch addresses the build problems

=&gt;          case CSSPropertyWebkitTextStroke:
&gt;          case CSSPropertyWebkitTransition:
&gt;          case CSSPropertyWebkitVariableDeclarationBlock:
&gt; +        case CSSPropertyWebkitPerspectiveOriginX:
&gt; +        case CSSPropertyWebkitPerspectiveOriginY:
&gt; +        case CSSPropertyWebkitTransformOriginX:
&gt; +        case CSSPropertyWebkitTransformOriginY:
&gt; +        case CSSPropertyWebkitTransformOriginZ:

I think these were left out on purpose. We don&apos;t want authors to get style for &apos;transform-origin-x&apos; etc, just the compound property &apos;transform-origin&apos;.

&gt; Index: WebCore/css/CSSParser.cpp
&gt; ===================================================================
&gt; --- WebCore/css/CSSParser.cpp	(revision 42106)
&gt; +++ WebCore/css/CSSParser.cpp	(working copy)
&gt; @@ -1625,6 +1625,7 @@ bool CSSParser::parseValue(int propId, b
&gt;      case CSSPropertyTextLineThrough:
&gt;      case CSSPropertyTextOverline:
&gt;      case CSSPropertyTextUnderline:
&gt; +    case CSSPropertyWebkitVariableDeclarationBlock:
&gt;          return false;

I don&apos;t see enough context to know if this is correct. I belive CSS variables are disabled now anyway.

&gt; Index: WebCore/css/CSSStyleSelector.cpp
&gt; ===================================================================
&gt; --- WebCore/css/CSSStyleSelector.cpp	(revision 42106)
&gt; +++ WebCore/css/CSSStyleSelector.cpp	(working copy)
&gt; @@ -5185,6 +5185,7 @@ void CSSStyleSelector::applyProperty(int
&gt;      case CSSPropertyWebkitPaddingStart:
&gt;      case CSSPropertyWebkitTextDecorationsInEffect:
&gt;      case CSSPropertyWebkitTextStroke:
&gt; +    case CSSPropertyWebkitVariableDeclarationBlock:

Ditto.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>115844</commentid>
    <comment_count>3</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2009-03-30 10:32:54 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; (From update of attachment 29075 [review])
&gt; =&gt;          case CSSPropertyWebkitTextStroke:
&gt; &gt;          case CSSPropertyWebkitTransition:
&gt; &gt;          case CSSPropertyWebkitVariableDeclarationBlock:
&gt; &gt; +        case CSSPropertyWebkitPerspectiveOriginX:
&gt; &gt; +        case CSSPropertyWebkitPerspectiveOriginY:
&gt; &gt; +        case CSSPropertyWebkitTransformOriginX:
&gt; &gt; +        case CSSPropertyWebkitTransformOriginY:
&gt; &gt; +        case CSSPropertyWebkitTransformOriginZ:
&gt; 
&gt; I think these were left out on purpose. We don&apos;t want authors to get style for
&gt; &apos;transform-origin-x&apos; etc, just the compound property &apos;transform-origin&apos;.

Never mind, these are fine. Stupid svg &apos;default&apos; statement.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>115846</commentid>
    <comment_count>4</comment_count>
    <who name="Greg Bolsinga">bolsinga</who>
    <bug_when>2009-03-30 11:04:53 -0700</bug_when>
    <thetext>bolsinga:WebKit bolsinga$ svn commit
Sending        WebCore/ChangeLog
Sending        WebCore/css/CSSComputedStyleDeclaration.cpp
Sending        WebCore/css/CSSCursorImageValue.cpp
Sending        WebCore/css/CSSParser.cpp
Sending        WebCore/css/CSSStyleSelector.cpp
Sending        WebCore/dom/Node.cpp
Sending        WebCore/platform/graphics/Font.cpp
Sending        WebCore/platform/graphics/SimpleFontData.cpp
Sending        WebKit/mac/ChangeLog
Sending        WebKit/mac/MigrateHeaders.make
Transmitting file data ..........
Committed revision 42112.
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>115850</commentid>
    <comment_count>5</comment_count>
      <attachid>29079</attachid>
    <who name="Greg Bolsinga">bolsinga</who>
    <bug_when>2009-03-30 11:26:06 -0700</bug_when>
    <thetext>Created attachment 29079
Build fixes for building --3d-rendering and --no-svg</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>115853</commentid>
    <comment_count>6</comment_count>
    <who name="Greg Bolsinga">bolsinga</who>
    <bug_when>2009-03-30 11:33:56 -0700</bug_when>
    <thetext>bolsinga:WebKit bolsinga$ svn commit
Sending        WebCore/ChangeLog
Sending        WebCore/rendering/RenderLayerBacking.cpp
Transmitting file data ..
Committed revision 42115.
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>115862</commentid>
    <comment_count>7</comment_count>
      <attachid>29075</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2009-03-30 12:07:50 -0700</bug_when>
    <thetext>Comment on attachment 29075
This patch addresses the build problems

&gt;          case CSSPropertyWebkitTextStroke:
&gt;          case CSSPropertyWebkitTransition:
&gt;          case CSSPropertyWebkitVariableDeclarationBlock:
&gt; +        case CSSPropertyWebkitPerspectiveOriginX:
&gt; +        case CSSPropertyWebkitPerspectiveOriginY:
&gt; +        case CSSPropertyWebkitTransformOriginX:
&gt; +        case CSSPropertyWebkitTransformOriginY:
&gt; +        case CSSPropertyWebkitTransformOriginZ:

Should be sorted alphabetically. Same for other switch statements in the patch that are currently sorted. Please don&apos;t add the first non-sorted items.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>115867</commentid>
    <comment_count>8</comment_count>
      <attachid>29081</attachid>
    <who name="Greg Bolsinga">bolsinga</who>
    <bug_when>2009-03-30 12:42:58 -0700</bug_when>
    <thetext>Created attachment 29081
sorted switch statement

The other switch statements are sorted within their &quot;return false&quot; groupings.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>115868</commentid>
    <comment_count>9</comment_count>
    <who name="Greg Bolsinga">bolsinga</who>
    <bug_when>2009-03-30 12:43:15 -0700</bug_when>
    <thetext>Re-opening for new review.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>115870</commentid>
    <comment_count>10</comment_count>
    <who name="Greg Bolsinga">bolsinga</who>
    <bug_when>2009-03-30 13:00:13 -0700</bug_when>
    <thetext>bolsinga:WebKit bolsinga$ svn commit
Sending        WebCore/ChangeLog
Sending        WebCore/css/CSSComputedStyleDeclaration.cpp
Transmitting file data ..
Committed revision 42116.
</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>29075</attachid>
            <date>2009-03-30 10:16:11 -0700</date>
            <delta_ts>2009-03-30 10:53:10 -0700</delta_ts>
            <desc>This patch addresses the build problems</desc>
            <filename>no-svg-patch.txt</filename>
            <type>text/plain</type>
            <size>7895</size>
            <attacher name="Greg Bolsinga">bolsinga</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA0MjEwNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMjQgQEAKKzIwMDktMDMtMzAgIEdyZWcgQm9sc2luZ2EgIDxib2xzaW5nYUBhcHBs
ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
QnVpbGQgZml4ZXMgd2hlbiBidWlsZGluZyAtLW5vLXN2ZworICAgICAgICAKKyAgICAgICAgKiBj
c3MvQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNT
U0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbjo6Z2V0UHJvcGVydHlDU1NWYWx1ZSk6IEFkZCBtaXNz
aW5nIENTUyBwcm9wZXJ0aWVzCisgICAgICAgICogY3NzL0NTU0N1cnNvckltYWdlVmFsdWUuY3Bw
OgorICAgICAgICAoV2ViQ29yZTo6Q1NTQ3Vyc29ySW1hZ2VWYWx1ZTo6dXBkYXRlSWZTVkdDdXJz
b3JJc1VzZWQpOiBIYW5kbGUgdW51c2VkIHBhcmFtCisgICAgICAgICogY3NzL0NTU1BhcnNlci5j
cHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NQYXJzZXI6OnBhcnNlVmFsdWUpOiBBZGQgbWlzc2lu
ZyBDU1MgcHJvcGVydGllcworICAgICAgICAqIGNzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcDoKKyAg
ICAgICAgKFdlYkNvcmU6OkNTU1N0eWxlU2VsZWN0b3I6OmFwcGx5UHJvcGVydHkpOiBBZGQgbWlz
c2luZyBDU1MgcHJvcGVydGllcworICAgICAgICAqIGRvbS9Ob2RlLmNwcDoKKyAgICAgICAgKFdl
YkNvcmU6OnVwZGF0ZVNWR0VsZW1lbnRJbnN0YW5jZXNBZnRlckV2ZW50TGlzdGVuZXJDaGFuZ2Up
OiBIYW5kbGUgdW51c2VkIHBhcmFtCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvRm9udC5j
cHA6CisgICAgICAgIChXZWJDb3JlOjpGb250OjpmbG9hdFdpZHRoKTogSGFuZGxlIHVudXNlZCBw
YXJhbQorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL1NpbXBsZUZvbnREYXRhLmNwcDoKKyAg
ICAgICAgKFdlYkNvcmU6OlNpbXBsZUZvbnREYXRhOjpTaW1wbGVGb250RGF0YSk6IEhhbmRsZSB1
bnVzZWQgcGFyYW0KKwogMjAwOS0wMy0zMCAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z3VzdGF2
by5ub3JvbmhhQGNvbGxhYm9yYS5jby51az4KIAogICAgICAgICBSZXZpZXdlZCBieSBIb2xnZXIg
RnJleXRoZXIuCkluZGV4OiBXZWJDb3JlL2Nzcy9DU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb24u
Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvY3NzL0NTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlv
bi5jcHAJKHJldmlzaW9uIDQyMTA2KQorKysgV2ViQ29yZS9jc3MvQ1NTQ29tcHV0ZWRTdHlsZURl
Y2xhcmF0aW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTMxOCw2ICsxMzE4LDExIEBAIFBhc3NS
ZWZQdHI8Q1NTVmFsdWU+IENTU0NvbXB1dGVkU3R5bGVEZWMKICAgICAgICAgY2FzZSBDU1NQcm9w
ZXJ0eVdlYmtpdFRleHRTdHJva2U6CiAgICAgICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRUcmFu
c2l0aW9uOgogICAgICAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0VmFyaWFibGVEZWNsYXJhdGlv
bkJsb2NrOgorICAgICAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0UGVyc3BlY3RpdmVPcmlnaW5Y
OgorICAgICAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0UGVyc3BlY3RpdmVPcmlnaW5ZOgorICAg
ICAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0VHJhbnNmb3JtT3JpZ2luWDoKKyAgICAgICAgY2Fz
ZSBDU1NQcm9wZXJ0eVdlYmtpdFRyYW5zZm9ybU9yaWdpblk6CisgICAgICAgIGNhc2UgQ1NTUHJv
cGVydHlXZWJraXRUcmFuc2Zvcm1PcmlnaW5aOgogICAgICAgICAgICAgYnJlYWs7CiAjaWYgRU5B
QkxFKFNWRykKICAgICAgICAgLy8gRklYTUU6IFRoaXMgZGVmYXVsdCBjYXNlIHJ1aW5zIHRoZSBw
b2ludCBvZiB1c2luZyBhbiBlbnVtIGZvcgpJbmRleDogV2ViQ29yZS9jc3MvQ1NTQ3Vyc29ySW1h
Z2VWYWx1ZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9jc3MvQ1NTQ3Vyc29ySW1hZ2VWYWx1
ZS5jcHAJKHJldmlzaW9uIDQyMTA2KQorKysgV2ViQ29yZS9jc3MvQ1NTQ3Vyc29ySW1hZ2VWYWx1
ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI3LDYgKzI3LDcgQEAKICNpbmNsdWRlICJQbGF0Zm9y
bVN0cmluZy5oIgogI2luY2x1ZGUgIlJlbmRlclN0eWxlLmgiCiAjaW5jbHVkZSA8d3RmL01hdGhF
eHRyYXMuaD4KKyNpbmNsdWRlIDx3dGYvVW51c2VkUGFyYW0uaD4KIAogI2lmIEVOQUJMRShTVkcp
CiAjaW5jbHVkZSAiU1ZHQ3Vyc29yRWxlbWVudC5oIgpAQCAtNzksNyArODAsOSBAQCBDU1NDdXJz
b3JJbWFnZVZhbHVlOjp+Q1NTQ3Vyc29ySW1hZ2VWYWx1CiAKIGJvb2wgQ1NTQ3Vyc29ySW1hZ2VW
YWx1ZTo6dXBkYXRlSWZTVkdDdXJzb3JJc1VzZWQoRWxlbWVudCogZWxlbWVudCkKIHsKLSNpZiBF
TkFCTEUoU1ZHKQorI2lmICFFTkFCTEUoU1ZHKQorICAgIFVOVVNFRF9QQVJBTShlbGVtZW50KTsK
KyNlbHNlCiAgICAgaWYgKCFlbGVtZW50IHx8ICFlbGVtZW50LT5pc1NWR0VsZW1lbnQoKSkKICAg
ICAgICAgcmV0dXJuIGZhbHNlOwogCkluZGV4OiBXZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCj09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT0KLS0tIFdlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAJKHJldmlzaW9uIDQyMTA2KQor
KysgV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTYyNSw2ICsx
NjI1LDcgQEAgYm9vbCBDU1NQYXJzZXI6OnBhcnNlVmFsdWUoaW50IHByb3BJZCwgYgogICAgIGNh
c2UgQ1NTUHJvcGVydHlUZXh0TGluZVRocm91Z2g6CiAgICAgY2FzZSBDU1NQcm9wZXJ0eVRleHRP
dmVybGluZToKICAgICBjYXNlIENTU1Byb3BlcnR5VGV4dFVuZGVybGluZToKKyAgICBjYXNlIENT
U1Byb3BlcnR5V2Via2l0VmFyaWFibGVEZWNsYXJhdGlvbkJsb2NrOgogICAgICAgICByZXR1cm4g
ZmFsc2U7CiAjaWYgRU5BQkxFKFNWRykKICAgICBkZWZhdWx0OgpJbmRleDogV2ViQ29yZS9jc3Mv
Q1NTU3R5bGVTZWxlY3Rvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9jc3MvQ1NTU3R5bGVT
ZWxlY3Rvci5jcHAJKHJldmlzaW9uIDQyMTA2KQorKysgV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxl
Y3Rvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUxODUsNiArNTE4NSw3IEBAIHZvaWQgQ1NTU3R5
bGVTZWxlY3Rvcjo6YXBwbHlQcm9wZXJ0eShpbnQKICAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0
UGFkZGluZ1N0YXJ0OgogICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRUZXh0RGVjb3JhdGlvbnNJ
bkVmZmVjdDoKICAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0VGV4dFN0cm9rZToKKyAgICBjYXNl
IENTU1Byb3BlcnR5V2Via2l0VmFyaWFibGVEZWNsYXJhdGlvbkJsb2NrOgogICAgICAgICByZXR1
cm47CiAjaWYgRU5BQkxFKFNWRykKICAgICBkZWZhdWx0OgpJbmRleDogV2ViQ29yZS9kb20vTm9k
ZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9kb20vTm9kZS5jcHAJKHJldmlzaW9uIDQyMTA2
KQorKysgV2ViQ29yZS9kb20vTm9kZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc4LDYgKzc4LDcg
QEAKICNpbmNsdWRlICJodG1sZWRpdGluZy5oIgogI2luY2x1ZGUgPHd0Zi9IYXNoU2V0Lmg+CiAj
aW5jbHVkZSA8d3RmL1JlZkNvdW50ZWRMZWFrQ291bnRlci5oPgorI2luY2x1ZGUgPHd0Zi9VbnVz
ZWRQYXJhbS5oPgogCiAjaWYgRU5BQkxFKERPTV9TVE9SQUdFKQogI2luY2x1ZGUgIlN0b3JhZ2VF
dmVudC5oIgpAQCAtMjIxNSw5ICsyMjE2LDEwIEBAIHZvaWQgTm9kZTo6ZGlkTW92ZVRvTmV3T3du
ZXJEb2N1bWVudCgpCiAKIHN0YXRpYyBpbmxpbmUgdm9pZCB1cGRhdGVTVkdFbGVtZW50SW5zdGFu
Y2VzQWZ0ZXJFdmVudExpc3RlbmVyQ2hhbmdlKE5vZGUqIHJlZmVyZW5jZU5vZGUpCiB7CisjaWYg
IUVOQUJMRShTVkcpCisgICAgVU5VU0VEX1BBUkFNKHJlZmVyZW5jZU5vZGUpOworI2Vsc2UKICAg
ICBBU1NFUlQocmVmZXJlbmNlTm9kZSk7Ci0KLSNpZiBFTkFCTEUoU1ZHKQogICAgIGlmICghcmVm
ZXJlbmNlTm9kZS0+aXNTVkdFbGVtZW50KCkpCiAgICAgICAgIHJldHVybjsKIApJbmRleDogV2Vi
Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3Bs
YXRmb3JtL2dyYXBoaWNzL0ZvbnQuY3BwCShyZXZpc2lvbiA0MjEwNikKKysrIFdlYkNvcmUvcGxh
dGZvcm0vZ3JhcGhpY3MvRm9udC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMyLDYgKzMyLDcgQEAK
ICNpbmNsdWRlICJHbHlwaEJ1ZmZlci5oIgogI2luY2x1ZGUgIldpZHRoSXRlcmF0b3IuaCIKICNp
bmNsdWRlIDx3dGYvTWF0aEV4dHJhcy5oPgorI2luY2x1ZGUgPHd0Zi9VbnVzZWRQYXJhbS5oPgog
CiB1c2luZyBuYW1lc3BhY2UgV1RGOwogdXNpbmcgbmFtZXNwYWNlIFVuaWNvZGU7CkBAIC0yMTUs
NyArMjE2LDkgQEAgZmxvYXQgRm9udDo6ZmxvYXRXaWR0aChjb25zdCBUZXh0UnVuJiBydQogCiBm
bG9hdCBGb250OjpmbG9hdFdpZHRoKGNvbnN0IFRleHRSdW4mIHJ1biwgaW50IGV4dHJhQ2hhcnNB
dmFpbGFibGUsIGludCYgY2hhcnNDb25zdW1lZCwgU3RyaW5nJiBnbHlwaE5hbWUpIGNvbnN0CiB7
Ci0jaWYgRU5BQkxFKFNWR19GT05UUykKKyNpZiAhRU5BQkxFKFNWR19GT05UUykKKyAgICBVTlVT
RURfUEFSQU0oZXh0cmFDaGFyc0F2YWlsYWJsZSk7CisjZWxzZQogICAgIGlmIChwcmltYXJ5Rm9u
dCgpLT5pc1NWR0ZvbnQoKSkKICAgICAgICAgcmV0dXJuIGZsb2F0V2lkdGhVc2luZ1NWR0ZvbnQo
cnVuLCBleHRyYUNoYXJzQXZhaWxhYmxlLCBjaGFyc0NvbnN1bWVkLCBnbHlwaE5hbWUpOwogI2Vu
ZGlmCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1NpbXBsZUZvbnREYXRhLmNwcAo9
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1NpbXBsZUZvbnREYXRhLmNw
cAkocmV2aXNpb24gNDIxMDYpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1NpbXBsZUZv
bnREYXRhLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzgsNiArMzgsNyBAQAogI2VuZGlmCiAKICNp
bmNsdWRlIDx3dGYvTWF0aEV4dHJhcy5oPgorI2luY2x1ZGUgPHd0Zi9VbnVzZWRQYXJhbS5oPgog
CiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKQEAgLTUyLDcgKzUzLDkgQEAgU2ltcGxlRm9udERhdGE6
OlNpbXBsZUZvbnREYXRhKGNvbnN0IEZvbgogICAgICwgbV9pc0xvYWRpbmcobG9hZGluZykKICAg
ICAsIG1fc21hbGxDYXBzRm9udERhdGEoMCkKIHsKLSNpZiBFTkFCTEUoU1ZHX0ZPTlRTKQorI2lm
ICFFTkFCTEUoU1ZHX0ZPTlRTKQorICAgIFVOVVNFRF9QQVJBTShzdmdGb250RGF0YSk7CisjZWxz
ZQogICAgIGlmIChTVkdGb250RmFjZUVsZW1lbnQqIHN2Z0ZvbnRGYWNlRWxlbWVudCA9IHN2Z0Zv
bnREYXRhID8gc3ZnRm9udERhdGEtPnN2Z0ZvbnRGYWNlRWxlbWVudCgpIDogMCkgewogICAgICAg
IG1fdW5pdHNQZXJFbSA9IHN2Z0ZvbnRGYWNlRWxlbWVudC0+dW5pdHNQZXJFbSgpOwogCkluZGV4
OiBXZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvbWFjL0NoYW5nZUxv
ZwkocmV2aXNpb24gNDIxMDYpCisrKyBXZWJLaXQvbWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5
KQpAQCAtMSwzICsxLDEzIEBACisyMDA5LTAzLTMwICBHcmVnIEJvbHNpbmdhICA8Ym9sc2luZ2FA
YXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAg
ICAKKyAgICAgICAgQnVpbGQgZml4ZXMgd2hlbiBidWlsZGluZyAtLW5vLXN2ZworICAgICAgICAK
KyAgICAgICAgRE9NSFRNTEZyYW1lRWxlbWVudFByaXZhdGUuaCBhbmQgRE9NSFRNTElGcmFtZUVs
ZW1lbnRQcml2YXRlLmggYXJlIG9ubHkgYXZhaWxhYmxlIHdpdGggRU5BQkxFX1NWRy4KKworICAg
ICAgICAqIE1pZ3JhdGVIZWFkZXJzLm1ha2U6CisKIDIwMDktMDMtMjkgIERhcmluIEFkbGVyICA8
ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IENhbWVyb24gWndhcmljaC4K
SW5kZXg6IFdlYktpdC9tYWMvTWlncmF0ZUhlYWRlcnMubWFrZQo9PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJL
aXQvbWFjL01pZ3JhdGVIZWFkZXJzLm1ha2UJKHJldmlzaW9uIDQyMTA2KQorKysgV2ViS2l0L21h
Yy9NaWdyYXRlSGVhZGVycy5tYWtlCSh3b3JraW5nIGNvcHkpCkBAIC05OCwxNCArOTgsMTIgQEAg
YWxsIDogXAogICAgICQoUFVCTElDX0hFQURFUlNfRElSKS9ET01IVE1MRm9udEVsZW1lbnQuaCBc
CiAgICAgJChQVUJMSUNfSEVBREVSU19ESVIpL0RPTUhUTUxGb3JtRWxlbWVudC5oIFwKICAgICAk
KFBVQkxJQ19IRUFERVJTX0RJUikvRE9NSFRNTEZyYW1lRWxlbWVudC5oIFwKLSAgICAkKFBSSVZB
VEVfSEVBREVSU19ESVIpL0RPTUhUTUxGcmFtZUVsZW1lbnRQcml2YXRlLmggXAogICAgICQoUFVC
TElDX0hFQURFUlNfRElSKS9ET01IVE1MRnJhbWVTZXRFbGVtZW50LmggXAogICAgICQoUFVCTElD
X0hFQURFUlNfRElSKS9ET01IVE1MSFJFbGVtZW50LmggXAogICAgICQoUFVCTElDX0hFQURFUlNf
RElSKS9ET01IVE1MSGVhZEVsZW1lbnQuaCBcCiAgICAgJChQVUJMSUNfSEVBREVSU19ESVIpL0RP
TUhUTUxIZWFkaW5nRWxlbWVudC5oIFwKICAgICAkKFBVQkxJQ19IRUFERVJTX0RJUikvRE9NSFRN
TEh0bWxFbGVtZW50LmggXAogICAgICQoUFVCTElDX0hFQURFUlNfRElSKS9ET01IVE1MSUZyYW1l
RWxlbWVudC5oIFwKLSAgICAkKFBSSVZBVEVfSEVBREVSU19ESVIpL0RPTUhUTUxJRnJhbWVFbGVt
ZW50UHJpdmF0ZS5oIFwKICAgICAkKFBVQkxJQ19IRUFERVJTX0RJUikvRE9NSFRNTEltYWdlRWxl
bWVudC5oIFwKICAgICAkKFBVQkxJQ19IRUFERVJTX0RJUikvRE9NSFRNTElucHV0RWxlbWVudC5o
IFwKICAgICAkKElOVEVSTkFMX0hFQURFUlNfRElSKS9ET01IVE1MSW5wdXRFbGVtZW50SW50ZXJu
YWwuaCBcCkBAIC0xODksNiArMTg3LDggQEAgYWxsIDogXAogaWZlcSAoJChmaW5kc3RyaW5nIEVO
QUJMRV9TVkcsJChGRUFUVVJFX0RFRklORVMpKSwgRU5BQkxFX1NWRykKIAogYWxsIDogXAorICAg
ICQoUFJJVkFURV9IRUFERVJTX0RJUikvRE9NSFRNTEZyYW1lRWxlbWVudFByaXZhdGUuaCBcCisg
ICAgJChQUklWQVRFX0hFQURFUlNfRElSKS9ET01IVE1MSUZyYW1lRWxlbWVudFByaXZhdGUuaCBc
CiAgICAgJChQUklWQVRFX0hFQURFUlNfRElSKS9ET01TVkcuaCBcCiAgICAgJChQUklWQVRFX0hF
QURFUlNfRElSKS9ET01TVkdBRWxlbWVudC5oIFwKICAgICAkKElOVEVSTkFMX0hFQURFUlNfRElS
KS9ET01TVkdBRWxlbWVudEludGVybmFsLmggXAo=
</data>
<flag name="review"
          id="14391"
          type_id="1"
          status="+"
          setter="simon.fraser"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>29079</attachid>
            <date>2009-03-30 11:26:06 -0700</date>
            <delta_ts>2009-03-30 11:28:14 -0700</delta_ts>
            <desc>Build fixes for building --3d-rendering and --no-svg</desc>
            <filename>no-svg-patch.txt</filename>
            <type>text/plain</type>
            <size>976</size>
            <attacher name="Greg Bolsinga">bolsinga</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA0MjExMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTMgQEAKKzIwMDktMDMtMzAgIEdyZWcgQm9sc2luZ2EgIDxib2xzaW5nYUBhcHBs
ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0OTM4CisgICAgICAgIAor
ICAgICAgICBCdWlsZCBmaXhlcyBmb3IgYnVpbGRpbmcgLS0zZC1yZW5kZXJpbmcgYW5kIC0tbm8t
c3ZnCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcDoKKwogMjAw
OS0wMy0zMCAgR3JlZyBCb2xzaW5nYSAgPGJvbHNpbmdhQGFwcGxlLmNvbT4KIAogICAgICAgICBS
ZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJM
YXllckJhY2tpbmcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxh
eWVyQmFja2luZy5jcHAJKHJldmlzaW9uIDQyMTExKQorKysgV2ViQ29yZS9yZW5kZXJpbmcvUmVu
ZGVyTGF5ZXJCYWNraW5nLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzMsNiArMzMsNyBAQAogI2lu
Y2x1ZGUgIkZyYW1lVmlldy5oIgogI2luY2x1ZGUgIkdyYXBoaWNzQ29udGV4dC5oIgogI2luY2x1
ZGUgIkdyYXBoaWNzTGF5ZXIuaCIKKyNpbmNsdWRlICJIVE1MRWxlbWVudC5oIgogI2luY2x1ZGUg
IkhUTUxOYW1lcy5oIgogI2luY2x1ZGUgIlJlbmRlckJveC5oIgogI2luY2x1ZGUgIlJlbmRlcklt
YWdlLmgiCg==
</data>
<flag name="review"
          id="14394"
          type_id="1"
          status="+"
          setter="simon.fraser"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>29081</attachid>
            <date>2009-03-30 12:42:58 -0700</date>
            <delta_ts>2009-03-30 12:48:41 -0700</delta_ts>
            <desc>sorted switch statement</desc>
            <filename>sorted.patch.txt</filename>
            <type>text/plain</type>
            <size>1599</size>
            <attacher name="Greg Bolsinga">bolsinga</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA0MjExNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTIgQEAKKzIwMDktMDMtMzAgIEdyZWcgQm9sc2luZ2EgIDxib2xzaW5nYUBhcHBs
ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
U29ydCBhbHBoYWJldGljYWxseS4KKworICAgICAgICAqIGNzcy9DU1NDb21wdXRlZFN0eWxlRGVj
bGFyYXRpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0
aW9uOjpnZXRQcm9wZXJ0eUNTU1ZhbHVlKToKKwogMjAwOS0wMy0zMCAgR3JlZyBCb2xzaW5nYSAg
PGJvbHNpbmdhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIu
CkluZGV4OiBXZWJDb3JlL2Nzcy9DU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb24uY3BwCj09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT0KLS0tIFdlYkNvcmUvY3NzL0NTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbi5jcHAJKHJl
dmlzaW9uIDQyMTE1KQorKysgV2ViQ29yZS9jc3MvQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9u
LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTMxNSwxNCArMTMxNSwxNCBAQCBQYXNzUmVmUHRyPENT
U1ZhbHVlPiBDU1NDb21wdXRlZFN0eWxlRGVjCiAgICAgICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJr
aXRNYXJxdWVlU3BlZWQ6CiAgICAgICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRNYXNrOgogICAg
ICAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0UGFkZGluZ1N0YXJ0OgotICAgICAgICBjYXNlIENT
U1Byb3BlcnR5V2Via2l0VGV4dFN0cm9rZToKLSAgICAgICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtp
dFRyYW5zaXRpb246Ci0gICAgICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRWYXJpYWJsZURlY2xh
cmF0aW9uQmxvY2s6CiAgICAgICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRQZXJzcGVjdGl2ZU9y
aWdpblg6CiAgICAgICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRQZXJzcGVjdGl2ZU9yaWdpblk6
CisgICAgICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRUZXh0U3Ryb2tlOgogICAgICAgICBjYXNl
IENTU1Byb3BlcnR5V2Via2l0VHJhbnNmb3JtT3JpZ2luWDoKICAgICAgICAgY2FzZSBDU1NQcm9w
ZXJ0eVdlYmtpdFRyYW5zZm9ybU9yaWdpblk6CiAgICAgICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJr
aXRUcmFuc2Zvcm1PcmlnaW5aOgorICAgICAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0VHJhbnNp
dGlvbjoKKyAgICAgICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdFZhcmlhYmxlRGVjbGFyYXRpb25C
bG9jazoKICAgICAgICAgICAgIGJyZWFrOwogI2lmIEVOQUJMRShTVkcpCiAgICAgICAgIC8vIEZJ
WE1FOiBUaGlzIGRlZmF1bHQgY2FzZSBydWlucyB0aGUgcG9pbnQgb2YgdXNpbmcgYW4gZW51bSBm
b3IK
</data>
<flag name="review"
          id="14395"
          type_id="1"
          status="+"
          setter="simon.fraser"
    />
          </attachment>
      

    </bug>

</bugzilla>