249368 2022-12-14 19:49:58 -0800 REGRESSION(257515@main): breaks build with -flto=auto 2023-03-16 01:16:10 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=241002 https://bugzilla.redhat.com/show_bug.cgi?id=2159783 P2 Normal --- 1 mcatanzaro aperez aperez ap bugs-noreply fabiscafe fujii kloczko.tomasz mcatanzaro olivier.blin webkit-bug-importer ysuzuki oldest_to_newest 1919446 0 mcatanzaro 2022-12-14 19:49:58 -0800 WebKitGTK 2.39.3 fails to link lib/libwebkitgtk-6.0.so.0.0.0 with -flto=auto. The rror message is: lto1: fatal error: missing resolution data for _ZTVN7WebCore17SpeechRecognitionE I had no clue what this error message meant, and there seem to be zero relevant search results on the internet, and also zero changes to Speech Recognition code between 2.39.2 and 2.39.3. So I bisected it and found the first bad commit is 257515@main "[JSC] Clean up Structure transition watchpoint firing to pave a way to faster / cheap adaptive watchpoint" which makes no sense. This result is so weird that I will double check the results of my bisect tomorrow, just to be certain. My checkout is on 257514@main right now and it builds fine, so I will test 257515@main again. I wonder if there might be a toolchain bug here. 1919541 1 mcatanzaro 2022-12-15 07:25:54 -0800 (In reply to Michael Catanzaro from comment #0) > This result is so weird that I will double check the results of my bisect > tomorrow, just to be certain. It's true. This is definitely somehow caused by 257515@main "[JSC] Clean up Structure transition watchpoint firing to pave a way to faster / cheap adaptive watchpoint" 1919707 2 mcatanzaro 2022-12-15 13:52:15 -0800 I decided to just disable LTO and move on. 1922506 3 fujii 2023-01-02 04:11:22 -0800 *** Bug 249983 has been marked as a duplicate of this bug. *** 1924500 4 mcatanzaro 2023-01-10 09:57:37 -0800 GCC bug report: https://bugzilla.redhat.com/show_bug.cgi?id=2159783 1925954 5 fabiscafe 2023-01-17 02:02:16 -0800 For WebKitGTK 2.39.4 I was able to build with LTO, by using mold as linker. Toolchain in use: (Arch Linux) linux-api-headers 5.18.15 binutils 2.39 gcc 12.2.0 glibc 2.36 1941345 6 465438 aperez 2023-03-14 14:45:07 -0700 Created attachment 465438 Suspicious, ugly patch I have been able to get a build of 2.39.91 with LTO using the BFD linker applying this patch; I have to try and see if I can shuffle things around to 1.) make it palatable for review, and 2.) keep the linker happy. 1941508 7 aperez 2023-03-15 03:12:34 -0700 More fun... I cannot easily reproduce the build failure on my build box with the following CMake incantation: CC=gcc CXX=g++ \ LDFLAGS='-flto=auto -fuse-ld=bfd' CFLAGS='-flto=auto' CXXFLAGS='-flto=auto' \ cmake -S. -Bbuild-lto -DPORT=WPE -DCMAKE_BUILD_TYPE=Release -GNinja That is using GCC 12.2.1 and Binutils 2.40; OTOH, it's 100% reproducible doing Yocto from ToT, which has 11.3.0 and Binutils 2.38. Probably this got fixed in the newer versions, but we need to support the ones from Yocto because supported distros may have them as well. It will be slower to try and make a proper fix having to do cross builds 🥴️ 1941592 8 aperez 2023-03-15 10:33:07 -0700 Pull request: https://github.com/WebKit/WebKit/pull/11562 1941727 9 ews-feeder 2023-03-15 18:06:34 -0700 Committed 261724@main (ee58c2ab8371): <https://commits.webkit.org/261724@main> Reviewed commits have been landed. Closing PR #11562 and removing active labels. 1941803 10 aperez 2023-03-16 01:16:10 -0700 (In reply to EWS from comment #9) > Committed 261724@main (ee58c2ab8371): > <https://commits.webkit.org/261724@main> > > Reviewed commits have been landed. Closing PR #11562 and removing active > labels. Also: backported into the 2.38 and 2.40 release branches 👍️ 465438 2023-03-14 14:45:07 -0700 2023-03-14 14:45:07 -0700 Suspicious, ugly patch 0004-missing-SpeechRecognition-vtable.patch text/plain 1669 aperez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvc3BlZWNoL1NwZWVjaFJlY29nbml0 aW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvc3BlZWNoL1NwZWVjaFJlY29nbml0aW9u LmNwcAppbmRleCA1ZGRjNjU5NWIxMGIuLjc5ODk0MmI5MTRiZiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvTW9kdWxlcy9zcGVlY2gvU3BlZWNoUmVjb2duaXRpb24uY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvc3BlZWNoL1NwZWVjaFJlY29nbml0aW9uLmNwcApAQCAtMjA2LDQg KzIwNiwxMyBAQCB2b2lkIFNwZWVjaFJlY29nbml0aW9uOjpkaWRFbmQoKQogICAgIHF1ZXVlVGFz a1RvRGlzcGF0Y2hFdmVudCgqdGhpcywgVGFza1NvdXJjZTo6U3BlZWNoLCBFdmVudDo6Y3JlYXRl KGV2ZW50TmFtZXMoKS5lbmRFdmVudCwgRXZlbnQ6OkNhbkJ1YmJsZTo6Tm8sIEV2ZW50OjpJc0Nh bmNlbGFibGU6Ok5vKSk7CiB9CiAKK1NwZWVjaFJlY29nbml0aW9uOjp+U3BlZWNoUmVjb2duaXRp b24oKQoreworfQorCisvLyBYWFg6IERpc2d1c3RpbmcgaGFjay4KK1NwZWVjaFJlY29nbml0aW9u Q29ubmVjdGlvbkNsaWVudDo6flNwZWVjaFJlY29nbml0aW9uQ29ubmVjdGlvbkNsaWVudCgpCit7 Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvc3BlZWNoL1NwZWVjaFJlY29nbml0aW9uLmggYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL3NwZWVjaC9TcGVlY2hSZWNvZ25pdGlvbi5oCmluZGV4IDFmNDgyNjk2ZDhkMi4uZmI4MTdm YjcxMzMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3NwZWVjaC9TcGVlY2hS ZWNvZ25pdGlvbi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvc3BlZWNoL1NwZWVjaFJl Y29nbml0aW9uLmgKQEAgLTY0LDYgKzY0LDggQEAgcHVibGljOgogICAgIHVzaW5nIFJlZkNvdW50 ZWQ6OnJlZjsKICAgICB1c2luZyBSZWZDb3VudGVkOjpkZXJlZjsKIAorICAgIHZpcnR1YWwgflNw ZWVjaFJlY29nbml0aW9uKCk7CisKIHByaXZhdGU6CiAgICAgZW51bSBjbGFzcyBTdGF0ZSB7CiAg ICAgICAgIEluYWN0aXZlLApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9zcGVl Y2gvU3BlZWNoUmVjb2duaXRpb25Db25uZWN0aW9uQ2xpZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL3NwZWVjaC9TcGVlY2hSZWNvZ25pdGlvbkNvbm5lY3Rpb25DbGllbnQuaAppbmRleCAx YzMzZGZlMmVmYzQuLmY2M2Y5ODZkNWJiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9k dWxlcy9zcGVlY2gvU3BlZWNoUmVjb2duaXRpb25Db25uZWN0aW9uQ2xpZW50LmgKKysrIGIvU291 cmNlL1dlYkNvcmUvTW9kdWxlcy9zcGVlY2gvU3BlZWNoUmVjb2duaXRpb25Db25uZWN0aW9uQ2xp ZW50LmgKQEAgLTQwLDcgKzQwLDcgQEAgcHVibGljOgogICAgIHsKICAgICB9CiAKLSAgICB2aXJ0 dWFsIH5TcGVlY2hSZWNvZ25pdGlvbkNvbm5lY3Rpb25DbGllbnQoKSA9IGRlZmF1bHQ7CisgICAg dmlydHVhbCB+U3BlZWNoUmVjb2duaXRpb25Db25uZWN0aW9uQ2xpZW50KCk7CiAKICAgICB2aXJ0 dWFsIHZvaWQgZGlkU3RhcnQoKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIGRpZFN0YXJ0Q2FwdHVy aW5nQXVkaW8oKSA9IDA7Cg==