249295 2022-12-14 02:24:27 -0800 Add size assert for Element 2023-01-01 09:28:35 -0800 1 1 1 Unclassified WebKit DOM Safari 15 Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 249874 1 rbuis rbuis cdumez cmarcelo commit-queue esprehn+autocc ews-watchlist kangil.han simon.fraser webkit-bug-importer ysuzuki oldest_to_newest 1919090 0 rbuis 2022-12-14 02:24:27 -0800 Add size assert for Element based on the FIXME in Element.h 1919093 1 464036 rbuis 2022-12-14 02:30:54 -0800 Created attachment 464036 Patch 1919118 2 rbuis 2022-12-14 05:10:17 -0800 Pull request: https://github.com/WebKit/WebKit/pull/7604 1921023 3 webkit-bug-importer 2022-12-21 02:25:17 -0800 <rdar://problem/103591863> 1921344 4 ews-feeder 2022-12-22 05:21:44 -0800 Committed 258238@main (80db98e4cb00): <https://commits.webkit.org/258238@main> Reviewed commits have been landed. Closing PR #7604 and removing active labels. 1921845 5 commit-queue 2022-12-24 16:41:17 -0800 Re-opened since this is blocked by bug 249874 1922199 6 rbuis 2022-12-29 10:31:42 -0800 Pull request: https://github.com/WebKit/WebKit/pull/8102 1922367 7 ews-feeder 2022-12-31 00:25:20 -0800 Committed 258366@main (763cf9e589db): <https://commits.webkit.org/258366@main> Reviewed commits have been landed. Closing PR #8102 and removing active labels. 1922392 8 464036 simon.fraser 2022-12-31 12:44:23 -0800 Comment on attachment 464036 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=464036&action=review > Source/WebCore/dom/Element.cpp:151 > +struct SameSizeAsElement : public ContainerNode { This doesn't detect when ContainerNode grows (and it has no size check). 1922399 9 464036 rbuis 2022-12-31 14:44:46 -0800 Comment on attachment 464036 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=464036&action=review >> Source/WebCore/dom/Element.cpp:151 >> +struct SameSizeAsElement : public ContainerNode { > > This doesn't detect when ContainerNode grows (and it has no size check). I have a follow up patch for asserting Element base class sizes, as suggested by Sam on slack, will put it up tomorrow. 1922446 10 ysuzuki 2023-01-01 09:28:35 -0800 Note that we are not seeing Speedometer2 regression with the relanded revised change (using EventTargetFlag). 464036 2022-12-14 02:30:54 -0800 2022-12-14 02:30:54 -0800 Patch bug-249295-20221214103053.patch text/plain 5642 rbuis RnJvbSAxNWNhYWU5ZDVhZjVhNDBiZjM1ZWE4ZDhkZThmMDE2YTc0Zjc2NzcyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSb2IgQnVpcyA8cmJ1aXNAaWdhbGlhLmNvbT4KRGF0ZTogV2Vk LCAxNCBEZWMgMjAyMiAxMDoyNDo1MyArMDAwMApTdWJqZWN0OiBbUEFUQ0hdIEFkZCBzaXplIGFz c2VydCBmb3IgRWxlbWVudAogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTI0OTI5NQoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpXSVAuCgoqIFNvdXJjZS9XZWJD b3JlL2RvbS9FbGVtZW50LmNwcDoKKFdlYkNvcmU6OkVsZW1lbnQ6Omhhc0R1cGxpY2F0ZUF0dHJp YnV0ZSBjb25zdCk6CihXZWJDb3JlOjpFbGVtZW50OjpzZXRIYXNEdXBsaWNhdGVBdHRyaWJ1dGUp OgooV2ViQ29yZTo6RWxlbWVudDo6ZGlzcGxheUNvbnRlbnRzQ2hhbmdlZCBjb25zdCk6CihXZWJD b3JlOjpFbGVtZW50OjpzZXREaXNwbGF5Q29udGVudHNDaGFuZ2VkKToKKiBTb3VyY2UvV2ViQ29y ZS9kb20vRWxlbWVudC5oOgooV2ViQ29yZTo6RWxlbWVudDo6aGFzRHVwbGljYXRlQXR0cmlidXRl IGNvbnN0KTogRGVsZXRlZC4KKFdlYkNvcmU6OkVsZW1lbnQ6OnNldEhhc0R1cGxpY2F0ZUF0dHJp YnV0ZSk6IERlbGV0ZWQuCihXZWJDb3JlOjpFbGVtZW50OjpkaXNwbGF5Q29udGVudHNDaGFuZ2Vk IGNvbnN0KTogRGVsZXRlZC4KKFdlYkNvcmU6OkVsZW1lbnQ6OnNldERpc3BsYXlDb250ZW50c0No YW5nZWQpOiBEZWxldGVkLgoqIFNvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50UmFyZURhdGEuaDoK KFdlYkNvcmU6OkVsZW1lbnRSYXJlRGF0YTo6aGFzRHVwbGljYXRlQXR0cmlidXRlIGNvbnN0KToK KFdlYkNvcmU6OkVsZW1lbnRSYXJlRGF0YTo6c2V0SGFzRHVwbGljYXRlQXR0cmlidXRlKToKKFdl YkNvcmU6OkVsZW1lbnRSYXJlRGF0YTo6ZGlzcGxheUNvbnRlbnRzQ2hhbmdlZCBjb25zdCk6CihX ZWJDb3JlOjpFbGVtZW50UmFyZURhdGE6OnNldERpc3BsYXlDb250ZW50c0NoYW5nZWQpOgoqIFNv dXJjZS9XZWJDb3JlL2RvbS9Ob2RlUmFyZURhdGEuaDoKLS0tCiBTb3VyY2UvV2ViQ29yZS9kb20v RWxlbWVudC5jcHAgICAgICAgfCAyNyArKysrKysrKysrKysrKysrKysrKysrKysrKysKIFNvdXJj ZS9XZWJDb3JlL2RvbS9FbGVtZW50LmggICAgICAgICB8IDEzICsrKystLS0tLS0tLS0KIFNvdXJj ZS9XZWJDb3JlL2RvbS9FbGVtZW50UmFyZURhdGEuaCB8ICA2ICsrKysrKwogU291cmNlL1dlYkNv cmUvZG9tL05vZGVSYXJlRGF0YS5oICAgIHwgIDQgKysrLQogNCBmaWxlcyBjaGFuZ2VkLCA0MCBp bnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9kb20vRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKaW5kZXgg ZmFmMmZlNTIzNGFmLi5iMTdiNDRhZTk2NjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9FbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKQEAgLTE0 OCw2ICsxNDgsMTMgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiBXVEZfTUFLRV9JU09fQUxMT0NB VEVEX0lNUEwoRWxlbWVudCk7CiAKK3N0cnVjdCBTYW1lU2l6ZUFzRWxlbWVudCA6IHB1YmxpYyBD b250YWluZXJOb2RlIHsKKyAgICBRdWFsaWZpZWROYW1lIHRhZ05hbWU7CisgICAgdm9pZCogZWxl bWVudERhdGE7Cit9OworCitzdGF0aWNfYXNzZXJ0KHNpemVvZihFbGVtZW50KSA9PSBzaXplb2Yo U2FtZVNpemVBc0VsZW1lbnQpLCAiRWxlbWVudCBzaG91bGQgc3RheSBzbWFsbCIpOworCiB1c2lu ZyBuYW1lc3BhY2UgSFRNTE5hbWVzOwogdXNpbmcgbmFtZXNwYWNlIFhNTE5hbWVzOwogCkBAIC01 MDk5LDQgKzUxMDYsMjQgQEAgU3R5bGVQcm9wZXJ0eU1hcFJlYWRPbmx5KiBFbGVtZW50Ojpjb21w dXRlZFN0eWxlTWFwKCkKICAgICByZXR1cm4gcmFyZURhdGEuY29tcHV0ZWRTdHlsZU1hcCgpOwog fQogCitib29sIEVsZW1lbnQ6Omhhc0R1cGxpY2F0ZUF0dHJpYnV0ZSgpIGNvbnN0Cit7CisgICAg cmV0dXJuIGhhc1JhcmVEYXRhKCkgPyBlbGVtZW50UmFyZURhdGEoKS0+aGFzRHVwbGljYXRlQXR0 cmlidXRlKCkgOiBmYWxzZTsKK30KKwordm9pZCBFbGVtZW50OjpzZXRIYXNEdXBsaWNhdGVBdHRy aWJ1dGUoYm9vbCBoYXNEdXBsaWNhdGVBdHRyaWJ1dGUpCit7CisgICAgZW5zdXJlRWxlbWVudFJh cmVEYXRhKCkuc2V0SGFzRHVwbGljYXRlQXR0cmlidXRlKGhhc0R1cGxpY2F0ZUF0dHJpYnV0ZSk7 Cit9CisKK2Jvb2wgRWxlbWVudDo6ZGlzcGxheUNvbnRlbnRzQ2hhbmdlZCgpIGNvbnN0Cit7Cisg ICAgcmV0dXJuIGhhc1JhcmVEYXRhKCkgPyBlbGVtZW50UmFyZURhdGEoKS0+ZGlzcGxheUNvbnRl bnRzQ2hhbmdlZCgpIDogZmFsc2U7Cit9CisKK3ZvaWQgRWxlbWVudDo6c2V0RGlzcGxheUNvbnRl bnRzQ2hhbmdlZChib29sIGNoYW5nZWQpCit7CisgICAgZW5zdXJlRWxlbWVudFJhcmVEYXRhKCku c2V0RGlzcGxheUNvbnRlbnRzQ2hhbmdlZChjaGFuZ2VkKTsKK30KKwogfSAvLyBuYW1lc3BhY2Ug V2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuaCBiL1NvdXJj ZS9XZWJDb3JlL2RvbS9FbGVtZW50LmgKaW5kZXggMDdlOTJiNmNhM2RjLi4yZDFlNWQ4Y2MzNmQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmgKKysrIGIvU291cmNlL1dl YkNvcmUvZG9tL0VsZW1lbnQuaApAQCAtNjkyLDggKzY5Miw4IEBAIHB1YmxpYzoKICAgICBTdHJp bmcgZGVzY3JpcHRpb24oKSBjb25zdCBvdmVycmlkZTsKICAgICBTdHJpbmcgZGVidWdEZXNjcmlw dGlvbigpIGNvbnN0IG92ZXJyaWRlOwogCi0gICAgYm9vbCBoYXNEdXBsaWNhdGVBdHRyaWJ1dGUo KSBjb25zdCB7IHJldHVybiBtX2hhc0R1cGxpY2F0ZUF0dHJpYnV0ZTsgfTsKLSAgICB2b2lkIHNl dEhhc0R1cGxpY2F0ZUF0dHJpYnV0ZShib29sIGhhc0R1cGxpY2F0ZUF0dHJpYnV0ZSkgeyBtX2hh c0R1cGxpY2F0ZUF0dHJpYnV0ZSA9IGhhc0R1cGxpY2F0ZUF0dHJpYnV0ZTsgfTsKKyAgICBib29s IGhhc0R1cGxpY2F0ZUF0dHJpYnV0ZSgpIGNvbnN0OworICAgIHZvaWQgc2V0SGFzRHVwbGljYXRl QXR0cmlidXRlKGJvb2wpOwogCiAgICAgdmlydHVhbCB2b2lkIHVwZGF0ZVVzZXJBZ2VudFNoYWRv d1RyZWUoKSB7IH0KIApAQCAtNzAyLDggKzcwMiw4IEBAIHB1YmxpYzoKICAgICBFeHBsaWNpdGx5 U2V0QXR0ckVsZW1lbnRzTWFwJiBleHBsaWNpdGx5U2V0QXR0ckVsZW1lbnRzTWFwKCk7CiAgICAg RXhwbGljaXRseVNldEF0dHJFbGVtZW50c01hcCogZXhwbGljaXRseVNldEF0dHJFbGVtZW50c01h cElmRXhpc3RzKCkgY29uc3Q7CiAKLSAgICBib29sIGRpc3BsYXlDb250ZW50c0NoYW5nZWQoKSBj b25zdCB7IHJldHVybiBtX2Rpc3BsYXlDb250ZW50c0NoYW5nZWQ7IH0KLSAgICB2b2lkIHNldERp c3BsYXlDb250ZW50c0NoYW5nZWQoYm9vbCBjaGFuZ2VkID0gdHJ1ZSkgeyBtX2Rpc3BsYXlDb250 ZW50c0NoYW5nZWQgPSBjaGFuZ2VkOyB9CisgICAgYm9vbCBkaXNwbGF5Q29udGVudHNDaGFuZ2Vk KCkgY29uc3Q7CisgICAgdm9pZCBzZXREaXNwbGF5Q29udGVudHNDaGFuZ2VkKGJvb2wgPSB0cnVl KTsKIAogcHJvdGVjdGVkOgogICAgIEVsZW1lbnQoY29uc3QgUXVhbGlmaWVkTmFtZSYsIERvY3Vt ZW50JiwgQ29uc3RydWN0aW9uVHlwZSk7CkBAIC04MjYsMTEgKzgyNiw2IEBAIHByaXZhdGU6CiAK ICAgICBRdWFsaWZpZWROYW1lIG1fdGFnTmFtZTsKICAgICBSZWZQdHI8RWxlbWVudERhdGE+IG1f ZWxlbWVudERhdGE7Ci0KLSAgICAvLyBGSVhNRTogdGhlc2UgZmxhZ3Mgc2hvdWxkIG1vdmUgc29t ZXdoZXJlIGVsc2UgYW5kIHRoZW4gd2Ugc2hvdWxkIGhhdmUgYSBzdGF0aWMgYXNzZXJ0IG9uCi0g ICAgLy8gRWxlbWVudCBzaXplIGFuZCBpZGVhbGx5IHN0aWNrIHRvIHRoYXQgc2l6ZS4KLSAgICBi b29sIG1faGFzRHVwbGljYXRlQXR0cmlidXRlIHsgZmFsc2UgfTsKLSAgICBib29sIG1fZGlzcGxh eUNvbnRlbnRzQ2hhbmdlZCB7IGZhbHNlIH07CiB9OwogCiBpbmxpbmUgdm9pZCBFbGVtZW50Ojpz ZXRTYXZlZExheWVyU2Nyb2xsUG9zaXRpb24oY29uc3QgSW50UG9pbnQmIHBvc2l0aW9uKQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnRSYXJlRGF0YS5oIGIvU291cmNlL1dl YkNvcmUvZG9tL0VsZW1lbnRSYXJlRGF0YS5oCmluZGV4IGRjOTY5YjZhNjBiYi4uYzM2MmQyMmEy ODNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudFJhcmVEYXRhLmgKKysr IGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnRSYXJlRGF0YS5oCkBAIC0xMTQsNiArMTE0LDEy IEBAIHB1YmxpYzoKIAogICAgIEV4cGxpY2l0bHlTZXRBdHRyRWxlbWVudHNNYXAmIGV4cGxpY2l0 bHlTZXRBdHRyRWxlbWVudHNNYXAoKSB7IHJldHVybiBtX2V4cGxpY2l0bHlTZXRBdHRyRWxlbWVu dHNNYXA7IH0KIAorICAgIGJvb2wgaGFzRHVwbGljYXRlQXR0cmlidXRlKCkgY29uc3QgeyByZXR1 cm4gbV9oYXNEdXBsaWNhdGVBdHRyaWJ1dGU7IH07CisgICAgdm9pZCBzZXRIYXNEdXBsaWNhdGVB dHRyaWJ1dGUoYm9vbCBoYXNEdXBsaWNhdGVBdHRyaWJ1dGUpIHsgbV9oYXNEdXBsaWNhdGVBdHRy aWJ1dGUgPSBoYXNEdXBsaWNhdGVBdHRyaWJ1dGU7IH07CisKKyAgICBib29sIGRpc3BsYXlDb250 ZW50c0NoYW5nZWQoKSBjb25zdCB7IHJldHVybiBtX2Rpc3BsYXlDb250ZW50c0NoYW5nZWQ7IH0K KyAgICB2b2lkIHNldERpc3BsYXlDb250ZW50c0NoYW5nZWQoYm9vbCBjaGFuZ2VkKSB7IG1fZGlz cGxheUNvbnRlbnRzQ2hhbmdlZCA9IGNoYW5nZWQ7IH0KKwogI2lmIERVTVBfTk9ERV9TVEFUSVNU SUNTCiAgICAgT3B0aW9uU2V0PFVzZVR5cGU+IHVzZVR5cGVzKCkgY29uc3QKICAgICB7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZVJhcmVEYXRhLmggYi9Tb3VyY2UvV2ViQ29y ZS9kb20vTm9kZVJhcmVEYXRhLmgKaW5kZXggY2RiMjM3ZjVmNzA0Li42ZWZkYzYyMjVlODUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlUmFyZURhdGEuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9kb20vTm9kZVJhcmVEYXRhLmgKQEAgLTMyNSw5ICszMjUsMTEgQEAgcHJvdGVjdGVk OgogICAgIC8vIFVzZWQgYnkgRWxlbWVudFJhcmVEYXRhLiBEZWZpbmVkIGhlcmUgZm9yIGJldHRl ciBwYWNraW5nIGluIDY0LWJpdC4KICAgICBpbnQgbV91bnVzdWFsVGFiSW5kZXggeyAwIH07CiAg ICAgdW5zaWduZWQgc2hvcnQgbV9jaGlsZEluZGV4IHsgMCB9OworICAgIGJvb2wgbV9oYXNEdXBs aWNhdGVBdHRyaWJ1dGUgOiAxIHsgZmFsc2UgfTsKKyAgICBib29sIG1fZGlzcGxheUNvbnRlbnRz Q2hhbmdlZCA6IDEgeyBmYWxzZSB9OwogCiBwcml2YXRlOgotICAgIGJvb2wgbV9pc0VsZW1lbnRS YXJlRGF0YTsKKyAgICBib29sIG1faXNFbGVtZW50UmFyZURhdGEgOiAxOwogCiAgICAgc3RkOjp1 bmlxdWVfcHRyPE5vZGVMaXN0c05vZGVEYXRhPiBtX25vZGVMaXN0czsKICAgICBzdGQ6OnVuaXF1 ZV9wdHI8Tm9kZU11dGF0aW9uT2JzZXJ2ZXJEYXRhPiBtX211dGF0aW9uT2JzZXJ2ZXJEYXRhOwo=