24916 2009-03-28 17:11:39 -0700 REGRESSION: NavigationAction policy dispatch broken 2009-03-30 10:26:46 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 xan.lopez darin gustavo oldest_to_newest 115704 0 xan.lopez 2009-03-28 17:11:39 -0700 In www.reddit.com, when clicking any link to the comments (those with name XXX comments, where XXX is a number), the data that arrives to the dispatchDecidePolicyForNavigationAction is incomplete: the action type is wrong, and the event associated with it lacks any data about button the key modifier keys pressed. This was working in r42054, and I'd say it broke in the next commit by Darin (r42055), but I won't get to test it properly tonight. 115711 1 gustavo 2009-03-28 18:11:40 -0700 I tried building the revision 42055 with the patch from 42069 (gtk+ build fix after 42055), and it doesn't work, indeed. I also tried revision 42054 with the patch from 42069, just to be sure it is not our fix that breaks it, and it works. So it seems like 42055 caused the problem, indeed. 115816 2 29072 gustavo 2009-03-30 06:46:12 -0700 Created attachment 29072 reduced test case The problem seems to happen for links with target="_parent". I haven't bothered creating a page with actual framesets, but that may be a good thing to do for a layout test. 115839 3 29076 darin 2009-03-30 10:22:58 -0700 Created attachment 29076 patch 115840 4 29076 aroben 2009-03-30 10:25:40 -0700 Comment on attachment 29076 patch r=me 115841 5 darin 2009-03-30 10:26:46 -0700 http://trac.webkit.org/changeset/42108 29072 2009-03-30 06:46:12 -0700 2009-03-30 06:46:12 -0700 reduced test case testparent.html text/html 395 gustavo PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEgVHJhbnNpdGlvbmFs Ly9FTiIgImh0dHA6Ly93d3cudzMub3JnL1RSL2h0bWw0L2xvb3NlLmR0ZCI+CjxodG1sPgo8aGVh ZD4KPG1ldGEgaHR0cC1lcXVpdj0iQ29udGVudC1UeXBlIiBjb250ZW50PSJ0ZXh0L2h0bWw7IGNo YXJzZXQ9VVRGLTgiPgo8dGl0bGU+VGVzdCBwYXJlbnQ8L3RpdGxlPgo8L2hlYWQ+Cgo8Ym9keT4K PGgxPlRlc3RpbmcgbmF2aWdhdGlvbiBhY3Rpb24gYnV0dG9uIHJlcG9ydGluZzwvaDE+Cgo8YSBo cmVmPSJodHRwOi8vZGViaWFuLm9yZy8iPkRlYmlhbjwvYT4KPGEgaHJlZj0iaHR0cDovL2RlYmlh bi5vcmcvIiB0YXJnZXQ9Il9wYXJlbnQiPkRlYmlhbjwvYT4KCjwvYm9keT4KPC9odG1sPgo= 29076 2009-03-30 10:22:58 -0700 2009-03-30 10:25:40 -0700 patch LoaderPatch.txt text/plain 2841 darin SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQyMTA2 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDMt MzAgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAyNDkxNjogUkVHUkVTU0lPTjogTmF2aWdh dGlvbkFjdGlvbiBwb2xpY3kgZGlzcGF0Y2ggYnJva2VuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDkxNgorCisgICAgICAgICogbG9hZGVyL0ZyYW1l TG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyOjpsb2FkVVJMKTogUmVh cnJhbmdlIHRoZSBjb2RlIHNvIHRoYXQgdGhlICJldmVudCIgUGFzc1JlZlB0cgorICAgICAgICBp cyBub3QgdXNlZCB0d2ljZS4gVGhpcyBhbHNvIG9wdGltaXplcyB0aGUgY2FzZSB3aGVyZSBhIGZy YW1lIG5hbWUgaXMgc3BlY2lmaWVkLAorICAgICAgICBidXQgaXQncyB0aGUgbmFtZSBvZiB0aGUg ZnJhbWUgYmVpbmcgbG9hZGVkLiBBbHNvIGNhbGxlZCByZWxlYXNlIGluIGFsbCB0aGUgZmluYWwK KyAgICAgICAgdXNlcyBvZiBGb3JtU3RhdGUuCisKIDIwMDktMDMtMzAgIEd1c3Rhdm8gTm9yb25o YSBTaWx2YSAgPGd1c3Rhdm8ubm9yb25oYUBjb2xsYWJvcmEuY28udWs+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgSG9sZ2VyIEZyZXl0aGVyLgpJbmRleDogbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBsb2FkZXIvRnJhbWVMb2FkZXIuY3BwCShyZXZpc2lvbiA0MjEwNikKKysr IGxvYWRlci9GcmFtZUxvYWRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIyMDgsMTMgKzIyMDgs MTYgQEAgdm9pZCBGcmFtZUxvYWRlcjo6bG9hZFVSTChjb25zdCBLVVJMJiBuZQogCiAgICAgQVNT RVJUKG5ld0xvYWRUeXBlICE9IEZyYW1lTG9hZFR5cGVTYW1lKTsKIAorICAgIEZyYW1lKiB0YXJn ZXRGcmFtZSA9IGZpbmRGcmFtZUZvck5hdmlnYXRpb24oZnJhbWVOYW1lKTsKKyAgICBpZiAodGFy Z2V0RnJhbWUgJiYgdGFyZ2V0RnJhbWUgIT0gbV9mcmFtZSkgeworICAgICAgICB0YXJnZXRGcmFt ZS0+bG9hZGVyKCktPmxvYWRVUkwobmV3VVJMLCByZWZlcnJlciwgU3RyaW5nKCksIGxvY2tIaXN0 b3J5LCBuZXdMb2FkVHlwZSwgZXZlbnQsIGZvcm1TdGF0ZS5yZWxlYXNlKCkpOworICAgICAgICBy ZXR1cm47CisgICAgfQorCiAgICAgTmF2aWdhdGlvbkFjdGlvbiBhY3Rpb24obmV3VVJMLCBuZXdM b2FkVHlwZSwgaXNGb3JtU3VibWlzc2lvbiwgZXZlbnQpOwogCi0gICAgaWYgKCFmcmFtZU5hbWUu aXNFbXB0eSgpKSB7Ci0gICAgICAgIGlmIChGcmFtZSogdGFyZ2V0RnJhbWUgPSBmaW5kRnJhbWVG b3JOYXZpZ2F0aW9uKGZyYW1lTmFtZSkpCi0gICAgICAgICAgICB0YXJnZXRGcmFtZS0+bG9hZGVy KCktPmxvYWRVUkwobmV3VVJMLCByZWZlcnJlciwgU3RyaW5nKCksIGxvY2tIaXN0b3J5LCBuZXdM b2FkVHlwZSwgZXZlbnQsIGZvcm1TdGF0ZSk7Ci0gICAgICAgIGVsc2UKLSAgICAgICAgICAgIGNo ZWNrTmV3V2luZG93UG9saWN5KGFjdGlvbiwgcmVxdWVzdCwgZm9ybVN0YXRlLCBmcmFtZU5hbWUp OworICAgIGlmICghdGFyZ2V0RnJhbWUgJiYgIWZyYW1lTmFtZS5pc0VtcHR5KCkpIHsKKyAgICAg ICAgY2hlY2tOZXdXaW5kb3dQb2xpY3koYWN0aW9uLCByZXF1ZXN0LCBmb3JtU3RhdGUucmVsZWFz ZSgpLCBmcmFtZU5hbWUpOwogICAgICAgICByZXR1cm47CiAgICAgfQogCkBAIC0yMjI4LDEyICsy MjMxLDEyIEBAIHZvaWQgRnJhbWVMb2FkZXI6OmxvYWRVUkwoY29uc3QgS1VSTCYgbmUKICAgICBp ZiAoc2hvdWxkU2Nyb2xsVG9BbmNob3IoaXNGb3JtU3VibWlzc2lvbiwgbmV3TG9hZFR5cGUsIG5l d1VSTCkpIHsKICAgICAgICAgb2xkRG9jdW1lbnRMb2FkZXItPnNldFRyaWdnZXJpbmdBY3Rpb24o YWN0aW9uKTsKICAgICAgICAgc3RvcFBvbGljeUNoZWNrKCk7Ci0gICAgICAgIGNoZWNrTmF2aWdh dGlvblBvbGljeShyZXF1ZXN0LCBvbGREb2N1bWVudExvYWRlci5nZXQoKSwgZm9ybVN0YXRlLAor ICAgICAgICBjaGVja05hdmlnYXRpb25Qb2xpY3kocmVxdWVzdCwgb2xkRG9jdW1lbnRMb2FkZXIu Z2V0KCksIGZvcm1TdGF0ZS5yZWxlYXNlKCksCiAgICAgICAgICAgICBjYWxsQ29udGludWVGcmFn bWVudFNjcm9sbEFmdGVyTmF2aWdhdGlvblBvbGljeSwgdGhpcyk7CiAgICAgfSBlbHNlIHsKICAg ICAgICAgLy8gbXVzdCBncmFiIHRoaXMgbm93LCBzaW5jZSB0aGlzIGxvYWQgbWF5IHN0b3AgdGhl IHByZXZpb3VzIGxvYWQgYW5kIGNsZWFyIHRoaXMgZmxhZwogICAgICAgICBib29sIGlzUmVkaXJl Y3QgPSBtX3F1aWNrUmVkaXJlY3RDb21pbmc7Ci0gICAgICAgIGxvYWRXaXRoTmF2aWdhdGlvbkFj dGlvbihyZXF1ZXN0LCBhY3Rpb24sIGxvY2tIaXN0b3J5LCBuZXdMb2FkVHlwZSwgZm9ybVN0YXRl KTsKKyAgICAgICAgbG9hZFdpdGhOYXZpZ2F0aW9uQWN0aW9uKHJlcXVlc3QsIGFjdGlvbiwgbG9j a0hpc3RvcnksIG5ld0xvYWRUeXBlLCBmb3JtU3RhdGUucmVsZWFzZSgpKTsKICAgICAgICAgaWYg KGlzUmVkaXJlY3QpIHsKICAgICAgICAgICAgIG1fcXVpY2tSZWRpcmVjdENvbWluZyA9IGZhbHNl OwogICAgICAgICAgICAgaWYgKG1fcHJvdmlzaW9uYWxEb2N1bWVudExvYWRlcikK