249149 2022-12-12 08:29:22 -0800 [Wasm-GC] Adjust struct.new opcode 2022-12-13 18:24:16 -0800 1 1 1 Unclassified WebKit WebAssembly Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 247394 1 asumu webkit-unassigned webkit-bug-importer oldest_to_newest 1918496 0 asumu 2022-12-12 08:29:22 -0800 The current implementation for Wasm GC struct operations is using an opcode for `struct.new` that is compatible with current V8 and Firefox (https://docs.google.com/document/d/14xWenN0lUoHa9TiDJd8yYR8ZKjgOhgO7iEmfrAuA1_M/edit#heading=h.9dwoku9340md), but not with the actual spec https://github.com/WebAssembly/gc/blob/main/proposals/gc/MVP.md. The difference is using 0xfb01 or 0xfb07. The opcode numbers are likely to get renumbered eventually as part of a "cleanup" phase of the proposal. I think we should potentially just support both opcode variations in the parser for now, which will allow us to run wasm programs produced with V8 in mind while also passing tests originating from the spec. 1918697 1 asumu 2022-12-12 19:07:31 -0800 Pull request: https://github.com/WebKit/WebKit/pull/7532 1919014 2 ews-feeder 2022-12-13 18:23:23 -0800 Committed 257821@main (67cbb39ef6cc): <https://commits.webkit.org/257821@main> Reviewed commits have been landed. Closing PR #7532 and removing active labels. 1919015 3 webkit-bug-importer 2022-12-13 18:24:16 -0800 <rdar://problem/103330695>